[SCM] Debian package checker branch, master, updated. 381c0f435f7321d0abe11ec203c064804f54d69a
The following commit has been merged in the master branch:
commit 5387ab68933dc1612cf41424ea45c0886affb994
Author: Russ Allbery <rra@debian.org>
Date: Sat Jun 28 19:38:56 2008 -0700
Check for deprecated SF redirector usage
* checks/watch-file{,.desc}:
+ [RA] Check for using the Sourceforge QA redirector with deprecated
arguments. Patch from Raphael Geissert.
diff --git a/checks/watch-file b/checks/watch-file
index 01dbfdf..37c1afe 100644
--- a/checks/watch-file
+++ b/checks/watch-file
@@ -90,6 +90,9 @@ while (<WATCH>) {
}
}
}
+ if (m%qa\.debian\.org/watch/sf\.php\?%) {
+ tag 'debian-watch-file-uses-deprecated-sf-redirector-method';
+ }
}
}
close WATCH;
diff --git a/checks/watch-file.desc b/checks/watch-file.desc
index 4ab8b0a..339b3f4 100644
--- a/checks/watch-file.desc
+++ b/checks/watch-file.desc
@@ -70,3 +70,10 @@ Info: The package ships a watch file although it is a Debian native
package. DEHS does not process watch files in native packages based on
the reasoning that native packages do not have upstreams to check for new
releases.
+
+Tag: debian-watch-file-uses-deprecated-sf-redirector-method
+Type: warning
+Info: The watch file seems to be passing arguments to the redirector
+ other than a path. Calling the SourceForge redirector with parameters like
+ <tt>project</tt> prevents uscan from generating working uri's to the files
+ and thus has been deprecated and is no longer supported by the redirector.
diff --git a/debian/changelog b/debian/changelog
index 4550e94..91f5973 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -49,6 +49,8 @@ lintian (1.24.2) unstable; urgency=low
files for other problems anyway. Allow whitespace around the
version declaration. More correctly handle continuation lines.
Patch from Raphael Geissert.
+ + [RA] Check for using the Sourceforge QA redirector with deprecated
+ arguments. Patch from Raphael Geissert.
* data/fields/obsolete-packages:
+ [RA] mailx is not obsolete. It's a virtual package. Thanks, martin
diff --git a/testset/scripts/debian/watch b/testset/scripts/debian/watch
index e215158..5a587ad 100644
--- a/testset/scripts/debian/watch
+++ b/testset/scripts/debian/watch
@@ -2,5 +2,5 @@
version=2
opts="uversionmangle=s/$/ds/" \
-http://www.example.com/dist/ scripts\.([\d.]+)\.tar\.gz
+http://qa.debian.org/watch/sf.php?project=foo scripts\.([\d.]+)\.tar\.gz
diff --git a/testset/tags.scripts b/testset/tags.scripts
index 935a7b7..bbe95cf 100644
--- a/testset/tags.scripts
+++ b/testset/tags.scripts
@@ -22,6 +22,7 @@ I: scripts: no-md5sums-control-file
W: scripts source: ancient-standards-version 3.2.1 (current is 3.8.0)
W: scripts source: binary-arch-rules-but-pkg-is-arch-indep
W: scripts source: changelog-should-mention-nmu
+W: scripts source: debian-watch-file-uses-deprecated-sf-redirector-method
W: scripts source: dpatch-missing-description 02_i_dont_have_a_description.patch
W: scripts source: maintainer-script-lacks-debhelper-token debian/postinst
W: scripts source: maintainer-script-lacks-debhelper-token debian/postrm
--
Debian package checker
Reply to: