[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Some patches



Raphael Geissert <atomo64+debian@gmail.com> writes:

> -        if (/^version=(\d+)(\s|\Z)/) {

> +    if (/^version\s*=\s*(\d+)(\s|$)/) {

Changing \Z to $ confuses the syntax highlighting in Emacs.  I'll change
that back.

> +        if (s/^opt(ion)?s=\"([^\"]+)\"\s+// || s/^opt(ion)?s=(\S+)\s+//) {
> +            $opts = $2;
> +            @opts = split(',', $opts);
> +	    unless (!defined($repack)) {
> +		    $mangle = 1 if grep { /^[ud]versionmangle.*=.*($repack)/ } @opts;
> +		    $dmangle = 1 if grep { /^dversionmangle.*=.*($repack)/ } @opts;
> +	    }
>          }

Tab and indent damage.

The rest looks good.  I'll apply with those fixes.

-- 
Russ Allbery (rra@debian.org)               <http://www.eyrie.org/~eagle/>


Reply to: