Re: [checks/scripts] [PATCH 3/4] shell script wrapper detection
On Sat, Jun 14, 2008 at 03:01:45PM +0200, Frank Lichtenheld wrote:
> On Sat, Jun 14, 2008 at 11:43:01AM +0100, Adam D. Barratt wrote:
> > On Sat, 2008-06-14 at 05:08 +0200, Frank Lichtenheld wrote:
> > > On Fri, Jun 13, 2008 at 03:09:00PM +0100, Adam D. Barratt wrote:
> > > > + last if (++$i > 55);
> > > > + if (/(^\s*|\beval\s*[\'\"]|(;|&&)\s*)exec\s*.+\s*.?\$$var.?\s*(--\s*)?.?(\${1:?\+.?)?(\$(\@|\*))?/) {
> > >
> > > I guess that regex could really use a little /x treatment.
> >
> > It's certainly not the nicest expression; it's grown somewhat over time.
> >
> > My first attempt at splitting it up results in:
> [...]
> > which is (at least imho) a significant improvement on the original.
> > Suggestions for better wording welcome. :)
>
> Yeah, that looks much better, thanks.
Applied with that version of the regex.
Gruesse,
--
Frank Lichtenheld <djpig@debian.org>
www: http://www.djpig.de/
Reply to: