Re: [checks/scripts] [PATCH 2/4] heredoc detection
On Sat, Jun 14, 2008 at 10:47:31AM +0100, Adam D. Barratt wrote:
> On Sat, 2008-06-14 at 05:05 +0200, Frank Lichtenheld wrote:
> > On Fri, Jun 13, 2008 at 03:08:41PM +0100, Adam D. Barratt wrote:
> > > @@ -615,6 +631,7 @@
> > >
> > > # We've checked for all the things we still want to notice in
> > > # double-quoted strings, so now remove those strings as well.
> > > + $cat_line =~ s/(^|[^<\\'\\-](?:\\\\)*)\"(?:\\.|[^\\\"])+\"/$1""/g;
> > > unless ($found) {
> > > $line =~ s/(^|[^\\\'](?:\\\\)*)\"(?:\\.|[^\\\"])+\"/$1""/g;
> >
> > [^<\\'\\-] should probably be [^<\\\'-]
>
> Yep, thanks; fixed in checkbashisms as well (the earlier version
> removing single quoted strings was correct).
Applied with the fix above and the replacement of the duplicated regexes
by variables.
Gruesse,
--
Frank Lichtenheld <djpig@debian.org>
www: http://www.djpig.de/
Reply to: