[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [checks/scripts] [PATCH 4/4] bashisms update



On Fri, Jun 13, 2008 at 03:09:18PM +0100, Adam D. Barratt wrote:
> --- checks/scripts.orig	2008-06-13 14:51:32.000000000 +0100
> +++ checks/scripts	2008-06-13 15:00:57.000000000 +0100
> @@ -542,6 +542,11 @@
>  	    if ($cat_string eq "" and $checkbashisms and !$within_another_shell) {
>  		my $found = 0;
>  		my $match = '';
> +		my $LEADIN = '(?:(^|[`&;(|{])\s*|(if|do|while)\s+)';
> +		my @bashism_single_quote_regexs = (
> +		  $LEADIN . 'echo\s+(?:-[^e]+\s+)?([\'])[^\']*(\\\[abcEfnrtv\\\0])+.*?[\']',
> +			# unsafe echo with backslashes
> +		);

If someone has the time it might be interesting to see whether using
qr'' instead of '' brings a measurable performance improvement.

Gruesse,
-- 
Frank Lichtenheld <djpig@debian.org>
www: http://www.djpig.de/


Reply to: