[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

lintian: r1345 - in trunk: checks data data/fields debian testset testset/relations/debian

Author: rra
Date: 2008-06-07 01:56:59 +0200 (Sat, 07 Jun 2008)
New Revision: 1345

Added:
   trunk/data/fields/
   trunk/data/fields/obsolete-packages
Modified:
   trunk/checks/common_data.pm
   trunk/checks/fields
   trunk/debian/changelog
   trunk/testset/relations/debian/control
   trunk/testset/tags.relations
Log:
  + [RA] Remove %known_obsolete_packages, now handled via data.
  + [RA] Use Lintian::Data to load the obsolete package list.
* data/fields/obsolete-packages:
  + [RA] Moved from common_data.pm.  Removed many very old packages that
    nothing depends on and added many new packages identified by Riku
    Voipio.  (Closes: #475400)

Modified: trunk/checks/common_data.pm
===================================================================
--- trunk/checks/common_data.pm	2008-06-06 23:29:03 UTC (rev 1344)
+++ trunk/checks/common_data.pm	2008-06-06 23:56:59 UTC (rev 1345)
@@ -119,11 +119,6 @@
 %known_build_essential = map { $_ => 1 }
     ('libc6-dev', 'libc-dev', 'gcc', 'g++', 'make', 'dpkg-dev');
 
-%known_obsolete_packages = map { $_ => 1 }
-    ('libstdc++2.8', 'ncurses3.4', 'slang0.99.38', 'newt0.25', 'mesag2',
-     'libjpegg6a', 'gmp2', 'libgtop0', 'libghttp0', 'libpgsql', 'tk4.2',
-     'tcl7.6', 'libpng0g', 'xbase', 'xlibs-dev', 'debmake', 'gcc-2.95');
-
 # Still in the archive but shouldn't be the primary Emacs dependency.
 %known_obsolete_emacs = map { $_ => 1 }
     ('emacs21');

Modified: trunk/checks/fields
===================================================================
--- trunk/checks/fields	2008-06-06 23:29:03 UTC (rev 1344)
+++ trunk/checks/fields	2008-06-06 23:56:59 UTC (rev 1345)
@@ -24,11 +24,13 @@
 
 package Lintian::fields;
 use strict;
+
 use lib "$ENV{'LINTIAN_ROOT'}/checks/";
 use common_data;
 use Dep;
 use Tags;
 use Util;
+use Lintian::Data;
 
 # The allowed Python dependencies currently.  This is the list of alternatives
 # that, either directly or through transitive dependencies that can be relied
@@ -121,6 +123,9 @@
 my $version;
 my $arch_indep;
 
+# Load obsolete packages list.
+my $obsolete_packages = Lintian::Data->new ('fields/obsolete-packages');
+
 local $/ = undef; #Read everything in one go
 
 unless (-d "fields") {
@@ -494,7 +499,7 @@
 					    if $rest;
 
 					tag "depends-on-obsolete-package", "$field: $part_d_orig"
-					    if ($known_obsolete_packages{$d_pkg} && &$is_dep_field($field));
+					    if ($obsolete_packages->known($d_pkg) && &$is_dep_field($field));
 
 					tag "depends-on-x-metapackage", "$field: $part_d_orig"
 					    if ($known_x_metapackages{$d_pkg} && ! $metapackage && &$is_dep_field($field));
@@ -683,7 +688,7 @@
 					tag "build-depends-on-essential-package-without-using-version", "$field: $part_d_orig"
 					    if ($d_pkg ne "coreutils" && $known_essential{$d_pkg} && ! $d_version->[0]);
 					tag "build-depends-on-obsolete-package", "$field: $part_d_orig"
-					    if ($known_obsolete_packages{$d_pkg} && &$is_dep_field($field));
+					    if ($obsolete_packages->known($d_pkg) && &$is_dep_field($field));
 
 					tag "build-depends-on-x-metapackage", "$field: $part_d_orig"
 					    if ($known_x_metapackages{$d_pkg} && &$is_dep_field($field));

Added: trunk/data/fields/obsolete-packages
===================================================================
--- trunk/data/fields/obsolete-packages	                        (rev 0)
+++ trunk/data/fields/obsolete-packages	2008-06-06 23:56:59 UTC (rev 1345)
@@ -0,0 +1,45 @@
+# Known obsolete packages.  Not all packages are added to this list, only
+# ones for which it's helpful for Lintian to warn about, such as
+# significant transitions or transitional packages that we're trying to
+# remove from the archive.
+#
+# Each list of packages should be tagged with the last Debian release in
+# which the package appeared so that we can remove long-obsolete entries
+# that are no longer worth checking for.
+
+# Last seen in sarge.
+xlibs-dev
+
+# Last seen in etch.
+debmake
+gcc-2.95
+
+# Last seen in lenny.
+cdrecord
+gaim
+gnomemeeting
+gs
+gs-aladdin
+gs-esp
+gs-gpl
+libglu1-xorg
+libglu1-xorg-dev
+libmime-perl
+libungif4-dev
+libxerces28
+libxerces28-dev
+mailx
+mkisofs
+netcdfg-dev
+pcmcia-cs
+python-pyopenssl
+ssh-krb5
+tetex-base
+tetex-bin
+tetex-extra
+x-dev
+xbase-clients
+xlibmesa-gl
+xlibmesa-gl-dev
+xlibmesa-glu
+xutils

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog	2008-06-06 23:29:03 UTC (rev 1344)
+++ trunk/debian/changelog	2008-06-06 23:56:59 UTC (rev 1345)
@@ -4,6 +4,7 @@
     + [RA] Fix code for filtering out NSS modules from SONAME checks.
   * checks/common_data.pm:
     + [RA] armel is now a standard architecture.
+    + [RA] Remove %known_obsolete_packages, now handled via data.
   * checks/control-file{.desc,}:
     + [RA] Check for self-dependencies in the source package since the
       current dpkg-gencontrol silently fixes them but they may indicate
@@ -18,6 +19,7 @@
       Conflicts, and other similar fields.  Warn if Breaks is used without
       a version.  Check that Breaks is not inconsistent with other
       dependency fields.
+    + [RA] Use Lintian::Data to load the obsolete package list.
   * checks/init.d:
     + [RA] Try to allow for postinst scripts written in Perl and still
       recognize the update-rc.d calls.
@@ -43,6 +45,11 @@
     + [RA] Policy 3.8.0 is now current and anything older than 3.7.2 is
       now ancient.
 
+  * data/fields/obsolete-packages:
+    + [RA] Moved from common_data.pm.  Removed many very old packages that
+      nothing depends on and added many new packages identified by Riku
+      Voipio.  (Closes: #475400)
+
   * debian/control:
     + [RA] Update standards version to 3.8.0.
   

Modified: trunk/testset/relations/debian/control
===================================================================
--- trunk/testset/relations/debian/control	2008-06-06 23:29:03 UTC (rev 1344)
+++ trunk/testset/relations/debian/control	2008-06-06 23:56:59 UTC (rev 1345)
@@ -38,6 +38,7 @@
 Provides: awk
 Recommends: ${shlibs:Depends}, relations-multiple-libs
 Breaks: libpng3 (<< 1.0), libpng2
+Suggests: x-dev
 Description: Duplicate library dependency relationships.
  Duplicate library dependency relationships.
  This tests the depending on different versions of the same library

Modified: trunk/testset/tags.relations
===================================================================
--- trunk/testset/tags.relations	2008-06-06 23:29:03 UTC (rev 1344)
+++ trunk/testset/tags.relations	2008-06-06 23:56:59 UTC (rev 1345)
@@ -10,6 +10,7 @@
 E: relations source: missing-build-dependency libmodule-build-perl
 E: relations source: section-category-mismatch Package relations-multiple-libs
 E: relations-multiple-libs: conflicts-with-dependency depends libpng2
+E: relations-multiple-libs: depends-on-obsolete-package suggests: x-dev
 E: relations-multiple-libs: description-synopsis-is-duplicated
 E: relations-multiple-libs: package-depends-on-multiple-libpng-versions libpng2 libpng3
 E: relations-multiple-libs: package-depends-on-multiple-libstdc-versions libstdc++2.10 libstdc++2.10-glibc2.2 libstdc++3.0
Reply to: