[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#483775: deprecated-chown-usage is prone to several false negatives



Package: lintian
Version: 1.23.49
Tags: patch

The deprecated-chown-usage check is too dummy and doesn't check for calls to 
chown with options. Attached is a patch with an improved regex.

Example:
chown -R root.root debian/tmp
chown root.root debian/tmp

By the way, this check should also be performed on debian/rules, and not just 
in maintainer scripts.

Cheers,
-- 
Atomo64 - Raphael

Please avoid sending me Word, PowerPoint or Excel attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html
Index: checks/scripts
===================================================================
--- checks/scripts	(revision 1326)
+++ checks/scripts	(working copy)
@@ -635,7 +635,7 @@
 		    tag 'start-stop-daemon-in-maintainer-script', "$file:$.";
 		}
 		# Don't use chown foo.bar
-		if (/(chown\s+[-_A-Za-z0-9]+\.[-_A-Za-z0-9]+)\s+/) {
+		if (/(chown(\s+--?[A-Za-z-]+)*\s+[-_A-Za-z0-9]+\.[-_A-Za-z0-9]+)\s+/) {
 		    tag "deprecated-chown-usage", "$file:$. \'$1\'";
 		}
 		if (/invoke-rc.d.*\|\| exit 0/) {

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: