[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#469222: [lib/Dep.pm] Skip empty terms in parse()



Package: lintian
Version: 1.23.45
Tags: patch

Hi,

Packages with empty terms in a relation field (e.g. "Depends: foo, ,
bar") appear to make lintian incorrectly trigger
stronger-dependency-implies-weaker.

Clearly such packages are broken, but it would be useful if lintian
either detected them or simply pretended the empty term didn't exist.
I've attached a (admittedly trivial) patch implementing the latter,
which fixes the false positive warnings for the package discussed on
#debian-devel earlier this evening.

Regards,

Adam
--- lib/Dep.pm.orig	2008-03-03 21:58:58.000000000 +0000
+++ lib/Dep.pm	2008-03-03 21:58:13.000000000 +0000
@@ -67,6 +67,7 @@
 sub parse {
     my @deps;
     for (split(/\s*,\s*/, $_[0])) {
+	next if /^$/;
 	my @alts;
 	if (/^perl\s+\|\s+perl5$/ or /^perl5\s+\|\s+perl\s+/) {
 	    $_ = 'perl5';

Reply to: