[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#468876: lintian: please warn when icons are installed in the wrong dirs



Paul Wise <pabs@debian.org> writes:

> Package: lintian
> Version: 1.23.45
> Severity: wishlist
>
> The password-gorilla package that I recently sponsored contains the
> following files:
>
> /usr/share/icons/hicolor/16x16/password-gorilla.png
> /usr/share/icons/hicolor/32x32/password-gorilla.png
> /usr/share/icons/hicolor/48x48/password-gorilla.png
>
> These are incorrect and will not show up in freedesktop menus because
> the directory is not listed in the index.theme file. Please check that
> icons in /usr/share/icons/hicolor are in one of the below directories.

[snipped tons of directories]

This looks rather unmaintainable from a lintian perspective unless there's
some (rarely-changing) standard that specifies those directories.  If I'm
reading the implications of your message correctly, that list could change
arbitrarily with each release of the hicolor theme package.  I don't see
any clean way that we could maintain this.  (Also, this only applies to
desktop files that don't give a full path to the icon, no?)

> Also, when there is a package that contains an index.theme file, it
> would be good if lintian could validate the locations of images in the
> package against the Directories parameter in it.

Hm, I guess.  Parsing desktop files and trying to verify things in them is
really hard due to the lack of standardization of desktop files, but this
looks reasonably self-contained.

-- 
Russ Allbery (rra@debian.org)               <http://www.eyrie.org/~eagle/>



Reply to: