[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

lintian: r1138 - in trunk: checks debian testset testset/manpages



Author: rra
Date: 2008-01-22 06:12:11 +0100 (Tue, 22 Jan 2008)
New Revision: 1138

Modified:
   trunk/checks/manpages
   trunk/debian/changelog
   trunk/testset/manpages/include.3
   trunk/testset/tags.manpages
Log:
* checks/manpages:
  + [RA] Make hyphen-used-as-minus-sign more conservative to avoid false
    positives with non-ASCII text and catch hyphens at the start of
    lines.  Thanks, Michal ?\196?\140iha?\197?\153.  (Closes: #459871)

Modified: trunk/checks/manpages
===================================================================
--- trunk/checks/manpages	2008-01-22 04:56:47 UTC (rev 1137)
+++ trunk/checks/manpages	2008-01-22 05:12:11 UTC (rev 1138)
@@ -304,9 +304,11 @@
 	    # Catch hyphens used as minus signs by looking for ones at the
 	    # beginning of a word, but don't generate false positives on \s-1
 	    # (small font), \*(-- (pod2man long dash), or things like \h'-1'.
-	    if ($line =~ /^[^\.].*
-			   [^\w\\]
-			   (?<! \\s | \*\( | \(- | \w\' )
+	    if ($line =~ /^(
+                            ([^\.].*)?
+                            [\s\'\"\`\(\[]
+                            (?<! \\s | \*\( | \(- | \w\' )
+                           )?
 			   (--?\w+)/ox) {
 		$hc++;
 		tag "hyphen-used-as-minus-sign", "$file:$lc" if $hc <= 10 or $ENV{'LINTIAN_DEBUG'};

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog	2008-01-22 04:56:47 UTC (rev 1137)
+++ trunk/debian/changelog	2008-01-22 05:12:11 UTC (rev 1138)
@@ -23,6 +23,10 @@
     + [RA] Downgrade a missing LSB Short-Description keyword to info since
       it's not required for functionality.  Thanks, Petter Reinholdtsen.
       (Closes: #460499)
+  * checks/manpages:
+    + [RA] Make hyphen-used-as-minus-sign more conservative to avoid false
+      positives with non-ASCII text and catch hyphens at the start of
+      lines.  Thanks, Michal Čihař.  (Closes: #459871)
   * checks/menu-format:
     + [RA] Avoid a Perl warning for desktop entries without Exec.
   * checks/menus:

Modified: trunk/testset/manpages/include.3
===================================================================
--- trunk/testset/manpages/include.3	2008-01-22 04:56:47 UTC (rev 1137)
+++ trunk/testset/manpages/include.3	2008-01-22 05:12:11 UTC (rev 1138)
@@ -4,5 +4,13 @@
 .SH INCLUDED BIT
 .nr zY 1
 .so man3/included.3
+.SH HYPHENS
+This isn't a hyphen\*(--just a long dash\*(--and \h'-1' also isn't, nor
+should we warn about `\-' or \-a, but -a
+and `-' (nope, that's fine) are bad news.  So is
+--foo and
+(--bar)
+"--baz"
+and '--foo'.
 .SH SEE ALSO
 included(3)

Modified: trunk/testset/tags.manpages
===================================================================
--- trunk/testset/tags.manpages	2008-01-22 04:56:47 UTC (rev 1137)
+++ trunk/testset/tags.manpages	2008-01-22 05:12:11 UTC (rev 1138)
@@ -32,6 +32,11 @@
 E: manpages: stray-directory-in-manpage-directory usr/share/man/man1/not-a-man-page.1.gz/
 E: manpages: subdir-in-usr-bin usr/bin/bin/
 E: manpages: x11-games-should-be-in-usr-games usr/X11R6/man/man6/X11R6-binary.man
+I: manpages: hyphen-used-as-minus-sign usr/share/man/man3/include.3.gz:11
+I: manpages: hyphen-used-as-minus-sign usr/share/man/man3/include.3.gz:12
+I: manpages: hyphen-used-as-minus-sign usr/share/man/man3/include.3.gz:13
+I: manpages: hyphen-used-as-minus-sign usr/share/man/man3/include.3.gz:14
+I: manpages: hyphen-used-as-minus-sign usr/share/man/man3/include.3.gz:9
 I: manpages: no-md5sums-control-file
 I: manpages: unused-override foo-tag-that-does-not-exist
 N: 2 tags overridden (1 error, 1 info)


Reply to: