[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#459851: lintian: outputs wrong total count of overrides



Cyril Brulebois <cyril.brulebois@enst-bretagne.fr> writes:
> On 11/01/2008, Russ Allbery wrote:
>> Chris Lamb <chris@chris-lamb.co.uk> writes:

>>> I'm not sure this is a bug, per se.
>>> "several-sonames-in-same-package" is an "info" tag, whilst
>>> "package-name-doesnt-match-sonames" is a "warning" tag.  Thus, you
>>> only override one ">= warning" tag.

>> Yeah, that's the correct analysis, I think.

> I also thought of that, but reading the manpage, it is about the *total*
> count, that's why I was thinking that it needed at least some
> clarification.

Yeah, the man page is lying to you.  :)

>> I think the right fix is probably to keep the current behavior if -I
>> wasn't given, but if -I was given, add the number of info tags
>> overridden to the summary as well.

> Agreed. I'd also suggest getting rid of the “total” word in the
> manpage, “count” is enough. (Maybe also adding some words explaining
> that this count depends on the options that are passed, like -I, but
> that would a bit overkill, I believe, once that your “right fix” is
> implemented.)

Hm, or we could list the total including info tags and only mention the
info overrides explicitly if -I is given.  So without -I, you'd get
something like:

N: 2 overrides (1 warning)

That probably wouldn't be any less confusing, though.

I'd like to ahve the total remain, so maybe we should just always list the
info total as well, whether -I is included or not.

N: 2 overrides (1 warning, 1 info)

(Completely separately, I'm really questioning the utility of the two tags
you're overriding, particularly the info tag, and they may just go away or
be significantly modified in a later version of lintian.)

-- 
Russ Allbery (rra@debian.org)               <http://www.eyrie.org/~eagle/>



Reply to: