[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#459509: Regression in 'binary-with-bad-dynamic-table' test



Package: lintian
Version: 1.23.41
Severity: wishlist
Tags: patch

There is a regression in 'binary-with-bad-dynamic-table' test, which is
causing the "debug" testcase to fail.

This is because the "objdump: ./usr/lib/libhello.so.dbg: Invalid operation"
message does not necessarily appear in "objdump-info" at the beginning of the
line.

The patch is simple:

===================================================================
--- checks/binaries     (revision 1122)
+++ checks/binaries     (working copy)
@@ -107,7 +107,7 @@
             tag "apparently-corrupted-elf-binary", "$file";
 	} elsif (m/^objdump: \.(.*?): Packed with UPX$/) {
 	    tag "binary-file-compressed-with-upx", "$file";
-	} elsif (m/^objdump: \.(.*?): Invalid operation$/) {
+	} elsif (m/objdump: \.(.*?): Invalid operation$/) {
 	    tag "binary-with-bad-dynamic-table", "$file" unless $file =~
  m%^\./usr/lib/debug/%; } elsif (m/CXXABI/) {


Regards,

-- 
Chris Lamb, UK                                       chris@chris-lamb.co.uk
                                                            GPG: 0x634F9A20
Index: checks/files
===================================================================
--- checks/files	(revision 1122)
+++ checks/files	(working copy)
@@ -581,6 +581,11 @@
 	    tag "svk-commit-file-in-package", "$file";
 	}
 
+	# ---------------- .gitignore files
+	if ($file =~ m/\.gitignore$/) {
+	    tag "package-installs-gitignore", "$file";
+	}
+
 	# ---------------- executables with language extensions
 	if ($file =~ m,^(usr/)?(s?bin|games)/[^/]+\.(pl|sh|py)$,) {
 	    tag "script-with-language-extension", "$file";
Index: checks/files.desc
===================================================================
--- checks/files.desc	(revision 1122)
+++ checks/files.desc	(working copy)
@@ -505,6 +505,17 @@
  or by telling MakeMaker to use vendor install dirs; consult a recent
  version of Perl policy. Perl 5.6.0-12 or higher supports this.
 
+Tag: package-installs-gitignore
+Type: error
+Info: Package contains a .gitignore file. These files are used by the Git
+ revision control system to specify intentionally untracked files that
+ it should ignore.
+ .
+ It was most likely installed by accident. These files are useless and
+ can be suppressed by adding the following to <tt>debian/rules</tt>:
+ .
+   find debian/<i>pkg</i> -type f -name .gitignore | xargs rm -f
+
 Tag: zero-byte-file-in-doc-directory
 Type: warning
 Info: Package contains a file which is empty.
Index: testset/tags.filenames
===================================================================
--- testset/tags.filenames	(revision 1122)
+++ testset/tags.filenames	(working copy)
@@ -13,6 +13,7 @@
 E: filenames: package-installs-file-to-usr-x11r6 usr/X11R6/
 E: filenames: package-installs-file-to-usr-x11r6-bin usr/X11R6/bin/
 E: filenames: package-installs-file-to-usr-x11r6-bin usr/X11R6/bin/testxbin2
+E: filenames: package-installs-gitignore usr/lib/perl5/foo/.gitignore
 E: filenames: package-installs-packlist usr/lib/perl5/foo/.packlist
 E: filenames: postinst-does-not-call-updatemenus usr/share/menu/menu
 E: filenames: postrm-does-not-call-updatemenus usr/share/menu/menu
Index: testset/filenames/debian/rules
===================================================================
--- testset/filenames/debian/rules	(revision 1122)
+++ testset/filenames/debian/rules	(working copy)
@@ -53,6 +53,7 @@
 	mkdir debian/tmp/usr/lib/perl5/.arch-ids
 	mkdir debian/tmp/usr/lib/perl5/.bzr
 	install -d debian/tmp/usr/share/perl5
+	echo foo > debian/tmp/usr/lib/perl5/foo/.gitignore
 
 	touch debian/tmp/usr/lib/perl5/foo/.packlist
 	chmod 644 debian/tmp/usr/lib/perl5/foo/.packlist

Attachment: signature.asc
Description: PGP signature


Reply to: