lintian: r1105 - in trunk: checks debian testset
Author: rra
Date: 2008-01-04 05:18:28 +0100 (Fri, 04 Jan 2008)
New Revision: 1105
Modified:
trunk/checks/menu-format
trunk/checks/menu-format.desc
trunk/debian/changelog
trunk/testset/tags.binary
Log:
* checks/menu-format{.desc,}:
+ [RA] Warn about use of su wrappers other than su-to-root for desktop
and Live CD support. Thanks, Daniel Baumann. (Closes: #453931)
Modified: trunk/checks/menu-format
===================================================================
--- trunk/checks/menu-format 2008-01-04 04:00:11 UTC (rev 1104)
+++ trunk/checks/menu-format 2008-01-04 04:18:28 UTC (rev 1105)
@@ -884,6 +884,9 @@
}
}
tag 'su-wrapper-without--c', "$location $wrapper" unless $cmd;
+ if ($wrapper !~ /su-to-root/) {
+ tag 'su-wrapper-not-su-to-root', "$location $wrapper";
+ }
} else {
$cmd = $com[0];
}
@@ -893,4 +896,8 @@
1;
+# Local Variables:
+# indent-tabs-mode: t
+# cperl-indent-level: 4
+# End:
# vim: syntax=perl ts=8 sw=4
Modified: trunk/checks/menu-format.desc
===================================================================
--- trunk/checks/menu-format.desc 2008-01-04 04:00:11 UTC (rev 1104)
+++ trunk/checks/menu-format.desc 2008-01-04 04:18:28 UTC (rev 1105)
@@ -142,19 +142,29 @@
Tag: su-wrapper-without--c
Type: error
-Info: The menu item command uses an su wrapper such as su-to-root without
- the -c flag. This is a syntax error.
+Info: The menu item command or desktop file uses an su wrapper such as
+ su-to-root without the -c flag. This is a syntax error.
Ref: su-to-root(1)
Tag: su-to-root-with-usr-sbin
Type: warning
-Info: The menu item command uses su-to-root as /usr/sbin/su-to-root
- Since sarge su-to-root is located in /usr/bin and /usr/sbin/su-to-root
- is only a compatibility symlink that may get dropped in the future.
+Info: The menu item or desktop file command uses su-to-root as
+ /usr/sbin/su-to-root. Since sarge su-to-root is located in /usr/bin and
+ /usr/sbin/su-to-root is only a compatibility symlink that may get dropped
+ in the future.
.
Since su-to-root is now located in /usr/bin you can use it without
absolute path now.
+Tag: su-wrapper-not-su-to-root
+Type: warning
+Info: The menu item or desktop file command uses an su wrapper other than
+ su-to-root. On Debian systems, please use <tt>su-to-root -X</tt>, which
+ will pick the correct wrapper based on what's installed on the system and
+ the current desktop environment. Using su-to-root is also important for
+ Live CD systems which need to use sudo rather than su. su-to-root
+ permits global configuration to use sudo.
+
Tag: menu-item-needs-dwww
Type: warning
Info: The menu item has needs=dwww. This is deprecated. Instead, you should
Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog 2008-01-04 04:00:11 UTC (rev 1104)
+++ trunk/debian/changelog 2008-01-04 04:18:28 UTC (rev 1105)
@@ -36,10 +36,12 @@
* checks/init.d{.desc,}:
+ [RA] Warn of init scripts that list S in their Default-Stop LSB
keyword. Thanks, Petter Reinholdtsen. (Closes: #458596)
- * checks/menu-format.desc:
+ * checks/menu-format{.desc,}:
+ [RA] Fix non-wm-module-in-wm-modules-menu-section pluralization to
match the check and reword the long description to be hopefully
clearer. Thanks, Martín Ferrari. (Closes: #457527)
+ + [RA] Warn about use of su wrappers other than su-to-root for desktop
+ and Live CD support. Thanks, Daniel Baumann. (Closes: #453931)
* checks/menus{.desc,}:
+ [RA] Spelling errors in doc-base files should only be warnings. Do
picky spelling and capitalization checks on the abstract and title
Modified: trunk/testset/tags.binary
===================================================================
--- trunk/testset/tags.binary 2008-01-04 04:00:11 UTC (rev 1104)
+++ trunk/testset/tags.binary 2008-01-04 04:18:28 UTC (rev 1105)
@@ -112,6 +112,8 @@
W: binary: spelling-error-in-news-debian usefull useful
W: binary: su-to-root-with-usr-sbin /usr/lib/menu/binary:4
W: binary: su-to-root-with-usr-sbin /usr/share/menu/binary:4
+W: binary: su-wrapper-not-su-to-root /usr/lib/menu/binary:3 sux
+W: binary: su-wrapper-not-su-to-root /usr/share/menu/binary:3 sux
W: binary: superfluous-clutter-in-homepage <http://lintian.debian.org/>
W: binary: symlink-should-be-relative usr/share/doc/binary/html/ch3.html /usr/share/doc/binary/htm/ch1.html
W: binary: syntax-error-in-debian-changelog line 16 "couldn't parse date The, 15 Apr 2004 23:33:51 +0200"
Reply to: