lintian: r1057 - in trunk: checks debian testset testset/libbaz/debian
Author: rra
Date: 2007-12-07 05:38:06 +0100 (Fri, 07 Dec 2007)
New Revision: 1057
Added:
trunk/testset/libbaz/debian/compat
Modified:
trunk/checks/files
trunk/checks/files.desc
trunk/debian/changelog
trunk/testset/libbaz/debian/control
trunk/testset/libbaz/debian/rules
trunk/testset/tags.libbaz
Log:
* checks/files:
+ [RA] Warn about packages providing files in /usr/lib/debug that
aren't named -dbg. Thanks, Joerg Jaspert.
Modified: trunk/checks/files
===================================================================
--- trunk/checks/files 2007-12-07 04:26:32 UTC (rev 1056)
+++ trunk/checks/files 2007-12-07 04:38:06 UTC (rev 1057)
@@ -32,6 +32,7 @@
my $file;
my $source_pkg = "";
my $pkg_section = "";
+my $pkg_priority = "";
my $is_python;
my $is_perl;
my $has_binary_perl_file;
@@ -59,14 +60,16 @@
}
close(IN);
-#Get source package name, if possible
+# Get source package name, if possible.
if (open (SOURCE, '<', "fields/source")) {
chomp ($source_pkg = (<SOURCE> || ""));
+ close SOURCE;
}
-#get section:
+# Get section.
if (open (SECTION, '<', "fields/section")) {
chomp ($pkg_section = <SECTION>);
+ close SECTION;
}
# find out which files are scripts
@@ -78,8 +81,9 @@
}
close(SCRIPTS);
-# We only want to warn about this once.
+# We only want to warn about these once.
my $warned_x11_predepends = 0;
+my $warned_debug_name = 0;
my %dir_counts;
@@ -289,6 +293,15 @@
tag "package-installs-file-to-usr-x11r6", "$file";
}
+ # ---------------- /usr/lib/debug
+ elsif ($file =~ m,^usr/lib/debug/\S,) {
+ unless ($warned_debug_name) {
+ tag "debug-package-should-be-named-dbg", "$file"
+ unless ($pkg =~ /-dbg$/);
+ $warned_debug_name = 1;
+ }
+ }
+
# ---------------- /usr/lib/sgml
elsif ($file =~ m,^usr/lib/sgml/\S,) {
tag "file-in-usr-lib-sgml", $file;
Modified: trunk/checks/files.desc
===================================================================
--- trunk/checks/files.desc 2007-12-07 04:26:32 UTC (rev 1056)
+++ trunk/checks/files.desc 2007-12-07 04:38:06 UTC (rev 1057)
@@ -718,3 +718,10 @@
Info: This package is marked as part of the section games, but contains
exectuables in <tt>/bin</tt> or <tt>/usr/bin/</tt>. This can be intentional,
but is usually a mistake.
+
+Tag: debug-package-should-be-named-dbg
+Type: warning
+Info: This package provides at least one file in <tt>/usr/lib/debug</tt>,
+ which is intended for detached debugging symbols, but the package name
+ does not end in "-dbg". Detached debugging symbols should be put into a
+ separate package, Priority: extra, with a package name ending in "-dbg".
Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog 2007-12-07 04:26:32 UTC (rev 1056)
+++ trunk/debian/changelog 2007-12-07 04:38:06 UTC (rev 1057)
@@ -6,6 +6,9 @@
+ [RA] Warn about lib.*-dev packages not in section libdevel.
+ [RA] Warn about debug packages that aren't priority: extra. Thanks,
Joerg Jaspert. (Closes: #454358)
+ * checks/files:
+ + [RA] Warn about packages providing files in /usr/lib/debug that
+ aren't named -dbg. Thanks, Joerg Jaspert.
-- Russ Allbery <rra@debian.org> Thu, 06 Dec 2007 20:24:55 -0800
Added: trunk/testset/libbaz/debian/compat
===================================================================
--- trunk/testset/libbaz/debian/compat 2007-12-07 04:26:32 UTC (rev 1056)
+++ trunk/testset/libbaz/debian/compat 2007-12-07 04:38:06 UTC (rev 1057)
@@ -0,0 +1 @@
+5
Modified: trunk/testset/libbaz/debian/control
===================================================================
--- trunk/testset/libbaz/debian/control 2007-12-07 04:26:32 UTC (rev 1056)
+++ trunk/testset/libbaz/debian/control 2007-12-07 04:38:06 UTC (rev 1057)
@@ -28,3 +28,10 @@
Depends: ${shlibs:Depends}, libbaz2 (= ${Source-Version})
Description: development package
Regression test for lintian's handling of libraries
+
+Package: libbaz2-dbg
+Architecture: any
+Depends: libbaz2 (= ${binary:Version})
+Priority: optional
+Description: debugging package
+ Regression test for lintian's handling of libraries
Modified: trunk/testset/libbaz/debian/rules
===================================================================
--- trunk/testset/libbaz/debian/rules 2007-12-07 04:26:32 UTC (rev 1056)
+++ trunk/testset/libbaz/debian/rules 2007-12-07 04:38:06 UTC (rev 1057)
@@ -27,8 +27,8 @@
chmod a-x debian/libbaz2/usr/lib/*
# General stuff that is tested in other testsets:
- dh_installdocs -plibbaz2 -plibbaz2-dev
- dh_compress -plibbaz2 -plibbaz2-dev
+ dh_installdocs -plibbaz2 -plibbaz2-dev -plibbaz2-dbg
+ dh_compress -plibbaz2 -plibbaz2-dev -plibbaz2-dbg
# Mess up the libbaz2 changelog files to test the symlink handling.
ln -s /usr/share/doc/lintian/changelog.gz \
@@ -38,15 +38,15 @@
ln -s foo debian/libbaz2-dev/usr/share/doc/libbaz2-dev/changelog
# Okay, if either line is omitted, it should be noted
- dh_strip -plibbaz2 -plibbaz2-dev
- dh_makeshlibs -plibbaz2 -plibbaz2-dev
- dh_shlibdeps -plibbaz2 -plibbaz2-dev
+ dh_strip --dbg-package=libbaz2-dbg -plibbaz2 -plibbaz2-dev
+ dh_makeshlibs -plibbaz2 -plibbaz2-dev -plibbaz2-dbg
+ dh_shlibdeps -plibbaz2 -plibbaz2-dev -plibbaz2-dbg
# and again, regular packaging stuff
- dh_installdeb -plibbaz2 -plibbaz2-dev
+ dh_installdeb -plibbaz2 -plibbaz2-dev -plibbaz2-dbg
echo udeb: libbaz2 1.0 libbaz2 >> debian/libbaz2/DEBIAN/shlibs
- dh_gencontrol -plibbaz2 -plibbaz2-dev
- dh_builddeb -plibbaz2 -plibbaz2-dev
+ dh_gencontrol -plibbaz2 -plibbaz2-dev -plibbaz2-dbg
+ dh_builddeb -plibbaz2 -plibbaz2-dev -plibbaz2-dbg
# and the incorrect one
binary-arch: build binary-correct
Modified: trunk/testset/tags.libbaz
===================================================================
--- trunk/testset/tags.libbaz 2007-12-07 04:26:32 UTC (rev 1056)
+++ trunk/testset/tags.libbaz 2007-12-07 04:38:06 UTC (rev 1057)
@@ -14,15 +14,16 @@
E: libbaz1: unstripped-binary-or-object ./usr/lib/libbaz1.so.1.0.3b
E: libbaz1: unstripped-binary-or-object ./usr/lib/libbaz3.so.1.0.3b
E: libbaz1: unstripped-binary-or-object ./usr/lib/libfoo2.so.1.0.3b
-E: libbaz2: postinst-must-call-ldconfig usr/lib/libbaz2.so.1.0.3b
+E: libbaz2-dbg: changelog-file-missing-in-native-package
+I: libbaz source: package-lacks-versioned-build-depends-on-debhelper 5
I: libbaz1: no-md5sums-control-file
I: libbaz1: several-sonames-in-same-package libbaz2.so.1.0 libbaz3.so.1
+I: libbaz2-dbg: no-md5sums-control-file
I: libbaz2-dev: no-md5sums-control-file
I: libbaz2: no-md5sums-control-file
N: libbaz_1.dsc overrode 4 warnings
W: libbaz source: ancient-standards-version 3.2.1 (current is 3.7.3)
W: libbaz source: changelog-should-mention-nmu
-W: libbaz source: package-uses-deprecated-debhelper-compat-version 1
W: libbaz source: source-nmu-has-incorrect-version-number 1
W: libbaz source: substvar-source-version-is-deprecated libbaz2-dev
W: libbaz1-dev: dev-package-should-be-section-libdevel libbaz1-dev
@@ -38,6 +39,7 @@
W: libbaz1: unused-shlib-entry-in-control-file libdoesntexist2 1.0
W: libbaz1: unused-shlib-entry-in-control-file udeb: libdoesntexist2 1.0
W: libbaz1: zero-byte-file-in-doc-directory usr/share/doc/README.Debian
+W: libbaz2-dbg: debug-package-should-be-priority-extra libbaz2-dbg
W: libbaz2-dev: changelog-file-not-compressed changelog
W: libbaz2-dev: dev-package-should-be-section-libdevel libbaz2-dev
W: libbaz2: debian-changelog-file-is-a-symlink
Reply to: