Your message dated Wed, 05 Dec 2007 01:47:02 +0000 with message-id <E1IzjLq-0000zT-Sp@ries.debian.org> and subject line Bug#454239: fixed in lintian 1.23.37 has caused the attached Bug report to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what I am talking about this indicates a serious mail system misconfiguration somewhere. Please contact me immediately.) Debian bug tracking system administrator (administrator, Debian Bugs database)
--- Begin Message ---
- To: submit@bugs.debian.org
- Subject: symlink-should-be-relative: warning instead of error
- From: Thijs Kinkhorst <thijs@debian.org>
- Date: Tue, 4 Dec 2007 09:40:18 +0100
- Message-id: <[🔎] 200712040940.20344.thijs@debian.org>
Package: lintian Version: 1.23.36 Severity: minor Tags: patch Hi! In my package "mailman", I have converted two symlinks from relative to absolute. The relative symlinks gave trouble for a number of different users that had symlinked the targets themselves, and linking to relative links gives different results than linking to absolute ones. Lintian gave me the following error: E: mailman: symlink-should-be-relative var/lib/mailman/locks /var/lock/mailman However, Policy does allow absolute symlinks, it just recommends in general to use relative ones: > 10.5 Symbolic links > > In general, symbolic links within a top-level directory should be relative, > and symbolic links pointing from one top-level directory into another > should be absolute. (A top-level directory is a sub-directory of the root > directory /.) I read that as "it's ok if you have a good reason". Therefore, I think a lintian warning would be more appropriate than an error. Attached patch implements this change. Please consider applying it. Thanks, Thijsdiff -Nru /tmp/coFypZabC0/lintian-1.23.36/checks/files.desc /tmp/lnog9si6LE/lintian-1.23.37/checks/files.desc --- /tmp/coFypZabC0/lintian-1.23.36/checks/files.desc 2007-10-16 04:54:52.000000000 +0200 +++ /tmp/lnog9si6LE/lintian-1.23.37/checks/files.desc 2007-12-04 09:33:54.000000000 +0100 @@ -276,7 +276,7 @@ Ref: policy 10.5 Tag: symlink-should-be-relative -Type: error +Type: warning Info: Symlinks to files which are in the same top-level directory, should be relative according to policy (i.e., files within /usr, should be relative etc., while files from /usr to /etc should be absolute) diff -Nru /tmp/coFypZabC0/lintian-1.23.36/testset/tags.binary /tmp/lnog9si6LE/lintian-1.23.37/testset/tags.binary --- /tmp/coFypZabC0/lintian-1.23.36/testset/tags.binary 2007-10-15 22:03:17.000000000 +0200 +++ /tmp/lnog9si6LE/lintian-1.23.37/testset/tags.binary 2007-12-04 09:34:29.000000000 +0100 @@ -33,7 +33,7 @@ E: binary: su-wrapper-without--c /usr/share/menu/binary:3 sux E: binary: suidregister-used-in-maintainer-script postinst E: binary: symlink-contains-spurious-segments usr/share/doc/binary/html/ch2.html ../html/./ch1.html -E: binary: symlink-should-be-relative usr/share/doc/binary/html/ch3.html /usr/share/doc/binary/htm/ch1.html +W: binary: symlink-should-be-relative usr/share/doc/binary/html/ch3.html /usr/share/doc/binary/htm/ch1.html E: binary: unstripped-binary-or-object ./usr/bin/hello I: binary source: xs-vcs-header-in-debian-control xs-vcs-browser I: binary: arch-dep-package-has-big-usr-share diff -Nru /tmp/coFypZabC0/lintian-1.23.36/testset/tags.filenames /tmp/lnog9si6LE/lintian-1.23.37/testset/tags.filenames --- /tmp/coFypZabC0/lintian-1.23.36/testset/tags.filenames 2007-10-16 04:58:34.000000000 +0200 +++ /tmp/lnog9si6LE/lintian-1.23.37/testset/tags.filenames 2007-12-04 09:34:16.000000000 +0100 @@ -23,7 +23,7 @@ E: filenames: symlink-has-too-many-up-segments usr/lib/filenames/symlink2wrong ../../../../etc/symlink E: filenames: symlink-should-be-absolute usr/lib/filenames/symlink10wrong ../../.. E: filenames: symlink-should-be-absolute usr/lib/filenames/symlink1wrong ../../../etc/symlink -E: filenames: symlink-should-be-relative usr/lib/filenames/symlink3wrong /usr/lib/filenames/symlink2 +W: filenames: symlink-should-be-relative usr/lib/filenames/symlink3wrong /usr/lib/filenames/symlink2 E: filenames: use-of-compat-symlink usr/bin/X11/ E: filenames: use-of-compat-symlink usr/bin/X11/testxbin I: filenames: file-in-usr-something-x11-without-pre-depends usr/include/X11/ diff -Nru /tmp/coFypZabC0/lintian-1.23.36/testset/tags.libbaz /tmp/lnog9si6LE/lintian-1.23.37/testset/tags.libbaz --- /tmp/coFypZabC0/lintian-1.23.36/testset/tags.libbaz 2007-06-18 12:17:51.000000000 +0200 +++ /tmp/lnog9si6LE/lintian-1.23.37/testset/tags.libbaz 2007-12-04 09:34:23.000000000 +0100 @@ -15,7 +15,7 @@ E: libbaz1: unstripped-binary-or-object ./usr/lib/libbaz3.so.1.0.3b E: libbaz1: unstripped-binary-or-object ./usr/lib/libfoo2.so.1.0.3b E: libbaz2: postinst-must-call-ldconfig usr/lib/libbaz2.so.1.0.3b -E: libbaz2: symlink-should-be-relative usr/share/doc/libbaz2/changelog.gz /usr/share/doc/lintian/changelog.gz +W: libbaz2: symlink-should-be-relative usr/share/doc/libbaz2/changelog.gz /usr/share/doc/lintian/changelog.gz I: libbaz1: no-md5sums-control-file I: libbaz1: possible-non-posix-code-in-maintainer-script postinst:6 '[ -d /usr/doc -a ! -e /usr/doc/$PKG -a ' I: libbaz1: possible-non-posix-code-in-maintainer-script prerm:5 '[ \( "$1" = "upgrade" -o "$1" = "remove" \) -a 'Attachment: pgpi6C_aOtovy.pgp
Description: PGP signature
--- End Message ---
--- Begin Message ---
- To: 454239-close@bugs.debian.org
- Subject: Bug#454239: fixed in lintian 1.23.37
- From: Russ Allbery <rra@debian.org>
- Date: Wed, 05 Dec 2007 01:47:02 +0000
- Message-id: <E1IzjLq-0000zT-Sp@ries.debian.org>
Source: lintian Source-Version: 1.23.37 We believe that the bug you reported is fixed in the latest version of lintian, which is due to be installed in the Debian FTP archive: lintian_1.23.37.dsc to pool/main/l/lintian/lintian_1.23.37.dsc lintian_1.23.37.tar.gz to pool/main/l/lintian/lintian_1.23.37.tar.gz lintian_1.23.37_all.deb to pool/main/l/lintian/lintian_1.23.37_all.deb A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 454239@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Russ Allbery <rra@debian.org> (supplier of updated lintian package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmaster@debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.7 Date: Tue, 04 Dec 2007 16:43:13 -0800 Source: lintian Binary: lintian Architecture: source all Version: 1.23.37 Distribution: unstable Urgency: low Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org> Changed-By: Russ Allbery <rra@debian.org> Description: lintian - Debian package checker Closes: 119097 357838 409109 409138 437959 441636 444642 447257 447718 448207 448652 448677 449257 451668 451689 452316 452336 452804 452839 453302 453416 453417 453779 454239 Changes: lintian (1.23.37) unstable; urgency=low . The "Policy 3.7.3" release. . * checks/binaries: + [HE] Fix RegEx to re-enable 'binary-in-etc' and 'arch-dependent-file-in-usr-share' checks. (Closes: #452336) + [HE] When checking that a lib is linked against libc, search for libc.so, not any library beginning with libc. Thanks for the bug and patch to Ruben Porras <nahoo82@gmail.com>. (Closes: #448652) + [RA] Ignore the gf suffix from the gfortran migration when checking whether the package name matches the SONAME. Thanks, Kevin B. McCarty. (Closes: #448207) * checks/changelog-file{.desc,}: + [RA] Check that the latest changelog entry has a later version than the previous entry. Thanks, Thijs Kinkhorst. (Closes: #449257) * checks/common_data.pm: + [RA] Add Dm-Upload-Allowed as a control field. (Closes: #453779) * checks/control-file{.desc,}: + [RA] Diagnose stronger dependencies that imply weaker dependencies, such as the same dependency in both Depends and Recommends or Recommends and Suggests. Thanks, Joerg Jaspert. (Closes: #453302) + [RA] Upgrade no-section-field-for-source to warning at the request of Joerg Jaspert. * checks/control-files: + [RA] Add symbols as a known control file for debs and udebs. * checks/copyright-file: + [HE] Check that encoding of copyright file is UTF-8. Patch by gregor herrmann <gregor+debian@comodo.priv.at>. (Closes: #451689) + [HE] Add warning copyright-contains-dh_make-todo-boilerplate if the maintainer left the dh_make boilerplate in the copyright file. Based on patch by Cyril Brulebois <cyril.brulebois@enst-bretagne.fr>. (Closes: #448677) + [RA] Check for the complete GFDL included in the copyright file and expand copyright-file-contains-full-gpl-license to look for GPL v3 references. Also check for correct references to common-licenses for the GFDL and LGPL. * checks/deb-format: + [HE] Remove, not needed any more. (Closes: #447257) * checks/debconf: + [HE] Explicitly allow the phrase "no longer" in boolean debconf questions. (Closes: #447718) * checks/description.desc: + [RA] Upgrade the legacy Homepage tag to a warning. * checks/fields: + [HE] Add 'doc-package-should-be-section-doc', 'python-package-should-be-section-python', 'perl-package-should-be-section-perl'. Ideas shamelessy stolen from linda. (Closes: #452839) + [RA] Allow Python dependencies in Build-Depends when using another variant for calling Python in the clean target. Thanks, Bernd Zeimetz. (Closes: #444642) * checks/files{.desc,}: + [HE,RA] Add 'package-contains-empty-directory' check, but ignore dirs in /var and /etc and handle /usr/lib/perl5 and /usr/share/perl5 directories separately with a lower priority level since they're very common. (Closes: #452316, #357838) + [HE] Add checks for game packages that contain no game executables (package-section-games-but-contains-no-game) or that contain anything in usr/bin at all, which is usually a mistake. (package-section-games-but-contains-no-game). (Closes: #451668) + [RA] Downgrade symlink-should-be-relative to a warning since it's a Policy should. Thanks, Thijs Kinkhorst. (Closes: #454239) * checks/lintian.desc: + [RA] Add critical as a recognized urgency. * checks/patch-systems: + [HE] Add complete new check script, intended to check for usual problems when using patch systems. Start with three checks for common dpatch problems. Idea loosely based on patch by Carl Fürstenberg <azatoth@gmail.com>. (Closes: #437959) * checks/po-debconf.desc: + [RA] not-using-po-debconf is now an error per Policy section 3.9.1. * checks/rules: + [HE] Implement 'binary-arch-rules-but-pkg-is-arch-indep', checking for rules in binary-arch when the package is arch: all. (Closes: #409109, #119097) + [HE] Implement 'desktop-file-but-no-dh_desktop-call', checking for missing dh_desktop calls when .desktop files are installed in a debhelperized package. (Closes: #409138) * checks/scripts: + [HE] Allow packages to drop snippets into /etc/csh/login.d without a dependency on csh. Files there should also be allowed to have csh in the shebang line. (Closes: #453417) + [HE] Allow packages to drop snippets into /etc/fish.d/ without a dependecy on fish. (Closes: #453416) + [RA] Remove possible-non-posix-code-in-maintainer-script entirely. Debian Policy now allows local and test -a/-o specifically and this is pointless portability. * checks/standards-version: + [RA] 3.7.3 is now the current Standards-Version and anything older than 3.6.2 is ancient. . * debian/control: + [TK] Add Vcs-* fields to point to Lintian's repository. + [RA] Update standards version to 3.7.3. * debian/dirs: + [RA] Stop creating empty /usr/share/lintian/{overrides,info} directories. The latter is no longer used and the former is shipped with packages that include overrides. . * frontend/lintian: + [RA] Add critical as a recognized urgency. + [RA] Diagnose malformed override entries; don't just ignore them. + [RA] Fix some odd formatting. + [RA] Display a summary of overridden tags as an N: output line. Requested by Steve McIntyre. (Closes: #452804) . * man/lintian.1: + [RA] Be clearer about what files lintian takes as arguments; in particular, mention that source packages are checked by providing the .dsc file as an argument. (Closes: #441636) + [RA] Fix a slight spacing problem with the --color flag. + [RA] Remove mention of unused /usr/share/lintian/info directory. . * lib/DebVersions.pm: + [RA] Remove. This isn't used by anything and would produce incorrect results (it doesn't understand ~), and Dep.pm provides version comparison routines that use dpkg. * lib/Tags.pm: + [RA] Keep statistics on overrides by severity. . * reporting/html_reports: + [RA] Change the layout of the per-maintainer lintian pages. Now, each report will be in /reports/maintainer/<email>.html where <email> is the maintainer's e-mail address with unsafe characters replaced by _. This should allow better links from the QA pages. Thanks, Stefano Zacchiroli. . * unpack/list-srcpkg: + [RA] Escape ; and newline characters in all package fields before writing them to the index (uncovered when someone accidentally appended a package description to Standards-Version). Files: 6f28ee4ef7a8bd062059db5d75a8da48 904 devel optional lintian_1.23.37.dsc 651b32c29690a98831faa9deefe3c7c1 357269 devel optional lintian_1.23.37.tar.gz ec9bced3311d7ee38cf2804f25124244 301954 devel optional lintian_1.23.37_all.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFHVgIa+YXjQAr8dHYRArygAJ9M7+uv9gilsPtgIRQnijy4eeb2KgCgrJFS WYrlSQ+dTNMGLboKV2xeYj0= =/IjV -----END PGP SIGNATURE-----
--- End Message ---