lintian: r813 - in trunk: checks lib
Author: jaalto
Date: 2007-01-30 15:39:02 +0100 (Tue, 30 Jan 2007)
New Revision: 813
Modified:
trunk/checks/common_data.pm
trunk/lib/Checker.pm
trunk/lib/Lab.pm
trunk/lib/Tags.pm
Log:
* checks/common_data.pm
lib/Checker.pm
lib/Lab.pm
lib/Tags.pm
+ [JA] perl -Istrict -cw corrections.
Global symbol "@EXPORT" requires explicit package name at ./checks/common_data.pm line 5.
Name "main::LINTIAN_ROOT" used only once: possible typo at ./lib/Checker.pm line 30.
Name "main::verbose" used only once: possible typo at ./lib/Lab.pm line 34.
Name "main::LINTIAN_ROOT" used only once: possible typo at ./lib/Lab.pm line 30.
Name "main::debug" used only once: possible typo at ./lib/Lab.pm line 35.
Name "main::verbose" used only once: possible typo at ./lib/Tags.pm line 35.
Name "main::debug" used only once: possible typo at ./lib/Tags.pm line 36.
Modified: trunk/checks/common_data.pm
===================================================================
--- trunk/checks/common_data.pm 2007-01-30 14:36:47 UTC (rev 812)
+++ trunk/checks/common_data.pm 2007-01-30 14:39:02 UTC (rev 813)
@@ -2,16 +2,19 @@
package common_data;
use base qw(Exporter);
-@EXPORT=qw(%known_archs %known_sections %known_non_us_parts %known_archive_parts
- %known_prios %known_source_fields %known_binary_fields %known_udeb_fields
- %known_obsolete_fields %known_essential %known_build_essential
- %known_obsolete_packages %known_virtual_packages
- %known_libstdcs %known_tcls %known_tclxs %known_tks %known_tkxs
- %known_libpngs %known_x_metapackages
- %non_standard_archs %all_cpus %all_oses
- %known_doc_base_formats
- );
+our @EXPORT = qw
+(
+ %known_archs %known_sections %known_non_us_parts %known_archive_parts
+ %known_prios %known_source_fields %known_binary_fields %known_udeb_fields
+ %known_obsolete_fields %known_essential %known_build_essential
+ %known_obsolete_packages %known_virtual_packages
+ %known_libstdcs %known_tcls %known_tclxs %known_tks %known_tkxs
+ %known_libpngs %known_x_metapackages
+ %non_standard_archs %all_cpus %all_oses
+ %known_doc_base_formats
+);
+
# To let "perl -cw" test know we use these variables;
use vars qw
(
Modified: trunk/lib/Checker.pm
===================================================================
--- trunk/lib/Checker.pm 2007-01-30 14:36:47 UTC (rev 812)
+++ trunk/lib/Checker.pm 2007-01-30 14:39:02 UTC (rev 813)
@@ -27,7 +27,10 @@
use Tags;
use Cwd 'cwd';
-my $LINTIAN_ROOT = $::LINTIAN_ROOT;
+# Quiet "Name "main::LINTIAN_ROOT" used only once"
+# The variable comes from 'lintian'
+() = $main::LINTIAN_ROOT;
+my $LINTIAN_ROOT = $main::LINTIAN_ROOT;
# Can also be more precise later on (only verbose with checker actions) but for
# now this will do --Jeroen
Modified: trunk/lib/Lab.pm
===================================================================
--- trunk/lib/Lab.pm 2007-01-30 14:36:47 UTC (rev 812)
+++ trunk/lib/Lab.pm 2007-01-30 14:39:02 UTC (rev 813)
@@ -27,12 +27,16 @@
use File::Temp;
-my $LINTIAN_ROOT = $::LINTIAN_ROOT;
+# Quiet "Name "main::LINTIAN_ROOT" used only once"
+# The variables comes from 'lintian'
+() = ($main::LINTIAN_ROOT, $main::verbose, $main::debug);
+my $LINTIAN_ROOT = $main::LINTIAN_ROOT;
+
# Can also be more precise later on (only verbose with lab actions) but for
# now this will do --Jeroen
-my $verbose = $::verbose;
-my $debug = $::debug;
+my $verbose = $main::verbose;
+my $debug = $main::debug;
sub new {
my ( $class, $dir, $dist ) = @_;
Modified: trunk/lib/Tags.pm
===================================================================
--- trunk/lib/Tags.pm 2007-01-30 14:36:47 UTC (rev 812)
+++ trunk/lib/Tags.pm 2007-01-30 14:39:02 UTC (rev 813)
@@ -25,12 +25,16 @@
use warnings;
use Exporter;
-our @ISA = qw(Exporter);
+our @ISA = qw(Exporter);
our @EXPORT = qw(tag);
# support for ANSI color output via colored()
use Term::ANSIColor;
+# Quiet "Name "main::LINTIAN_ROOT" used only once"
+# The variables comes from 'lintian'
+() = ($main::verbose, $main::debug);
+
# configuration variables and defaults
our $verbose = $::verbose;
our $debug = $::debug;
Reply to: