Bug#456286: lintian: debian-revision-not-well-formed mentions old binNMU style
Package: lintian
Version: 1.23.41
Severity: minor
Tags: patch
Hi,
The description for debian-revision-not-well-formed says:
N: The debian version part (the part after the -) should consist of one
N: to three dot-separated parts: one for maintainer release, two for
N: source-NMU, three for binary NMU.
The part about the binNMU version numbers is outdated (Bug#437925
reported a similar issue for source-nmu-has-incorrect-version-number and
has already been fixed in 1.23.35). Since I don't know whether a newer
"+bx" style binNMU version numbering should be supported in this check,
here I provide a patch to just drop support for older "x.x.x" style
numbering from both the regular expression and the description.
Many thanks,
-nori
-- System Information:
Debian Release: 4.0
APT prefers stable
APT policy: (500, 'stable')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-5-686
Locale: LANG=ja_JP.eucJP, LC_CTYPE=ja_JP.eucJP (charmap=EUC-JP)
Versions of packages lintian depends on:
ii binutils 2.17-3 The GNU assembler, linker and bina
ii diffstat 1.43-2 produces graph of changes introduc
ii dpkg-dev 1.13.25 package building tools for Debian
ii file 4.17-5etch3 Determines file type using "magic"
ii gettext 0.16.1-1 GNU Internationalization utilities
ii intltool-debian 0.35.0+20060710.1 Help i18n of RFC822 compliant conf
ii libparse-debianchangel 1.0-1 parse Debian changelogs and output
ii man-db 2.4.3-6 The on-line manual pager
ii perl [libdigest-md5-pe 5.8.8-7etch1 Larry Wall's Practical Extraction
lintian recommends no packages.
-- no debconf information
Index: checks/fields
===================================================================
--- checks/fields (revision 1080)
+++ checks/fields (working copy)
@@ -156,7 +156,7 @@
if (defined $debian) {
tag "debian-revision-should-not-be-zero", "$version"
if $debian eq '0';
- $debian =~ /^-([^.]+)?(?:\.[^.]+)?(?:\.[^.]+)?(\..*)?$/;
+ $debian =~ /^-([^.]+)?(?:\.[^.]+)?(\..*)?$/;
if (not defined $1 or defined $2) {
tag "debian-revision-not-well-formed", "$version";
}
Index: checks/fields.desc
===================================================================
--- checks/fields.desc (revision 1080)
+++ checks/fields.desc (working copy)
@@ -41,9 +41,8 @@
Tag: debian-revision-not-well-formed
Type: warning
-Info: The debian version part (the part after the -) should consist of one to
- three dot-separated parts: one for maintainer release, two for source-NMU,
- three for binary NMU.
+Info: The debian version part (the part after the -) should consist of one or
+ two dot-separated parts: one for maintainer release, two for source-NMU.
Tag: debian-revision-should-not-be-zero
Type: warning
Reply to: