[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

lintian: r1056 - in trunk: checks debian testset testset/empty/debian



Author: rra
Date: 2007-12-07 05:26:32 +0100 (Fri, 07 Dec 2007)
New Revision: 1056

Modified:
   trunk/checks/fields
   trunk/checks/fields.desc
   trunk/debian/changelog
   trunk/testset/empty/debian/control
   trunk/testset/empty/debian/rules
   trunk/testset/tags.empty
   trunk/testset/tags.libbaz
Log:
* checks/fields:
  + [RA] Python documentation packages should still be in section doc.
    Thanks, Michal ?\196?\140iha?\197?\153.  (Closes: #454688)
  + [RA] Warn about lib.*-dev packages not in section libdevel.
  + [RA] Warn about debug packages that aren't priority: extra.  Thanks,
    Joerg Jaspert.  (Closes: #454358)


Modified: trunk/checks/fields
===================================================================
--- trunk/checks/fields	2007-12-07 02:40:25 UTC (rev 1055)
+++ trunk/checks/fields	2007-12-07 04:26:32 UTC (rev 1056)
@@ -297,7 +297,6 @@
 		tag "wrong-section-for-udeb", "$section";
 	    }
 	} else {
-
 	    my @parts = split /\//, $section, 2;
 
 	    if ($parts[0] =~ /non-US/i) {
@@ -314,15 +313,21 @@
 		tag "unknown-section", "$section" unless $known_sections{$parts[0]};
 	    }
 
-	    #Check package name <-> section
-	    if ($pkg =~ m{-docs?$} && $parts[-1] ne "doc") {
-		tag "doc-package-should-be-section-doc", $pkg;
-	    } elsif ($pkg =~ m{-perl$} && $parts[-1] ne "perl") {
-		tag "perl-package-should-be-section-perl", $pkg;
-	    } elsif ($pkg =~ m{^py} && $parts[-1] ne "python") {
-		tag "python-package-should-be-section-python", $pkg;
-	    }
-	}
+	    # Check package name <-> section.
+	    if ($pkg =~ /-docs?$/) {
+		tag "doc-package-should-be-section-doc", $pkg
+		    unless $parts[-1] eq 'doc';
+	    } elsif ($pkg =~ /-perl$/) {
+		tag "perl-package-should-be-section-perl", $pkg
+		    unless $parts[-1] eq 'perl';
+	    } elsif ($pkg =~ /^python-/) {
+		tag "python-package-should-be-section-python", $pkg
+		    unless $parts[-1] eq 'python';
+	    } elsif ($pkg =~ /^lib.*-dev$/) {
+                tag "dev-package-should-be-section-libdevel", $pkg
+                    unless $parts[-1] eq 'libdevel';
+            }
+        }
 }
 
 #---- Priority
@@ -336,6 +341,11 @@
 	unfold("priority", \$priority);
 
 	tag "unknown-priority", "$priority" if (! $known_prios{$priority});
+
+	if ($pkg =~ /-dbg$/) {
+		tag "debug-package-should-be-priority-extra", $pkg
+		    unless $priority eq 'extra';
+        }
 }
 
 #---- Standards-Version

Modified: trunk/checks/fields.desc
===================================================================
--- trunk/checks/fields.desc	2007-12-07 02:40:25 UTC (rev 1055)
+++ trunk/checks/fields.desc	2007-12-07 04:26:32 UTC (rev 1056)
@@ -671,15 +671,27 @@
 
 Tag: doc-package-should-be-section-doc
 Type: warning
-Info: This package has a name suggesting that it contains documentation,
- so it should be in section "doc".
+Info: This package has a name suggesting that it contains only
+ documentation.  If so, it should be in section "doc".
 
 Tag: python-package-should-be-section-python
 Type: warning
-Info: This package has a name suggesting that it is Python-based, so it
- should be in section "python".
+Info: This package has a name suggesting that it is a Python extension or
+ part of the Python environment.  If so, it should be in section
+ "python".
 
 Tag: perl-package-should-be-section-perl
 Type: warning
-Info: This package has a name suggest that it is Perl-based, so it should
- be in section "perl".
+Info: This package has a name suggesting that it is a Perl module package.
+ If so, it should be in section "perl".
+
+Tag: dev-package-should-be-section-libdevel
+Type: warning
+Info: This package has a name suggesting that it is a library development
+ package.  If so, it should be in section "libdevel".
+
+Tag: debug-package-should-be-priority-extra
+Type: warning
+Info: This package has a name suggesting that it contains detached
+ debugging symbols.  If so, it should have priority "extra" since users
+ normally do not need such packages.

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog	2007-12-07 02:40:25 UTC (rev 1055)
+++ trunk/debian/changelog	2007-12-07 04:26:32 UTC (rev 1056)
@@ -1,3 +1,14 @@
+lintian (1.23.39) UNRELEASED; urgency=low
+
+  * checks/fields:
+    + [RA] Python documentation packages should still be in section doc.
+      Thanks, Michal Čihař.  (Closes: #454688)
+    + [RA] Warn about lib.*-dev packages not in section libdevel.
+    + [RA] Warn about debug packages that aren't priority: extra.  Thanks,
+      Joerg Jaspert.  (Closes: #454358)
+
+ -- Russ Allbery <rra@debian.org>  Thu, 06 Dec 2007 20:24:55 -0800
+
 lintian (1.23.38) unstable; urgency=low
 
   * The "HE's brown paper bag bug" release

Modified: trunk/testset/empty/debian/control
===================================================================
--- trunk/testset/empty/debian/control	2007-12-07 02:40:25 UTC (rev 1055)
+++ trunk/testset/empty/debian/control	2007-12-07 04:26:32 UTC (rev 1056)
@@ -12,6 +12,6 @@
 Architecture: all
 Section: doc
 
-Package: pyempty
+Package: python-empty
 Architecture: all
 Section: doc

Modified: trunk/testset/empty/debian/rules
===================================================================
--- trunk/testset/empty/debian/rules	2007-12-07 02:40:25 UTC (rev 1055)
+++ trunk/testset/empty/debian/rules	2007-12-07 04:26:32 UTC (rev 1056)
@@ -30,13 +30,15 @@
 	install -d debian/empty-perl debian/empty-perl/DEBIAN
 	dpkg-gencontrol -pempty-perl -Pdebian/empty-perl
 	dpkg --build debian/empty-perl ..
-	install -d debian/pyempty debian/pyempty/DEBIAN
-	dpkg-gencontrol -ppyempty -Pdebian/pyempty
-	dpkg --build debian/pyempty ..
+	install -d debian/python-empty debian/python-empty/DEBIAN
+	dpkg-gencontrol -ppython-empty -Pdebian/python-empty
+	dpkg --build debian/python-empty ..
 
 binary: binary-indep
 
 clean:
-	rm -rf $(CURDIR)/debian/empty $(CURDIR)/debian/empty-docs $(CURDIR)/debian/empty-perl $(CURDIR)/debian/pyempty debian/files
+	rm -rf $(CURDIR)/debian/empty $(CURDIR)/debian/empty-docs \
+		$(CURDIR)/debian/empty-perl $(CURDIR)/debian/python-empty \
+		debian/files
 
 .PHONY: build binary-indep binary clean

Modified: trunk/testset/tags.empty
===================================================================
--- trunk/testset/tags.empty	2007-12-07 02:40:25 UTC (rev 1055)
+++ trunk/testset/tags.empty	2007-12-07 04:26:32 UTC (rev 1056)
@@ -11,9 +11,9 @@
 E: empty: no-copyright-file
 E: empty: package-has-no-description
 E: empty_2_i386.changes: no-description-in-changes-file
-E: pyempty: maintainer-address-missing empty
-E: pyempty: no-copyright-file
-E: pyempty: package-has-no-description
+E: python-empty: maintainer-address-missing empty
+E: python-empty: no-copyright-file
+E: python-empty: package-has-no-description
 W: empty source: changelog-should-mention-nmu
 W: empty source: maintainer-not-full-name empty
 W: empty source: no-section-field-for-source
@@ -27,6 +27,6 @@
 W: empty: maintainer-not-full-name empty
 W: empty: no-priority-field
 W: empty: no-section-field
-W: pyempty: maintainer-not-full-name empty
-W: pyempty: no-priority-field
-W: pyempty: python-package-should-be-section-python pyempty
+W: python-empty: maintainer-not-full-name empty
+W: python-empty: no-priority-field
+W: python-empty: python-package-should-be-section-python python-empty

Modified: trunk/testset/tags.libbaz
===================================================================
--- trunk/testset/tags.libbaz	2007-12-07 02:40:25 UTC (rev 1055)
+++ trunk/testset/tags.libbaz	2007-12-07 04:26:32 UTC (rev 1056)
@@ -25,6 +25,7 @@
 W: libbaz source: package-uses-deprecated-debhelper-compat-version 1
 W: libbaz source: source-nmu-has-incorrect-version-number 1
 W: libbaz source: substvar-source-version-is-deprecated libbaz2-dev
+W: libbaz1-dev: dev-package-should-be-section-libdevel libbaz1-dev
 W: libbaz1-dev: package-contains-empty-directory usr/include/
 W: libbaz1: missing-depends-line
 W: libbaz1: package-name-doesnt-match-sonames libbaz2-1.0 libbaz3-1
@@ -38,6 +39,7 @@
 W: libbaz1: unused-shlib-entry-in-control-file udeb: libdoesntexist2 1.0
 W: libbaz1: zero-byte-file-in-doc-directory usr/share/doc/README.Debian
 W: libbaz2-dev: changelog-file-not-compressed changelog
+W: libbaz2-dev: dev-package-should-be-section-libdevel libbaz2-dev
 W: libbaz2: debian-changelog-file-is-a-symlink
 W: libbaz2: package-name-doesnt-match-sonames libbaz2-1.0
 W: libbaz2: symlink-should-be-relative usr/share/doc/libbaz2/changelog.gz /usr/share/doc/lintian/changelog.gz



Reply to: