[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#448677: lintian: Please include copyright-contains-dh_make-todo-boilerplate



Package: lintian
Version: 1.23.36
Severity: wishlist
Tags: patch

Hi,

please find attached a patch to check whether one updated
debian/copyright after checking for additional license/copyrights.

I let that paragraph before reviewing, did the review, and forgot about
it, such a check would have spotted the problem.

I'm also wondering whether it would make sense to check debian/control
in source packages too. I'd expect such a behaviour, could you please
consider it?

(BTW, isn't lintian maintained in a public $VCS? Being able to
debcheckout it would be great. ;-))

Cheers,

-- 
Cyril Brulebois
diff --git a/checks/copyright-file b/checks/copyright-file
index 888b88b..89effa4 100644
--- a/checks/copyright-file
+++ b/checks/copyright-file
@@ -206,6 +206,10 @@ if (m,Upstream Author\(s\),) {
     tag "copyright-lists-upstream-authors-with-dh_make-boilerplate", "";
 }
 
+if (m/Please also look if/) {
+    tag "copyright-contains-dh_make-todo-boilerplate", "";
+}
+
 } # </run>
 
 # -----------------------------------
diff --git a/checks/copyright-file.desc b/checks/copyright-file.desc
index a6dd138..5504a19 100644
--- a/checks/copyright-file.desc
+++ b/checks/copyright-file.desc
@@ -147,3 +147,11 @@ Info: There is "Upstream Author(s)" in your copyright file. This was most
  remove the "(" and ")".
  .
  o/~ join us now and carefully edit debian/copyright files! o/~
+
+Tag: copyright-contains-dh_make-todo-boilerplate
+Type: error
+Ref: policy 12.5
+Info: The string "Please also look if..." appears in the copyright
+ file, which indicates that you either didn't check the whole source
+ to find additional copyright/license, or that you didn't remove that
+ paragraph after having done so.

Reply to: