[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

lintian: r980 - in trunk: checks debian testset testset/filenames/debian



Author: rra
Date: 2007-10-16 05:00:00 +0200 (Tue, 16 Oct 2007)
New Revision: 980

Modified:
   trunk/checks/files
   trunk/checks/files.desc
   trunk/debian/changelog
   trunk/testset/filenames/debian/rules
   trunk/testset/tags.filenames
Log:
* checks/files{.desc,}:
  + [RA] Catch .DS_Store.gz files as well.
  + [RA] Warn about ._ Mac OS X resource files in the package.
  + [RA] Add a hopefully helpful note about how cruft from other
    operating systems can show up in binary packages.

Modified: trunk/checks/files
===================================================================
--- trunk/checks/files	2007-10-15 21:38:51 UTC (rev 979)
+++ trunk/checks/files	2007-10-16 03:00:00 UTC (rev 980)
@@ -561,9 +561,12 @@
 	if ($file =~ m,/Thumbs\.db(\.gz)?$,i) {
 	    tag "windows-thumbnail-database-in-package", "$file";
 	}
-	if ($file =~ m,/\.DS_Store$,) {
+	if ($file =~ m,/\.DS_Store(\.gz)?$,) {
 	    tag "macos-ds-store-file-in-package", "$file";
 	}
+	if ($file =~ m,/\._[^_/][^/]*$, and $file !~ m/\.swp$/) {
+	    tag "macos-resource-fork-file-in-package", "$file";
+	}
 
 	# ---------------- general: setuid/setgid files!
 	if ($perm =~ m/s/) {

Modified: trunk/checks/files.desc
===================================================================
--- trunk/checks/files.desc	2007-10-15 21:38:51 UTC (rev 979)
+++ trunk/checks/files.desc	2007-10-16 03:00:00 UTC (rev 980)
@@ -414,14 +414,26 @@
 Type: warning
 Info: There is a file in the package named <tt>Thumbs.db</tt> or
  <tt>Thumbs.db.gz</tt>, which is normally a Windows image thumbnail
- database.  Such databases are generally useless in Debian packages.
+ database.  Such databases are generally useless in Debian packages and
+ were usually accidentally included by copying complete directories from
+ the source tarball.
 
 Tag: macos-ds-store-file-in-package
 Type: warning
-Info: There is a file in the package named <tt>.DS_Store</tt>, the file
- name used by Mac OS X to store folder attributes.  Such files are
- generally useless in Debian packages.
+Info: There is a file in the package named <tt>.DS_Store</tt> or
+ <tt>.DS_Store.gz</tt>, the file name used by Mac OS X to store folder
+ attributes.  Such files are generally useless in Debian packages and were
+ usually accidentally included by copying complete directories from the
+ source tarball.
 
+Tag: macos-resource-fork-file-in-package
+Type: warning
+Info: There is a file in the package with a name starting with
+ <tt>._</tt>, the file name pattern used by Mac OS X to store resource
+ forks in non-native file systems.  Such files are generally useless in
+ Debian packages and were usually accidentally included by copying
+ complete directories from the source tarball.
+
 Tag: package-installs-perllocal-pod
 Type: warning
 Info: This package installs a file <tt>perllocal.pod</tt>.  Since that

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog	2007-10-15 21:38:51 UTC (rev 979)
+++ trunk/debian/changelog	2007-10-16 03:00:00 UTC (rev 980)
@@ -1,10 +1,15 @@
 lintian (1.23.36) UNRELEASED; urgency=low
 
+  * checks/files{.desc,}:
+    + [RA] Catch .DS_Store.gz files as well.
+    + [RA] Warn about ._ Mac OS X resource files in the package.
+    + [RA] Add a hopefully helpful note about how cruft from other
+      operating systems can show up in binary packages.
   * checks/menu-format:
     + [RA] Fix detection of commands for menu entries when the command is
       given with its full path.  (Closes: #446796)
 
- -- Russ Allbery <rra@debian.org>  Mon, 15 Oct 2007 14:38:45 -0700
+ -- Russ Allbery <rra@debian.org>  Mon, 15 Oct 2007 19:58:18 -0700
 
 lintian (1.23.35) unstable; urgency=low
 

Modified: trunk/testset/filenames/debian/rules
===================================================================
--- trunk/testset/filenames/debian/rules	2007-10-15 21:38:51 UTC (rev 979)
+++ trunk/testset/filenames/debian/rules	2007-10-16 03:00:00 UTC (rev 980)
@@ -82,6 +82,7 @@
 
 	echo foo > debian/tmp/usr/share/doc/filenames/Thumbs.db
 	echo foo > debian/tmp/usr/share/doc/filenames/.DS_Store
+	echo foo > debian/tmp/usr/share/doc/filenames/._NEWS.Debian
 
 	touch debian/tmp/usr/share/doc/filenames/news.debian
 	gzip debian/tmp/usr/share/doc/filenames/news.debian

Modified: trunk/testset/tags.filenames
===================================================================
--- trunk/testset/tags.filenames	2007-10-15 21:38:51 UTC (rev 979)
+++ trunk/testset/tags.filenames	2007-10-16 03:00:00 UTC (rev 980)
@@ -67,6 +67,7 @@
 W: filenames: file-in-usr-lib-sgml usr/lib/sgml/package
 W: filenames: file-name-ends-in-whitespace files/'\\ 
 W: filenames: macos-ds-store-file-in-package usr/share/doc/filenames/.DS_Store
+W: filenames: macos-resource-fork-file-in-package usr/share/doc/filenames/._NEWS.Debian
 W: filenames: menu-file-in-usr-lib usr/lib/menu/menu
 W: filenames: no-priority-field
 W: filenames: no-section-field



Reply to: