lintian: r956 - in trunk: checks debian testset testset/filenames/debian
Author: rra
Date: 2007-10-15 02:52:01 +0200 (Mon, 15 Oct 2007)
New Revision: 956
Modified:
trunk/checks/files
trunk/checks/files.desc
trunk/debian/changelog
trunk/testset/filenames/debian/rules
trunk/testset/tags.filenames
Log:
* checks/files{.desc,}:
+ [RA] Warn about Thumbs.db files, which are usually useless Windows
thumbnail databases. Thanks, Paul Wise. (Closes: #438202)
Modified: trunk/checks/files
===================================================================
--- trunk/checks/files 2007-10-15 00:34:32 UTC (rev 955)
+++ trunk/checks/files 2007-10-15 00:52:01 UTC (rev 956)
@@ -179,12 +179,12 @@
if ($owner ne 'root/root') {
tag "bad-owner-for-doc-file", "$file $owner != root/root";
}
-
+
# file directly in /usr/share/doc ?
if ($perm =~ m/^-/ and $file =~ m,^usr/share/doc/[^/]+$,) {
tag "file-directly-in-usr-share-doc", "$file";
}
-
+
# executable in /usr/share/doc ?
if ($perm =~ m/^-.*[xs]/ and $file !~ m,^usr/share/doc/([^/]+/)?examples/,) {
if ($script{$file}) {
@@ -193,7 +193,7 @@
tag "executable-in-usr-share-doc", $file, (sprintf "%04o", $operm);
}
}
-
+
# zero byte file in /usr/share/doc/
if ($size == 0 and $perm =~ m,^-,) {
# exception: __init__.py files are empty tagging files (see
@@ -217,7 +217,7 @@
} elsif ($file =~ m,^usr/share/lintian/overrides/$tmp/.*,) {
tag "override-file-in-wrong-location", "$file";
}
-
+
# contains an INSTALL file?
if ($file =~ m,^usr/share/doc/$tmp/INSTALL(?:\..+)*$,) {
tag "package-contains-upstream-install-documentation", "$file";
@@ -372,7 +372,7 @@
elsif ($file =~ m,/usr/share/(?:gnome/apps|applink)/[^/]+\.desktop$,) {
tag "desktop-file-in-wrong-dir", $file;
}
-
+
}
# ---------------- /var subdirs
elsif ($type ne 'udeb' and $file =~ m,^var/[^/]+/$,) { # FSSTND dirs
@@ -551,6 +551,11 @@
tag "script-with-language-extension", "$file";
}
+ # ---------------- Windows thumbnail databases
+ if ($file =~ m,/Thumbs\.db(\.gz)?$,) {
+ tag "windows-thumbnail-database-in-package", "$file";
+ }
+
# ---------------- general: setuid/setgid files!
if ($perm =~ m/s/) {
my ($setuid, $setgid) = ("","");
Modified: trunk/checks/files.desc
===================================================================
--- trunk/checks/files.desc 2007-10-15 00:34:32 UTC (rev 955)
+++ trunk/checks/files.desc 2007-10-15 00:52:01 UTC (rev 956)
@@ -410,6 +410,12 @@
had them open. It may have been included in the package by accident
while building the package in an NFS filesystem.
+Tag: windows-thumbnail-database-in-package
+Type: warning
+Info: There is a file in the package named <tt>Thumbs.db</tt> or
+ <tt>Thumbs.db.gz</tt>, which is normally a Windows image thumbnail
+ database. Such databases are generally useless in Debian packages.
+
Tag: package-installs-perllocal-pod
Type: warning
Info: This package installs a file <tt>perllocal.pod</tt>. Since that
Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog 2007-10-15 00:34:32 UTC (rev 955)
+++ trunk/debian/changelog 2007-10-15 00:52:01 UTC (rev 956)
@@ -12,6 +12,9 @@
* checks/description{.desc,}:
+ [RA] Warn (at info level for now) about Homepage pseudo-fields in
the extended description. (Closes: #444336)
+ * checks/files{.desc,}:
+ + [RA] Warn about Thumbs.db files, which are usually useless Windows
+ thumbnail databases. Thanks, Paul Wise. (Closes: #438202)
* checks/nmu.desc:
+ [RA] Remove obsolete note about binary NMUs. Patch from Thijs
Kinkhorst. (Closes: #437925)
@@ -19,7 +22,7 @@
* collection/changelog-file{.desc,}:
+ [RA] Collect NEWS.Debian as well as changelog.
- -- Russ Allbery <rra@debian.org> Sun, 14 Oct 2007 17:34:23 -0700
+ -- Russ Allbery <rra@debian.org> Sun, 14 Oct 2007 17:47:43 -0700
lintian (1.23.34) unstable; urgency=low
Modified: trunk/testset/filenames/debian/rules
===================================================================
--- trunk/testset/filenames/debian/rules 2007-10-15 00:34:32 UTC (rev 955)
+++ trunk/testset/filenames/debian/rules 2007-10-15 00:52:01 UTC (rev 956)
@@ -80,6 +80,8 @@
echo foo > debian/tmp/usr/share/doc/filenames/bokm\\� echo foo > debian/tmp/usr/share/doc/filenames/bokm\\\\�
+ echo foo > debian/tmp/usr/share/doc/filenames/Thumbs.db
+
touch debian/tmp/usr/share/doc/filenames/news.debian
gzip debian/tmp/usr/share/doc/filenames/news.debian
touch debian/tmp/usr/share/doc/filenames/NEWS.Debian
Modified: trunk/testset/tags.filenames
===================================================================
--- trunk/testset/tags.filenames 2007-10-15 00:34:32 UTC (rev 955)
+++ trunk/testset/tags.filenames 2007-10-15 00:52:01 UTC (rev 956)
@@ -84,6 +84,7 @@
W: filenames: symlink-is-self-recursive usr/lib/filenames/symlink5ok+warn ..
W: filenames: symlink-is-self-recursive usr/lib/filenames/symlink6ok+warn .
W: filenames: symlink-is-self-recursive usr/lib/filenames/symlink7ok+warn /
+W: filenames: windows-thumbnail-database-in-package usr/share/doc/filenames/Thumbs.db
W: filenames: wrong-name-for-debian-news-file usr/share/doc/filenames/news.debian.gz
W: filenames: zero-byte-file-in-doc-directory usr/share/doc/filenames/NEWS.Debian
W: filenames: zero-byte-file-in-doc-directory usr/share/doc/filenames/README.macosx
Reply to: