[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

lintian: r894 - in trunk: checks debian testset



Author: rra
Date: 2007-06-04 06:00:59 +0200 (Mon, 04 Jun 2007)
New Revision: 894

Modified:
   trunk/checks/changelog-file
   trunk/debian/changelog
   trunk/testset/tags.diffs
Log:
* checks/changelog-file:
  + [RA] Only check for missing colons in bug closers in the most recent
    changelog entry.  Thanks, Thijs Kinkhorst.  (Closes: #423171)

Modified: trunk/checks/changelog-file
===================================================================
--- trunk/checks/changelog-file	2007-06-04 03:45:17 UTC (rev 893)
+++ trunk/checks/changelog-file	2007-06-04 04:00:59 UTC (rev 894)
@@ -262,6 +262,13 @@
     }
 }
 
+# Some checks should only be done against the most recent changelog entry.
+if (@entries) {
+    my $entry = $entries[0]->Changes;
+    while ($entry =~ /(closes\s*(?:bug)?\#?\s?\d{6,})[^\w]/ig) {
+	tag "possible-missing-colon-in-closes", "$1" if $1;
+    }
+}
 
 # read the changelog itself
 #
@@ -280,10 +287,6 @@
 	tag "wrong-bug-number-in-closes", "l$.:$1" if $2;
     }
 
-    if (/(closes\s*(?:bug)?\#?\s?\d{6,})[^\w]/i) {
-	tag "possible-missing-colon-in-closes", "l$.:$1" if $1;
-    }
-
     if (/^(.*)Local\ variables:(.*)$/i) {
 	$prefix = $1;
 	$suffix = $2;

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog	2007-06-04 03:45:17 UTC (rev 893)
+++ trunk/debian/changelog	2007-06-04 04:00:59 UTC (rev 894)
@@ -1,5 +1,8 @@
 lintian (1.23.31) UNRELEASED; urgency=low
 
+  * checks/changelog-file:
+    + [RA] Only check for missing colons in bug closers in the most recent
+      changelog entry.  Thanks, Thijs Kinkhorst.  (Closes: #423171)
   * checks/common_data.pm:
     + [RA] Update architectures to dpkg 1.14.1.  Remove all linux-*
       architectures and add armel.  (Closes: #421995)
@@ -41,7 +44,7 @@
   * frontend/lintian-info:
     + [CW] Fix uninitialized value warning after reading a blank line.
 
- -- Russ Allbery <rra@debian.org>  Sun, 03 Jun 2007 20:45:13 -0700
+ -- Russ Allbery <rra@debian.org>  Sun, 03 Jun 2007 20:59:12 -0700
 
 lintian (1.23.30) unstable; urgency=low
 

Modified: trunk/testset/tags.diffs
===================================================================
--- trunk/testset/tags.diffs	2007-06-04 03:45:17 UTC (rev 893)
+++ trunk/testset/tags.diffs	2007-06-04 04:00:59 UTC (rev 894)
@@ -16,9 +16,9 @@
 W: diffs source: diff-contains-substvars debian/substvars
 W: diffs source: out-of-date-standards-version 3.5.9 (current is 3.7.2)
 W: diffs: binary-without-manpage usr/bin/diffs
-W: diffs: possible-missing-colon-in-closes l11:Closes 456712
-W: diffs: possible-missing-colon-in-closes l12:Closes Bug# 123893
-W: diffs: possible-missing-colon-in-closes l13:Closes #1239124
+W: diffs: possible-missing-colon-in-closes Closes #1239124
+W: diffs: possible-missing-colon-in-closes Closes 456712
+W: diffs: possible-missing-colon-in-closes Closes Bug# 123893
 W: diffs: wrong-bug-number-in-closes l6:#nnnnnn
 W: diffs: wrong-bug-number-in-closes l7:#123nnn
 W: diffs: wrong-bug-number-in-closes l8:#foo



Reply to: