[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#296285: marked as done ([reporting/html_reports] don't show removed packages on the webpages)

Your message dated Sat, 28 Apr 2007 15:30:09 -0700
with message-id <87fy6k874e.fsf@windlord.stanford.edu>
and subject line Bug#296285: [reporting/html_reports] don't show removed packages on the webpages
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message --- 
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Package: lintian
Severity: wishlist
Tags: patch

If one uses the incremental mode to create lintian reports, removed
packages keep showing up on the html pages.

I think this can be solved by the attached patch, though I didn't test it.

Cheers

Luk
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQFCGfGl5UTeB5t8Mo0RAh7hAKCdIsxSJrgta7c/+npWBz3v/kpxUQCfU+mV
gKFEI/JMwGeokEIPcBljxp0=
=ZQMc
-----END PGP SIGNATURE-----

diff -Nru lintian/lintian-1.23.8/reporting/html_reports lintian-1.23.8/reporting/html_reports
--- lintian/lintian-1.23.8/reporting/html_reports	2004-07-04 19:35:13.000000000 +0200
+++ lintian-1.23.8/reporting/html_reports	2005-02-21 15:33:55.259381872 +0100
@@ -101,12 +101,13 @@
 	$src = $pkg;
 	unless (exists $source_info{$pkg}) {
 	    print STDERR "error: source package $pkg not listed!\n";
+	    next;
 	}
     } else {
 	$src = $bin_src_ref{$pkg};
 	unless ($src) {
 	    print STDERR "error: source for package $pkg not found!\n";
-	    $src = $pkg;
+	    next; #$src = $pkg;
 	}
     }

--- End Message ---
--- Begin Message --- 
> Package: lintian
> Severity: wishlist
> Tags: patch

> If one uses the incremental mode to create lintian reports, removed
> packages keep showing up on the html pages.

I'm not sure why you were seeing this behavior at the time, but it doesn't
seem to be happening right now on lintian.debian.org.  I've checked the
latest source package removals done by ftp-master, and those packages seem
to have been correctly dropped.

I'm therefore going to close this bug, but please do reopen it with an
example if you see this problem recur.

What happens behind the scenes is that the harness script removes any
removed packages from the lintian.log file before the html_reports script
runs, and then the html_reports script generates a completely new set of
HTML pages based on the lintian.log from the previous run.  So if there
were a bug here, it wouldn't be in the html_reports script, but rather in
the harness which wouldn't have been properly removing old packages.  I
looked over the code, though, and it seems to be doing what it should be
doing.

> --- lintian/lintian-1.23.8/reporting/html_reports	2004-07-04 19:35:13.000000000 +0200
> +++ lintian-1.23.8/reporting/html_reports	2005-02-21 15:33:55.259381872 +0100
> @@ -101,12 +101,13 @@
>  	$src = $pkg;
>  	unless (exists $source_info{$pkg}) {
>  	    print STDERR "error: source package $pkg not listed!\n";
> +	    next;
>  	}
>      } else {
>  	$src = $bin_src_ref{$pkg};
>  	unless ($src) {
>  	    print STDERR "error: source for package $pkg not found!\n";
> -	    $src = $pkg;
> +	    next; #$src = $pkg;
>  	}
>      }
 
This code is handling something different.  The first block should never
happen and a next there may be appropriate, since it indicates
html_reports found a source package in the lintian.log file that wasn't
listed in the source package list.  The second block, however, deals with
the legitimate case of a binary package for which there is no source
package.  ftp-master will remove these on a semi-automated basis, but
until they're removed, they're still in Packages and hence are still part
of the archive.

-- 
Russ Allbery (rra@debian.org)               <http://www.eyrie.org/~eagle/>

--- End Message ---
Reply to: