lintian: r861 - in trunk: checks debian testset testset/scripts testset/scripts/debian
Author: rra
Date: 2007-04-27 04:05:53 +0200 (Fri, 27 Apr 2007)
New Revision: 861
Added:
trunk/testset/scripts/envfoo
Modified:
trunk/checks/scripts
trunk/checks/scripts.desc
trunk/debian/changelog
trunk/testset/scripts/debian/rules
trunk/testset/tags.scripts
Log:
+ [RA] Add pike7.6 and ruby1.9 as valid interpreters.
+ [RA] Diagnose use of /bin/env with a more specific message than the
generic unusual interpreter tag.
Modified: trunk/checks/scripts
===================================================================
--- trunk/checks/scripts 2007-04-25 20:22:19 UTC (rev 860)
+++ trunk/checks/scripts 2007-04-27 02:05:53 UTC (rev 861)
@@ -75,6 +75,7 @@
'php5' => '/usr/bin/php5',
'pike' => '/usr/bin/pike',
'pike7' => '/usr/bin/pike7',
+ 'pike7.6' => '/usr/bin/pike7.6',
'python' => '/usr/bin/python',
'python1.5' => '/usr/bin/python1.5',
'python2.1' => '/usr/bin/python2.1',
@@ -91,6 +92,7 @@
'ruby' => '/usr/bin/ruby',
'ruby1.6' => '/usr/bin/ruby1.6',
'ruby1.8' => '/usr/bin/ruby1.8',
+ 'ruby1.9' => '/usr/bin/ruby1.9',
'scsh' => '/usr/bin/scsh',
'sed' => '/bin/sed',
'sh' => '/bin/sh',
@@ -148,6 +150,7 @@
'php5' => 'php5-cli',
'pike' => 'pike',
'pike7' => 'pike7',
+ 'pike7.6' => 'pike7.6',
'rc' => 'rc',
'regina' => 'regina-rexx',
'rexx' => 'regina-rexx',
@@ -340,6 +343,8 @@
# Don't emit any tag for this.
} elsif ($base eq 'suidperl') {
tag_error("calls-suidperl-directly", $filename);
+ } elsif ($interpreter eq '/bin/env') {
+ tag_warn("script-uses-bin-env", $filename);
} else {
tag_warn("unusual-interpreter", $filename, "#!$interpreter");
}
Modified: trunk/checks/scripts.desc
===================================================================
--- trunk/checks/scripts.desc 2007-04-25 20:22:19 UTC (rev 860)
+++ trunk/checks/scripts.desc 2007-04-27 02:05:53 UTC (rev 861)
@@ -37,6 +37,13 @@
interpreter. If not, please file a wishlist bug on lintian so that the
Lintian maintainers can add this interpreter to their list.
+Tag: script-uses-bin-env
+Type: warning
+Info: This script uses /bin/env as its interpreter (used to find the
+ actual interpreter on the user's path). There is no /bin/env on Debian
+ systems; env is instead installed as /usr/bin/env. Usually, the path to
+ env in the script should be changed.
+
Tag: forbidden-config-interpreter
Type: error
Info: This package contains a 'config' script for pre-configuring the package,
Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog 2007-04-25 20:22:19 UTC (rev 860)
+++ trunk/debian/changelog 2007-04-27 02:05:53 UTC (rev 861)
@@ -40,8 +40,11 @@
that include /usr/share/debconf/confmodule on the grounds that
they're probably only using it as a fallback). Based on a patch by
Luk Claes. (Closes: #231770)
+ + [RA] Add pike7.6 and ruby1.9 as valid interpreters.
+ + [RA] Diagnose use of /bin/env with a more specific message than the
+ generic unusual interpreter tag.
- -- Russ Allbery <rra@debian.org> Wed, 25 Apr 2007 13:22:11 -0700
+ -- Russ Allbery <rra@debian.org> Thu, 26 Apr 2007 19:05:43 -0700
lintian (1.23.29) unstable; urgency=low
Modified: trunk/testset/scripts/debian/rules
===================================================================
--- trunk/testset/scripts/debian/rules 2007-04-25 20:22:19 UTC (rev 860)
+++ trunk/testset/scripts/debian/rules 2007-04-27 02:05:53 UTC (rev 861)
@@ -17,6 +17,7 @@
install -d $(tmp)/usr/src/scripts
install -d $(tmp)/DEBIAN
+ install -m 755 envfoo $(tmp)/usr/bin/
install -m 755 pyfoo $(tmp)/usr/bin/
install -m 755 py2foo $(tmp)/usr/bin/
install -m 755 perlfoo $(tmp)/usr/bin/
Added: trunk/testset/scripts/envfoo
===================================================================
--- trunk/testset/scripts/envfoo 2007-04-25 20:22:19 UTC (rev 860)
+++ trunk/testset/scripts/envfoo 2007-04-27 02:05:53 UTC (rev 861)
@@ -0,0 +1,4 @@
+#! /bin/env python
+
+if __name__ == '__main__':
+ print 'Hi there'
Property changes on: trunk/testset/scripts/envfoo
___________________________________________________________________
Name: svn:executable
+ *
Modified: trunk/testset/tags.scripts
===================================================================
--- trunk/testset/tags.scripts 2007-04-25 20:22:19 UTC (rev 860)
+++ trunk/testset/tags.scripts 2007-04-27 02:05:53 UTC (rev 861)
@@ -23,6 +23,7 @@
W: scripts source: package-uses-deprecated-debhelper-compat-version 1
W: scripts source: source-nmu-has-incorrect-version-number 6
W: scripts source: uses-dh-python-with-no-pycompat
+W: scripts: binary-without-manpage usr/bin/envfoo
W: scripts: binary-without-manpage usr/bin/lefty-foo
W: scripts: binary-without-manpage usr/bin/make-foo
W: scripts: binary-without-manpage usr/bin/perl-bizarre-1
@@ -51,6 +52,7 @@
W: scripts: non-standard-executable-perm usr/bin/perl-bizarre-3 0754 != 0755
W: scripts: non-standard-setuid-executable-perm usr/bin/suidperlfoo 4555
W: scripts: package-installs-python-pyc usr/lib/python2.3/site-packages/test.pyc
+W: scripts: script-uses-bin-env ./usr/bin/envfoo
W: scripts: script-with-language-extension usr/bin/test.sh
W: scripts: setuid-binary usr/bin/suidperlfoo 4555 root/root
W: scripts: setuid-binary usr/bin/suidperlfoo2 4751 root/root
Reply to: