[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

lintian: r852 - in trunk: checks debian testset testset/libbaz/debian



Author: rra
Date: 2007-04-23 01:14:59 +0200 (Mon, 23 Apr 2007)
New Revision: 852

Modified:
   trunk/checks/rules
   trunk/debian/changelog
   trunk/testset/libbaz/debian/rules
   trunk/testset/tags.libbaz
Log:
* checks/rules:
  + [RA] Listing a rule as a dependency of .PHONY is sufficient to mark
    it as present for GNU make and hence sufficient for Policy's
    requirement.  Thanks, Peter Eisentraut.  (Closes: #419446)

Modified: trunk/checks/rules
===================================================================
--- trunk/checks/rules	2007-04-22 23:00:39 UTC (rev 851)
+++ trunk/checks/rules	2007-04-22 23:14:59 UTC (rev 852)
@@ -70,6 +70,16 @@
         tag "debian-rules-uses-pwd", "line $.";
     }
 
+    # Listing a rule as a dependency of .PHONY is sufficient to make it
+    # present for the purposes of GNU make and therefore the Policy
+    # requirement.
+    if (/^(?:[^:]+\s)?\.PHONY(?:\s[^:]+)?:(.+)/) {
+        my @targets = split (' ', $1);
+        for (@targets) {
+            $seen{$_}++ if $required{$_};
+        }
+    }
+
     # After this point, we're only doing target analysis, so skip everything
     # else.
     next unless /^([^:]+):/;

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog	2007-04-22 23:00:39 UTC (rev 851)
+++ trunk/debian/changelog	2007-04-22 23:14:59 UTC (rev 852)
@@ -12,8 +12,12 @@
     + [RA] Don't warn about a missing md5sums file if the package contains
       nothing for which we would generate an MD5 checksum.  Thanks,
       Andreas Beckmann.  (Closes: #420465)
+  * checks/rules:
+    + [RA] Listing a rule as a dependency of .PHONY is sufficient to mark
+      it as present for GNU make and hence sufficient for Policy's
+      requirement.  Thanks, Peter Eisentraut.  (Closes: #419446)
 
- -- Russ Allbery <rra@debian.org>  Sun, 22 Apr 2007 16:00:33 -0700
+ -- Russ Allbery <rra@debian.org>  Sun, 22 Apr 2007 16:14:31 -0700
 
 lintian (1.23.29) unstable; urgency=low
 

Modified: trunk/testset/libbaz/debian/rules
===================================================================
--- trunk/testset/libbaz/debian/rules	2007-04-22 23:00:39 UTC (rev 851)
+++ trunk/testset/libbaz/debian/rules	2007-04-22 23:14:59 UTC (rev 852)
@@ -98,4 +98,6 @@
 
 binary: binary-arch
 
-.PHONY: build binary-arch binary clean
+# The mention of binary-indep here should be sufficient to suppress the
+# warning that it's not present.
+.PHONY: build binary-arch binary-indep binary clean

Modified: trunk/testset/tags.libbaz
===================================================================
--- trunk/testset/tags.libbaz	2007-04-22 23:00:39 UTC (rev 851)
+++ trunk/testset/tags.libbaz	2007-04-22 23:14:59 UTC (rev 852)
@@ -1,4 +1,3 @@
-E: libbaz source: debian-rules-missing-required-target binary-indep
 E: libbaz source: not-binnmuable-any-depends-any libbaz1-dev -> libbaz1
 E: libbaz1: control-file-has-bad-permissions shlibs 0755 != 0644
 E: libbaz1: duplicate-entry-in-shlibs-control-file libdoesntexist2 1.0



Reply to: