[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#419461: [checks/scripts] Add maintainer-script-needs-depends-on-xml-core check



Am Sonntag, den 15.04.2007, 21:59 +0200 schrieb Daniel Leidert:

> I would like to request a template
> maintainer-script-needs-depends-on-xml-core to check for an xml-core
> dependency if the maintainer-script calls update-xmlcatalog. Missing
> this dependency appeared several times (probably only for me :)), so I
> would like to request this check. To add it, simply add a
> 
>   [ 'xml-core'             => '\bupdate-xmlcatalog\b' ],
> 
> to @depends_needed in /usr/share/lintian/checks/scripts and
> 
>   Tag: maintainer-script-needs-depends-on-xml-core
>   Type: error
>   Info: This script calls update-xmlcatalog, which comes from the xml-core
>    package, but does not depend or pre-depend on xml-core.  Packages that call
>    update-xmlcatalog need to depend on xml-core.  If you are using
>    dh_installxmlcatalogs, add a dependency on ${misc:Depends} and
>    dh_installxmlcatalogs will take care of this for you.
> 
> to /usr/share/lintian/checks/scripts.desc.

I found one issue with my suggestion: xml-core itself provides
update-xmlcatalog and also installs catalogs using this tool. But of
course cannot depend on itself. But the suggested check would make this
necessary to avoid an error :) Maybe the check should contain an

unless (($pkg eq $package) || ...

at the start too, to make sure, we don't try to check for a dependency
on ourselves.

Regards, Daniel




Reply to: