lintian: r842 - in trunk: checks debian testset
Author: rra
Date: 2007-04-11 04:59:33 +0200 (Wed, 11 Apr 2007)
New Revision: 842
Modified:
trunk/checks/rules
trunk/checks/rules.desc
trunk/debian/changelog
trunk/testset/tags.debconf
trunk/testset/tags.debug
trunk/testset/tags.dh-test
Log:
+ [RA] Setting DH_COMPAT globally in debian/rules is now deprecated in
favor of debian/compat. Patch from Luk Claes. (Closes: #330025)
Modified: trunk/checks/rules
===================================================================
--- trunk/checks/rules 2007-04-11 02:30:00 UTC (rev 841)
+++ trunk/checks/rules 2007-04-11 02:59:33 UTC (rev 842)
@@ -58,6 +58,13 @@
next if /^\s*\#/;
$includes = 1 if /^ *[s-]?include\s+/;
+ # Check for DH_COMPAT settings outside of any rule, which are now
+ # deprecated. It's a bit easier structurally to do this here than in
+ # debhelper.
+ if (/^\s*(export\s+)?DH_COMPAT\s*:?=/ && keys(%seen) == 0) {
+ tag "debian-rules-sets-DH_COMPAT", "line $.";
+ }
+
# Check for problems that can occur anywhere in debian/rules.
if (/\$[\(\{]PWD[\)\}]/) {
tag "debian-rules-uses-pwd", "line $.";
Modified: trunk/checks/rules.desc
===================================================================
--- trunk/checks/rules.desc 2007-04-11 02:30:00 UTC (rev 841)
+++ trunk/checks/rules.desc 2007-04-11 02:59:33 UTC (rev 842)
@@ -45,3 +45,11 @@
.
Instead of $(PWD), use $(CURDIR), which is set by GNU make, ignores the
environment, and is guaranteed to always be set.
+
+Tag: debian-rules-sets-DH_COMPAT
+Type: warning
+Ref: debhelper(7)
+Info: As of debhelper version 4, the DH_COMPAT environment variable is
+ only to be used for temporarily overriding <tt>debian/compat</tt>. Any
+ line in <tt>debian/rules</tt> that sets it globally should be deleted and
+ a separate <tt>debian/compat</tt> file created if needed.
Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog 2007-04-11 02:30:00 UTC (rev 841)
+++ trunk/debian/changelog 2007-04-11 02:59:33 UTC (rev 842)
@@ -79,6 +79,8 @@
and debian-rules-not-a-makefile. Thanks, Daniel Kahn Gillmor.
(Closes: #414964)
+ [RA] Warn about use of $(PWD) instead of $(CURDIR).
+ + [RA] Setting DH_COMPAT globally in debian/rules is now deprecated in
+ favor of debian/compat. Patch from Luk Claes. (Closes: #330025)
* checks/scripts{.desc,}:
+ [RA] update-inetd is now its own package and netbase may not always
depend on it. Update the check to require a dependency on
Modified: trunk/testset/tags.debconf
===================================================================
--- trunk/testset/tags.debconf 2007-04-11 02:30:00 UTC (rev 841)
+++ trunk/testset/tags.debconf 2007-04-11 02:59:33 UTC (rev 842)
@@ -9,6 +9,7 @@
E: debconf-test: unknown-debconf-priority config:10 LOW
E: debconf-test: unknown-debconf-priority config:11 normal
E: debconf-udeb udeb: udeb-postinst-must-not-call-ldconfig
+W: debconf source: debian-rules-sets-DH_COMPAT line 3
W: debconf source: invalid-po-file debian/po/fr.po
W: debconf source: invalid-po-file debian/po/sample-file.po
W: debconf source: maintainer-script-lacks-debhelper-token debian/debconf-test.postinst
Modified: trunk/testset/tags.debug
===================================================================
--- trunk/testset/tags.debug 2007-04-11 02:30:00 UTC (rev 841)
+++ trunk/testset/tags.debug 2007-04-11 02:59:33 UTC (rev 842)
@@ -7,6 +7,7 @@
I: debug source: non-standard-architecture kfreebsd-i386
I: debug source: non-standard-architecture ppc64
W: debug source: changelog-should-not-mention-nmu
+W: debug source: debian-rules-sets-DH_COMPAT line 5
W: debug source: out-of-date-standards-version 3.7.0 (current is 3.7.2)
W: hello: binary-without-manpage usr/bin/hello
W: hello: binary-without-manpage usr/bin/hello.dbg
Modified: trunk/testset/tags.dh-test
===================================================================
--- trunk/testset/tags.dh-test 2007-04-11 02:30:00 UTC (rev 841)
+++ trunk/testset/tags.dh-test 2007-04-11 02:59:33 UTC (rev 842)
@@ -1,6 +1,7 @@
E: dh-test: description-is-dh_make-template
E: dh-test: helper-templates-in-copyright
E: dh-test: section-is-dh_make-template
+W: dh-test source: debian-rules-sets-DH_COMPAT line 12
W: dh-test source: dh_suidregister-is-obsolete
W: dh-test source: dh_testversion-is-deprecated
W: dh-test source: native-package-with-dash-version
Reply to: