[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#231770: lintian: Add checks for prompting in maintainerscripts



tags 231770 +patch
thanks

Hi

Easy patch included for consideration.

Cheers

Luk

-- 
Luk Claes - http://people.debian.org/~luk - GPG key 1024D/9B7C328D
Fingerprint:   D5AF 25FB 316B 53BB 08E7   F999 E544 DE07 9B7C 328D
diff -Nru lintian-1.23.28/checks/scripts lintian-1.23.28.new/checks/scripts
--- lintian-1.23.28/checks/scripts	2007-03-10 07:55:47.000000000 +0100
+++ lintian-1.23.28.new/checks/scripts	2007-04-10 08:18:15.000000000 +0200
@@ -463,6 +463,9 @@
 	if (m/^\s*mknod(?:\s|$)/ and not m/\sp\s/) {
 	    tag "mknod-in-maintainer-script", "$file:$.";
 	}
+	if (m/^\s*read(?:\s|$)/) {
+	    tag "read-in-maintainer-script", "$file:$.";
+	}
 
 	# Collect information about init script invocations to catch running
 	# init scripts directory rather than through invoke-rc.d.  Since the
diff -Nru lintian-1.23.28/checks/scripts.desc lintian-1.23.28.new/checks/scripts.desc
--- lintian-1.23.28/checks/scripts.desc	2007-03-10 07:55:47.000000000 +0100
+++ lintian-1.23.28.new/checks/scripts.desc	2007-04-10 08:24:06.000000000 +0200
@@ -345,3 +345,10 @@
 Type: warning
 Info: This script apparently runs gconftool or gconftool-2.  It should
  probably be calling gconf-schemas or update-gconf-defaults instead.
+
+Tag: read-in-maintainer-script
+Type: warning
+Info: Prompting in maintainer scripts should be done by communicating
+ through a program which conforms to the Debian Configuration management
+ specification, version 2 or higher.
+Ref: policy 3.9.1 

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: