Hi again,
Thomas Huriaux <thomas.huriaux@gmail.com> (12/04/2006):
> The attached patches add an initial set of checks (which can of course
> be improved) for accordance with the developers-reference.
> + # Check the debconf writing style
> + $template->{description} =~ m/^([^\n]*)\n(.*)$/s;
> + my ($shortDescription, $extendedDescription) = ($1, $2);
I forgot to check if $1 and $2 are defined. To surround the next two loops
with
if (defined $shortDescription)
and
if (defined $extendedDescription)
should be enough.
> + foreach my $test (@{$testsDescription{$template->{type}}}, @globalTests, @globalDescriptionTests) {
> + $testSuite{$test}->($shortDescription);
> + }
> + foreach my $test (@{$testsExtended{$template->{type}}}, @globalTests, @globalExtendedTests) {
> + $testSuite{$test}->($extendedDescription);
> + }
The x11-common and xserver-xorg packages contain empty extended
descriptions, in case you want to test it.
--
Thomas Huriaux
Attachment:
signature.asc
Description: Digital signature