lintian: r613 - in trunk: checks debian

[rra@debian.org]

Author: rra
Date: 2006-04-04 23:42:11 +0200 (Tue, 04 Apr 2006)
New Revision: 613

Modified:
   trunk/checks/nmu
   trunk/checks/nmu.desc
   trunk/debian/changelog
Log:
* checks/nmu{.desc,}:
  + [RA] Warn if debian/changelog in a native source package is a
    symlink and skip checks rather than aborting if it was a symlink to
    a file we didn't unpack.  (Closes: #257650)

Modified: trunk/checks/nmu
===================================================================
--- trunk/checks/nmu	2006-04-04 21:17:22 UTC (rev 612)
+++ trunk/checks/nmu	2006-04-04 21:42:11 UTC (rev 613)
@@ -31,6 +31,15 @@
 my $changelog_mentions_qa = 0;
 my $uploader = undef;
 
+# This isn't really an NMU check, but right now no other check looks at
+# debian/changelog in source packages.  Catch a debian/changelog file that's a
+# symlink.  If it was a symlink to a file we didn't unpack, bail rather than
+# abort.
+if (-l "debfiles/changelog") {
+    tag "changelog-is-symlink", "";
+    return 0 unless -f "debfiles/changelog";
+}
+
 open CHANGELOG, "debfiles/changelog" or fail("Failed opening changelog");
 <CHANGELOG>;
 my $firstline = 1;

Modified: trunk/checks/nmu.desc
===================================================================
--- trunk/checks/nmu.desc	2006-04-04 21:17:22 UTC (rev 612)
+++ trunk/checks/nmu.desc	2006-04-04 21:42:11 UTC (rev 613)
@@ -49,3 +49,14 @@
  Maybe you didn't intend this upload to be a NMU, in that case, please
  doublecheck that the most recent entry in the changelog is byte-for-byte
  identical to the maintainer or one of the uploaders.
+
+Tag: changelog-is-symlink
+Type: warning
+Info: The file <tt>debian/changelog</tt> is a symlink instead of a regular
+ file. This is unnecessary and makes package checking and manipulation
+ more difficult. If the changelog should be available in the source
+ package under multiple names, make <tt>debian/changelog</tt> the real
+ file and the other names symlinks to it.
+ .
+ This problem may have prevented lintian from performing other checks,
+ leading to undetected changelog errors.

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog	2006-04-04 21:17:22 UTC (rev 612)
+++ trunk/debian/changelog	2006-04-04 21:42:11 UTC (rev 613)
@@ -39,6 +39,10 @@
     + [RA] Use system_env instead of system and sanitize the environment
       before running man -l out of caution and to avoid extraneous output
       when CDPATH is set.  Reported by Marc Haber.  (Closes: #360217)
+  * checks/nmu{.desc,}:
+    + [RA] Warn if debian/changelog in a native source package is a
+      symlink and skip checks rather than aborting if it was a symlink to
+      a file we didn't unpack.  (Closes: #257650)
   * checks/po-debconf:
     + [RA] Use system_env instead of system out of caution and to avoid
       extraneous output when CDPATH is set.