lintian: r597 - in trunk: checks debian testset testset/maintainer-scripts/debian
Author: rra
Date: 2006-04-01 08:01:57 +0200 (Sat, 01 Apr 2006)
New Revision: 597
Modified:
trunk/checks/scripts
trunk/checks/scripts.desc
trunk/debian/changelog
trunk/testset/maintainer-scripts/debian/postinst
trunk/testset/tags.maintainer-scripts
Log:
* checks/scripts.desc:
+ [RA] Change the check for broken error handling with invoke-rc.d to
maintainer-script-hides-init-failure to be more generic and explain
what the test looks at. Add the script name and line number and fix
a typo. Thanks, Marc Haber. (Closes: #360214, #360216)
Modified: trunk/checks/scripts
===================================================================
--- trunk/checks/scripts 2006-03-30 03:39:36 UTC (rev 596)
+++ trunk/checks/scripts 2006-04-01 06:01:57 UTC (rev 597)
@@ -540,7 +540,7 @@
}
}
if (/invoke-rc.d.*\|\| exit 0/) {
- tag "maintainer-script-built-with-broken-debhelper-version";
+ tag "maintainer-script-hides-init-failure", "$file:$.";
}
}
Modified: trunk/checks/scripts.desc
===================================================================
--- trunk/checks/scripts.desc 2006-03-30 03:39:36 UTC (rev 596)
+++ trunk/checks/scripts.desc 2006-04-01 06:01:57 UTC (rev 597)
@@ -287,8 +287,13 @@
Using "." as a separator is still supported by the GNU tools, but it will
fail as soon as a system uses the "." in user or group names.
-Tag: maintainer-script-built-with-broken-debhelper-version
+Tag: maintainer-script-hides-init-failure
Type: warning
-Info: This packag was built with a debhelper version suffering from #337664.
- The package needs to be reuploaded (could be bin-NMUd, no source changes
- needed)
+Info: This script calls invoke-rc.d to run an init script but then, if the
+ init script fails, exits successfully (using || exit 0). If the init
+ script fails, the maintainer script should probably fail.
+ .
+ The most likely cause of this problem is that the package was built with
+ a debhelper version suffering from Bug#337664 that inserted incorrect
+ invoke-rc.d code in the generated maintainer script. The package needs to
+ be reuploaded (could be bin-NMUd, no source changes needed).
Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog 2006-03-30 03:39:36 UTC (rev 596)
+++ trunk/debian/changelog 2006-04-01 06:01:57 UTC (rev 597)
@@ -14,8 +14,13 @@
are now too many combinations to list completely.
+ [RA] Catch build dependencies on X metapackages, based on a patch by
Josh Triplett. (Partially addresses #347169)
+ * checks/scripts.desc:
+ + [RA] Change the check for broken error handling with invoke-rc.d to
+ maintainer-script-hides-init-failure to be more generic and explain
+ what the test looks at. Add the script name and line number and fix
+ a typo. Thanks, Marc Haber. (Closes: #360214, #360216)
- -- Russ Allbery <rra@debian.org> Sun, 26 Mar 2006 16:16:55 -0800
+ -- Russ Allbery <rra@debian.org> Fri, 31 Mar 2006 22:00:45 -0800
lintian (1.23.16) unstable; urgency=low
Modified: trunk/testset/maintainer-scripts/debian/postinst
===================================================================
--- trunk/testset/maintainer-scripts/debian/postinst 2006-03-30 03:39:36 UTC (rev 596)
+++ trunk/testset/maintainer-scripts/debian/postinst 2006-04-01 06:01:57 UTC (rev 597)
@@ -50,3 +50,6 @@
echo foo >>/tmp/scripts.tmp
rm /tmp/scripts.tmp
rmdir /var/tmp/scripts
+
+# invalid, maintainer-script-hides-init-failure
+invoke-rc.d foo start || exit 0
Modified: trunk/testset/tags.maintainer-scripts
===================================================================
--- trunk/testset/tags.maintainer-scripts 2006-03-30 03:39:36 UTC (rev 596)
+++ trunk/testset/tags.maintainer-scripts 2006-04-01 06:01:57 UTC (rev 597)
@@ -25,6 +25,7 @@
W: maintainer-scripts: deprecated-chown-usage postinst:33 'chown root.root'
W: maintainer-scripts: init.d-script-not-marked-as-conffile /etc/init.d/foo
W: maintainer-scripts: maintainer-script-calls-deprecated-wm-menu-config postinst:31
+W: maintainer-scripts: maintainer-script-hides-init-failure postinst:55
W: maintainer-scripts: missing-debconf-dependency
W: maintainer-scripts: no-debconf-templates
W: maintainer-scripts: possible-bashism-in-maintainer-script postinst:15 '. /usr/share/lintian/shell foo'
Reply to: