[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

lintian: r776 - in trunk: checks debian



Author: rra
Date: 2006-11-11 09:14:41 +0100 (Sat, 11 Nov 2006)
New Revision: 776

Modified:
   trunk/checks/debdiff
   trunk/checks/debdiff.desc
   trunk/checks/files
   trunk/checks/files.desc
   trunk/debian/changelog
Log:
  + [RA] Check for creation of ~ and .xxx.swp backup files in the Debian
    diff, but only at the info level for now since they cause no harm.
    (Closes: #332770)
* checks/files{.desc,}:
  + [RA] Check for vim .swp files in the package.
  + [RA] Split the warning for NFS temporary files into a separate tag
    from the warning for editor backup files.

Modified: trunk/checks/debdiff
===================================================================
--- trunk/checks/debdiff	2006-11-11 07:52:53 UTC (rev 775)
+++ trunk/checks/debdiff	2006-11-11 08:14:41 UTC (rev 776)
@@ -51,7 +51,7 @@
     tag_warn("patch-failure-file-in-diff", $file)
 	if ($file =~ m/\.(orig|rej)$/);
     tag_warn("editor-backup-file-in-diff", $file)
-	if ($file =~ /~$/ && /\|\s+\d+\s+\++$/);
+	if ($file =~ m%((^|/)\.[^/]+\.swp|~)$% && /\|\s+\d+\s+\++$/);
 
     tag_warn("diff-contains-substvars", $file)
 	if ($file =~ m%^debian/substvars$%);

Modified: trunk/checks/debdiff.desc
===================================================================
--- trunk/checks/debdiff.desc	2006-11-11 07:52:53 UTC (rev 775)
+++ trunk/checks/debdiff.desc	2006-11-11 08:14:41 UTC (rev 776)
@@ -17,11 +17,11 @@
 
 Tag: editor-backup-file-in-diff
 Type: info
-Info: The Debian diff contains a file ending in <tt>~</tt>, which is
- normally either an Emacs backup file or a backup file created by programs
- such as <tt>autoheader</tt> or <tt>debconf-updatepo</tt>.  This usually
- causes no harm, but it's messy and bloats the size of the Debian diff,
- usually to no useful purpose.
+Info: The Debian diff contains a file ending in <tt>~</tt> or of the form
+ <tt>.xxx.swp</tt>, which is normally either an Emacs or vim backup file
+ or a backup file created by programs such as <tt>autoheader</tt> or
+ <tt>debconf-updatepo</tt>.  This usually causes no harm, but it's messy
+ and bloats the size of the Debian diff to no useful purpose.
 
 Tag: native-package-with-dash-version
 Type: warning

Modified: trunk/checks/files
===================================================================
--- trunk/checks/files	2006-11-11 07:52:53 UTC (rev 775)
+++ trunk/checks/files	2006-11-11 08:14:41 UTC (rev 776)
@@ -512,9 +512,12 @@
     if ($perm =~ m/^-/) {
 	my $wanted_operm;
 	# ---------------- backup files and autosave files
-	if ($file =~ /~$/ or $file =~ m,\#[^/]+\#$, or $file =~ m,/\.nfs[^/]+$,) {
+	if ($file =~ /~$/ or $file =~ m,\#[^/]+\#$, or $file =~ m,/\.[^/]+\.swp$,) {
 	    tag "backup-file-in-package", "$file";
 	}
+	if ($file =~ m,/\.nfs[^/]+$,) {
+	    tag "nfs-temporary-file-in-package", "$file";
+	}
 	
 	# ---------------- cvsignore files
 	if ($file =~ m/\.cvsignore$/) {

Modified: trunk/checks/files.desc
===================================================================
--- trunk/checks/files.desc	2006-11-11 07:52:53 UTC (rev 775)
+++ trunk/checks/files.desc	2006-11-11 08:14:41 UTC (rev 776)
@@ -399,9 +399,17 @@
 
 Tag: backup-file-in-package
 Type: warning
-Info: There is a file in the package that matches the format emacs uses
- for backup and autosave files.  It may have been installed by accident.
+Info: There is a file in the package whose name matches the format emacs
+ or vim uses for backup and autosave files.  It may have been installed by
+ accident.
 
+Tag: nfs-temporary-file-in-package
+Type: warning
+Info: There is a file in the package whose name matches the format NFS
+ uses to temporarily save files that were deleted while another process
+ had them open.  It may have been included in the package by accident
+ while building the package in an NFS filesystem.
+
 Tag: package-installs-perllocal-pod
 Type: warning
 Info: This package installs a file <tt>perllocal.pod</tt>.  Since that

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog	2006-11-11 07:52:53 UTC (rev 775)
+++ trunk/debian/changelog	2006-11-11 08:14:41 UTC (rev 776)
@@ -38,13 +38,18 @@
     + [RA] Close files after opening them, fixing incorrect line numbers
       when reporting problems with config scripts.
   * checks/debdiff{.desc,}:
-    + [RA] Check for creation of ~ backup files in the Debian diff, but
-      only at the info level for now since they cause no harm.
+    + [RA] Check for creation of ~ and .xxx.swp backup files in the Debian
+      diff, but only at the info level for now since they cause no harm.
+      (Closes: #332770)
   * checks/fields{.desc,}:
     + [RA] Clarify in missing-build-dependency why lintian does not take
       into account transitive build dependencies.  (Closes: #393975)
     + [RA] Avoid Perl warning when diagnosing a Python-Version of the form
       "all, >= 2.4".  Thanks, Thijs Kinkhorst.  (Closes: #394104)
+  * checks/files{.desc,}:
+    + [RA] Check for vim .swp files in the package.
+    + [RA] Split the warning for NFS temporary files into a separate tag
+      from the warning for editor backup files.
   * checks/infofiles:
     + [RA] Close opened files.
   * checks/md5sums{.desc,}:
@@ -66,7 +71,7 @@
       various subdirectories of its standard search path based on hardware
       capabilities.  Reported by Aurelien Jarno.  (Closes: #396278)
 
- -- Russ Allbery <rra@debian.org>  Fri, 10 Nov 2006 23:50:52 -0800
+ -- Russ Allbery <rra@debian.org>  Sat, 11 Nov 2006 00:10:16 -0800
 
 lintian (1.23.25) unstable; urgency=low
 



Reply to: