lintian: r773 - in trunk: checks debian testset testset/diffs

[rra@debian.org]

Author: rra
Date: 2006-11-11 07:46:36 +0100 (Sat, 11 Nov 2006)
New Revision: 773

Added:
   trunk/testset/diffs/binary.c~
Modified:
   trunk/checks/debdiff
   trunk/checks/debdiff.desc
   trunk/debian/changelog
   trunk/testset/tags.diffs
Log:
* checks/debdiff{.desc,}:
  + [RA] Check for creation of ~ backup files in the Debian diff, but
    only at the info level for now since they cause no harm.

Modified: trunk/checks/debdiff
===================================================================
--- trunk/checks/debdiff	2006-11-11 06:32:37 UTC (rev 772)
+++ trunk/checks/debdiff	2006-11-11 06:46:36 UTC (rev 773)
@@ -50,6 +50,8 @@
     $file = $1;
     tag_warn("patch-failure-file-in-diff", $file)
 	if ($file =~ m/\.(orig|rej)$/);
+    tag_warn("editor-backup-file-in-diff", $file)
+	if ($file =~ /~$/ && /\|\s+\d+\s+\++$/);
 
     tag_warn("diff-contains-substvars", $file)
 	if ($file =~ m%^debian/substvars$%);

Modified: trunk/checks/debdiff.desc
===================================================================
--- trunk/checks/debdiff.desc	2006-11-11 06:32:37 UTC (rev 772)
+++ trunk/checks/debdiff.desc	2006-11-11 06:46:36 UTC (rev 773)
@@ -4,7 +4,8 @@
 Standards-Version: 3.6.1
 Type: source
 Unpack-Level: 1
-Info: This script checks the diff to the original source tarball of a debian package
+Info: This script checks the diff to the original source tarball of a
+ debian package
 Needs-Info: diffstat
 
 Tag: patch-failure-file-in-diff
@@ -14,6 +15,14 @@
  in the Debian-diff for this source package.  This may indicate that the
  maintainer applied a patch that did not quite fit, and didn't notice.
 
+Tag: editor-backup-file-in-diff
+Type: info
+Info: The Debian diff contains a file ending in <tt>~</tt>, which is
+ normally either an Emacs backup file or a backup file created by programs
+ such as <tt>autoheader</tt> or <tt>debconf-updatepo</tt>.  This usually
+ causes no harm, but it's messy and bloats the size of the Debian diff,
+ usually to no useful purpose.
+
 Tag: native-package-with-dash-version
 Type: warning
 Info: Native packaging should only be used if a piece of software was

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog	2006-11-11 06:32:37 UTC (rev 772)
+++ trunk/debian/changelog	2006-11-11 06:46:36 UTC (rev 773)
@@ -24,6 +24,9 @@
       preinst script.  Update the long description to deprecate only
       depending on debconf and falling back on another configuration
       system.  Reported by Josselin Mouette.  (Closes: #395468)
+  * checks/debdiff{.desc,}:
+    + [RA] Check for creation of ~ backup files in the Debian diff, but
+      only at the info level for now since they cause no harm.
   * checks/fields{.desc,}:
     + [RA] Clarify in missing-build-dependency why lintian does not take
       into account transitive build dependencies.  (Closes: #393975)
@@ -48,7 +51,7 @@
       various subdirectories of its standard search path based on hardware
       capabilities.  Reported by Aurelien Jarno.  (Closes: #396278)
 
- -- Russ Allbery <rra@debian.org>  Fri, 10 Nov 2006 22:25:17 -0800
+ -- Russ Allbery <rra@debian.org>  Fri, 10 Nov 2006 22:45:51 -0800
 
 lintian (1.23.25) unstable; urgency=low
 

Added: trunk/testset/diffs/binary.c~
===================================================================
--- trunk/testset/diffs/binary.c~	2006-11-11 06:32:37 UTC (rev 772)
+++ trunk/testset/diffs/binary.c~	2006-11-11 06:46:36 UTC (rev 773)
@@ -0,0 +1,5 @@
+#include <stdio.h>
+
+int main () {
+  printf("Helooooooo nurse! :)\n");
+}

Modified: trunk/testset/tags.diffs
===================================================================
--- trunk/testset/tags.diffs	2006-11-11 06:32:37 UTC (rev 772)
+++ trunk/testset/tags.diffs	2006-11-11 06:46:36 UTC (rev 773)
@@ -2,6 +2,7 @@
 E: diffs: arch-independent-package-contains-binary-or-object ./usr/bin/diffs
 E: diffs: no-copyright-file
 E: diffs: unstripped-binary-or-object ./usr/bin/diffs
+I: diffs source: editor-backup-file-in-diff binary.c~
 I: diffs: no-md5sums-control-file
 W: diffs source: configure-generated-file-in-source config.cache
 W: diffs source: configure-generated-file-in-source config.log