[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

lintian: r752 - in trunk: checks debian frontend



Author: rra
Date: 2006-09-25 05:43:17 +0200 (Mon, 25 Sep 2006)
New Revision: 752

Modified:
   trunk/checks/debdiff
   trunk/checks/debdiff.desc
   trunk/checks/lintian.desc
   trunk/debian/changelog
   trunk/frontend/lintian
Log:
* checks/debdiff:
  + [RA] Remove the source-tar-is-posix-tar tag.  This was only a
    problem for woody and earlier, and woody support is no longer
    needed.  Reported by Lo?\195?\175c Minier.  (Closes: #385833)
* checks/lintian.desc:
  + [RA] Add tags for missing and bad Urgency fields in *.changes files.
  + [RA] Improve the no-description-in-changes-file information.
* frontend/lintian:
  + [RA] Check the existence and value of the Urgency field in *.changes
    files.  (Closes: #384219)

Modified: trunk/checks/debdiff
===================================================================
--- trunk/checks/debdiff	2006-09-24 05:58:23 UTC (rev 751)
+++ trunk/checks/debdiff	2006-09-25 03:43:17 UTC (rev 752)
@@ -1,4 +1,4 @@
-# debdiff -- Lintian check script
+# debdiff -- Lintian check script -*- perl -*-
 
 # Copyright (C) 1998 Richard Braakman
 #
@@ -56,17 +56,6 @@
 }
 close(STAT) or fail("error reading diffstat file: $!");
 
-# Check whether a tar.gz file is accidentally POSIX tar, which woody's tar
-# can't cope with...
-for my $tar (<*.tar.gz>) {
-    open HEAD, '-|', 'zcat '.quotemeta($tar) or fail("Couldn't open ${tar}: $!");
-	my $head = "";
-    sysread HEAD, $head, 13 or fail("Couldn't read first part of $tar: $!");
-    tag "source-tar-is-posix-tar", "$tar"
-    	if $head eq './PaxHeaders.';
-    close HEAD;
-}
-
 } # </run>
 
 # ---------------------------------

Modified: trunk/checks/debdiff.desc
===================================================================
--- trunk/checks/debdiff.desc	2006-09-24 05:58:23 UTC (rev 751)
+++ trunk/checks/debdiff.desc	2006-09-25 03:43:17 UTC (rev 752)
@@ -31,15 +31,3 @@
  dynamically by debian/rules targets, in which case it must be removed by
  the clean target.
 Ref: policy 4.9
-
-Tag: source-tar-is-posix-tar
-Type: error
-Info: The source tar archive of this package is made with tar --posix. This
- tar format is actually not understood by woody's tar.
- .
- Some automake 1.7 and 1.8 versions in Debian had this wrong tar option for a
- short time, re-autobuilding should solve this. Please see
- http://lists.debian.org/debian-devel/2004/debian-devel-200404/msg01376.html
- and
- http://lists.debian.org/debian-devel/2004/debian-devel-200404/msg01586.html
- for more details.

Modified: trunk/checks/lintian.desc
===================================================================
--- trunk/checks/lintian.desc	2006-09-24 05:58:23 UTC (rev 751)
+++ trunk/checks/lintian.desc	2006-09-25 03:43:17 UTC (rev 752)
@@ -4,8 +4,10 @@
 
 Tag: no-description-in-changes-file
 Type: error
-Info: There is no "Description" field in your .changes file
- A description is mandatory
+Info: There is no "Description" field in your .changes file.  A
+ description is mandatory and is usually constructed from the descriptions
+ in the control file of the package by the package build tools.
+Ref: policy 5.5
 
 Tag: bad-distribution-in-changes-file
 Type: error
@@ -17,6 +19,21 @@
  `<tt>unstable</tt>' and `<tt>Section: non-free/xxx</tt>' or
  `<tt>Section: contrib/xxx</tt>' instead.
 
+Tag: no-urgency-in-changes-file
+Type: warning
+Info: There is no "Urgency" field in the .changes file.  This field is
+ recommended by policy and is usually derived from the first line of the
+ most recent changelog entry by the package build tools.
+Ref: policy 5.5
+
+Tag: bad-urgency-in-changes-file
+Type: error
+Info: The keyword value of the "Urgency" field in the .changes file is not
+ one of the allowed values of low, medium, and high (case-insensitive).
+ This value normally taken from the first line of the most recent entry in
+ <tt>debian/changelog</tt>, which is probably where the error is.
+Ref: policy 5.6.17
+
 Tag: file-size-mismatch-in-changes-file
 Type: error
 Info: The actual file size does not match what's listed in the

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog	2006-09-24 05:58:23 UTC (rev 751)
+++ trunk/debian/changelog	2006-09-25 03:43:17 UTC (rev 752)
@@ -3,6 +3,10 @@
   * checks/debconf:
     + [CW] Don't trigger partially-translated-question when Choices-C exists
       but not Description-C.
+  * checks/debdiff:
+    + [RA] Remove the source-tar-is-posix-tar tag.  This was only a
+      problem for woody and earlier, and woody support is no longer
+      needed.  Reported by Loïc Minier.  (Closes: #385833)
   * checks/fields{.desc,}:
     + [RA] Improve the long descriptions of the warnings about dependencies
       on essential or build-essential packages to make it clearer that the
@@ -14,6 +18,9 @@
   * checks/init.d:
     + [RA] Correctly handle LSB keywords which are present but have an
       empty value.  Reported by Erich Schubert.  (Closes: #386968)
+  * checks/lintian.desc:
+    + [RA] Add tags for missing and bad Urgency fields in *.changes files.
+    + [RA] Improve the no-description-in-changes-file information.
   * checks/po-debconf:
     + [RA] Avoid Perl warnings on .po files that don't contain msgstr
       lines.  Patch from Thomas Huriaux.  (Closes: #387357)
@@ -25,6 +32,10 @@
       package in its tag.  Fix inverted logic that got the wish dependency
       backwards.  Reported by Hamish Moffatt.  (Closes: #387845)
 
+  * frontend/lintian:
+    + [RA] Check the existence and value of the Urgency field in *.changes
+      files.  (Closes: #384219)
+
   * lib/Dep.pm:
     + [RA] Improve the dependency resolution engine so that it can prove
       aa|bb implies aa|bb|cc.  Fix the comparison of dependencies for
@@ -36,7 +47,7 @@
       find relations that imply each other and to return the complete
       duplicate dependencies in sets.
 
- -- Russ Allbery <rra@debian.org>  Sat, 23 Sep 2006 22:57:34 -0700
+ -- Russ Allbery <rra@debian.org>  Sun, 24 Sep 2006 20:42:56 -0700
 
 lintian (1.23.24) unstable; urgency=low
 

Modified: trunk/frontend/lintian
===================================================================
--- trunk/frontend/lintian	2006-09-24 05:58:23 UTC (rev 751)
+++ trunk/frontend/lintian	2006-09-25 03:43:17 UTC (rev 752)
@@ -642,6 +642,17 @@
 		    $data->{'distribution'});
 	    }
 
+	    # Urgency is only recommended by Policy.
+	    if (!$data->{'urgency'}) {
+		tag("no-urgency-in-changes-file");
+	    } else {
+		my $urgency = lc $data->{'urgency'};
+		$urgency =~ s/ .*//;
+		unless ($urgency =~ /^(low|medium|high)$/) {
+		    tag("bad-urgency-in-changes-file", $data->{'urgency'});
+		}
+	    }
+
 	    # process all listed `files:'
 	    for (split(/\n/o,$data->{'files'})) {
 		chomp;



Reply to: