[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#386014: marked as done ([checks/debconf] invalid debconf priority)



Your message dated Mon, 04 Sep 2006 14:03:01 -0700
with message-id <E1GKLav-0000FB-8A@spohr.debian.org>
and subject line Bug#386014: fixed in lintian 1.23.24
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: lintian
Version: 1.23.23
Severity: wishlist
Tags: patch

Hi,

The attached patch allow lintian to raise an error if the debconf priority
is unknown. Testing it on the archive gives the following results (I
found only two packages affected by this problem):
  E: aide: unknown-debconf-priority normal
    should be medium
  E: cmucl: unknown-debconf-priority critital
    should be critical

Cheers,

-- 
Thomas Huriaux
--- /usr/share/lintian/checks/debconf.desc	2006-06-25 05:31:54.000000000 +0200
+++ debconf.desc	2006-09-04 18:18:41.000000000 +0200
@@ -265,3 +265,8 @@
  more than about 20 lines, so try to keep the extended description below
  this limit.
 Ref: devref 6.5.3.2
+
+Tag: unknown-debconf-priority
+Type: error
+Info: Valid debconf priorities are low, medium, high or critical.
+Ref: debconf-devel(7)
--- /usr/share/lintian/checks/debconf	2006-08-19 00:19:42.000000000 +0200
+++ debconf	2006-09-04 18:18:29.000000000 +0200
@@ -348,6 +348,9 @@
 		    unless $type eq 'udeb';
 	        $db_input=1;
 	    }
+	    if (m/^\s*(?:db_input|db_text)\s+(\S+)\s+\S+\s/) {
+	      tag "unknown-debconf-priority", "$1" unless ($1 =~ /^["']?(low|medium|high|critical|\$\S+)["']?$/);
+	    }
 	    if (not $isdefault and m/db_fset.*isdefault/) {
 	        # TODO: Perl?
 	        tag "isdefault-flag-is-deprecated", "$file";

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message ---
Source: lintian
Source-Version: 1.23.24

We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive:

lintian_1.23.24.dsc
  to pool/main/l/lintian/lintian_1.23.24.dsc
lintian_1.23.24.tar.gz
  to pool/main/l/lintian/lintian_1.23.24.tar.gz
lintian_1.23.24_all.deb
  to pool/main/l/lintian/lintian_1.23.24_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 386014@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Russ Allbery <rra@debian.org> (supplier of updated lintian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Mon,  4 Sep 2006 12:03:16 -0700
Source: lintian
Binary: lintian
Architecture: source all
Version: 1.23.24
Distribution: unstable
Urgency: low
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Russ Allbery <rra@debian.org>
Description: 
 lintian    - Debian package checker
Closes: 376119 377740 384476 385178 386014
Changes: 
 lintian (1.23.24) unstable; urgency=low
 .
   The "LSB init script" release
 .
   * checks/control-files:
     + [RA] perm2oct definition moved to Util.pm.
   * checks/cruft{.desc,}:
     + [RA] Remove the (info-level) check for .cvsignore files in the
       source tarball.  This isn't an error; those files contain metadata
       that may be useful for people making modifications and it's quite
       common to distribute them.
   * checks/debconf{.desc,}:
     + [RA] Diagnose unknown priorities in db_input and db_text
       invocations.  Patch from Thomas Huriaux.  (Closes: #386014)
   * checks/fields{.desc,}:
     + [RA] Depending on versioned variants of python-minimal is also an
       error.  Thanks, Adeodato Simó.  (Closes: #384476)
   * checks/files:
     + [RA] perm2oct definition moved to Util.pm.
   * checks/init.d{.desc,}:
     + [RA] Added a warning for init scripts missing an LSB keyword
       section, checks of the syntax of such a section if present, and
       some basic semantic checks of the easiest fields.  Based on initial
       work by Carlos Villegas.  (Closes: #377740)
   * checks/menus:
     + [RA] perm2oct definition moved to Util.pm.
   * checks/scripts:
     + [RA] Properly concatenate the dependencies for a package when
       checking whether the dependency for an interpreter is included.
       Thanks, Vincent Danjean.  (Closes: #385178)
   * checks/shared-libs:
     + [RA] perm2oct definition moved to Util.pm.
 .
   * lib/Util.pm:
     + [RA] Move perm2oct to here and improve recognition of s, S, t, and T
       characters.  Thanks to Justin B. Rye for patch.  (Closes: #376119)
Files: 
 d99a044f4bdd199c9b267c89cf3f5cbb 803 devel optional lintian_1.23.24.dsc
 be2ff09babea1a73bb75c8508e2465f5 312666 devel optional lintian_1.23.24.tar.gz
 c681e9f48104e3304cbfdccfd814b563 265882 devel optional lintian_1.23.24_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFE/Hly+YXjQAr8dHYRApd/AJ9wSSrBO1DHUoNEj01P4qgeUjOggACfTxL9
HXfRImQB2t1Dn7cSv/eCepI=
=dM09
-----END PGP SIGNATURE-----


--- End Message ---

Reply to: