lintian: r698 - in trunk: checks debian

[rra@debian.org]

Author: rra
Date: 2006-07-15 07:18:41 +0200 (Sat, 15 Jul 2006)
New Revision: 698

Modified:
   trunk/checks/fields
   trunk/checks/fields.desc
   trunk/debian/changelog
Log:
* checks/fields{.desc,}:
  + [RA] Don't warn virtual-package-depends-without-real-package-depends
    for Recommends and rewrite the tag description to be more accurate.
    Thanks to Martin Krafft for the report.  (Closes: #370720)

Modified: trunk/checks/fields
===================================================================
--- trunk/checks/fields	2006-07-15 03:31:59 UTC (rev 697)
+++ trunk/checks/fields	2006-07-15 05:18:41 UTC (rev 698)
@@ -375,9 +375,10 @@
 				push @seen_tkxs, $alternatives[0]->[0] if defined $known_tkxs{$alternatives[0]->[0]};
 				push @seen_libpngs, $alternatives[0]->[0] if defined $known_libpngs{$alternatives[0]->[0]};
 
+				# Only for (Pre-)?Depends.
 				tag "virtual-package-depends-without-real-package-depends", "$field: $alternatives[0]->[0]"
-				    if ($known_virtual_packages{$alternatives[0]->[0]} && &$is_dep_field($field)
-				        && $field ne "suggests"); #We don't wanna issue this for suggests, only for depends and recommends
+				    if ($known_virtual_packages{$alternatives[0]->[0]}
+					&& ($field eq "depends" || $field eq "pre-depends"));
 
 				for my $part_d (@alternatives) {
 					my ($d_pkg, $d_version, $d_arch, $rest, $part_d_orig) = @$part_d;

Modified: trunk/checks/fields.desc
===================================================================
--- trunk/checks/fields.desc	2006-07-15 03:31:59 UTC (rev 697)
+++ trunk/checks/fields.desc	2006-07-15 05:18:41 UTC (rev 698)
@@ -398,14 +398,17 @@
 
 Tag: virtual-package-depends-without-real-package-depends
 Type: warning
-Ref: policy 7.4
 Info: The package declares a depends on a virtual package without listing a
  real package as an alternative first.
  .
- A real package should be listed in the first part of the | dependency in
- order for the package to be installable by package management programs that
- can't or won't guess which alternative to select by default. In particular,
- it helps build daemons rebuild the package without manual overrides.
+ If this package could ever be a build dependency, it should list a real
+ package as the first alternative to any virtual package in its Depends.
+ Otherwise, the build daemons will not be able to provide a consistent
+ build environment.
+ .
+ If it will never be a build dependency, this isn't necessary, but you may
+ want to consider doing so anyway if there is a real package providing
+ that virtual package that most users will want to use.
 
 Tag: invalid-arch-string-in-source-relation
 Type: error

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog	2006-07-15 03:31:59 UTC (rev 697)
+++ trunk/debian/changelog	2006-07-15 05:18:41 UTC (rev 698)
@@ -1,5 +1,9 @@
 lintian (1.23.23) UNRELEASED; urgency=low
 
+  * checks/fields{.desc,}:
+    + [RA] Don't warn virtual-package-depends-without-real-package-depends
+      for Recommends and rewrite the tag description to be more accurate.
+      Thanks to Martin Krafft for the report.  (Closes: #370720)
   * checks/manpages{.desc,}:
     + [RA] Warn about manpage short descriptions of the form "manual page
       for program" (usually generated by help2man).
@@ -9,7 +13,7 @@
     + [RA] Warn if the changelog incorrectly indicates an NMU.  Thanks to
       George Danchev for the report.
 
- -- Russ Allbery <rra@debian.org>  Fri, 14 Jul 2006 20:24:14 -0700
+ -- Russ Allbery <rra@debian.org>  Fri, 14 Jul 2006 22:17:24 -0700
 
 lintian (1.23.22) unstable; urgency=low