[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#377654: lintian: "uninitialized value" in debconf checks if there is no template description



Package: lintian
Version: 1.23.22
Severity: minor
Tags: patch

Hi,

In case of an empty description, lintian first return the
no-template-description tag, and then go on with the template checks,
while the description does not exist. For example:

$ lintian dbconfig-common_1.8.17_all.deb
E: dbconfig-common: no-template-description
  dbconfig-common/internal/reconfiguring
Use of uninitialized value in pattern match (m//)
  at /usr/share/lintian/checks/debconf line 235.
Use of uninitialized value in pattern match (m//)
  at /usr/share/lintian/checks/debconf line 240.
Use of uninitialized value in pattern match (m//)
  at /usr/share/lintian/checks/debconf line 251.

The attached patch should fix this problem.

-- 
Thomas Huriaux
--- debconf	2006-07-10 15:28:42.000000000 +0200
+++ debconf.new	2006-07-10 15:33:19.000000000 +0200
@@ -232,6 +232,7 @@
     # Check the description against the best practices in the Developer's
     # Reference, but skip all templates where the short description contains
     # the string "for internal use".
+    if (exists $template->{description}) {
     $template->{description} =~ m/^([^\n]*)\n(.*)$/s;
     my ($short, $extended) = ($1, $2);
     unless (defined $short) {
@@ -293,6 +294,7 @@
 	    }
 	}
     }
+    }
 }
 
 # Check the maintainer scripts.

Attachment: signature.asc
Description: Digital signature


Reply to: