[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#349614: marked as done (manpage-has-errors-from-man: "No such file or directory" false positives)

Your message dated Sun, 26 Mar 2006 06:17:06 -0800
with message-id <E1FNW3G-0000xd-2d@spohr.debian.org>
and subject line Bug#349614: fixed in lintian 1.23.16
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message --- 
Package: lintian
Version: 1.23.14
Severity: normal
Tags: patch

Hello,

Some "No such file or directory" false positives are caused by manpages
including other manpages (with the .so request).
When man is used with a local file, the MANPATH is not used, thus the
included man page must be in the path (i.e. with ".so man1/foo.1", the
current directory must contain the man1 directory).

I propose to cd to the right directory before calling man.


Note: I don't know why $file needed to be quoted (\Q$file\E). Please check
if something else needs to be quoted in my patch.


You can test the patch with the bash package.


-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.14
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)

Versions of packages lintian depends on:
ii  binutils             2.16.1cvs20051214-1 The GNU assembler, linker and bina
ii  diffstat             1.41-1              produces graph of changes introduc
ii  dpkg-dev             1.13.11.1           package building tools for Debian
ii  file                 4.15-2              Determines file type using "magic"
ii  gettext              0.14.5-2            GNU Internationalization utilities
ii  intltool-debian      0.34.1+20050828     Help i18n of RFC822 compliant conf
ii  libparse-debianchang 1.0-1               parse Debian changelogs and output
ii  man-db               2.4.3-3             The on-line manual pager
ii  perl [libdigest-md5- 5.8.7-10            Larry Wall's Practical Extraction 

lintian recommends no packages.

-- no debconf information

Thanks in advance,
-- 
Nekral

diff -rauN ../orig/lintian-1.23.14/checks/manpages ./lintian-1.23.14/checks/manpages
--- ../orig/lintian-1.23.14/checks/manpages	2005-08-12 21:49:07.000000000 +0200
+++ ./lintian-1.23.14/checks/manpages	2006-01-23 23:57:26.000000000 +0100
@@ -240,7 +240,14 @@
 	    }
 	}
 	# If it's not a .so link, run it through "man" to check for errors.
-	open MANERRS, '-|', "(LANG=C man -l unpacked/\Q$file\E >/dev/null) 2>&1"
+	my $cmd = "LANG=C man -l unpacked/\Q$file\E";
+	if ($file =~ m/^(.*)\/(man\d\/.*)$/) {
+		# Execute man in the directory that contains the manx
+		# directories. Otherwise, files included with .so won't be
+		# found.
+		$cmd = "cd unpacked/$1 && LANG=C man -l $2";
+	}
+	open MANERRS, '-|', "($cmd >/dev/null) 2>&1"
 	    or fail("cannot run man -l: $!");
 	while (<MANERRS>) {
 	    # ignore progress information from man

--- End Message ---
--- Begin Message --- 
Source: lintian
Source-Version: 1.23.16

We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive:

lintian_1.23.16.dsc
  to pool/main/l/lintian/lintian_1.23.16.dsc
lintian_1.23.16.tar.gz
  to pool/main/l/lintian/lintian_1.23.16.tar.gz
lintian_1.23.16_all.deb
  to pool/main/l/lintian/lintian_1.23.16_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 349614@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jeroen van Wolffelaar <jeroen@wolffelaar.nl> (supplier of updated lintian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 26 Mar 2006 15:38:37 +0200
Source: lintian
Binary: lintian
Architecture: source all
Version: 1.23.16
Distribution: unstable
Urgency: low
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Jeroen van Wolffelaar <jeroen@wolffelaar.nl>
Description: 
 lintian    - Debian package checker
Closes: 249435 322288 344269 344421 344998 347510 349272 349273 349614 349616 349792 350228 350653 351324 351624 352606 353294 353770 354890 357541 358523
Changes: 
 lintian (1.23.16) unstable; urgency=low
 .
   The "What's this Russ guy up to?" release
 .
   * checks/binaries{.desc,}:
     + [RA] Add a check for the new "Invalid operation" error from
       objdump -T.  Skip shared-lib-without-dependency-information for
       files in /usr/lib/debug.
   * checks/changelog-file:
     + [FL] Add line number to output of wrong-bug-number-in-closes.
       Inspired by #349761 from Steinar H. Gunderson.
   * checks/common_data.pm:
     + [FL] Add armeb to %non_standard_archs as requested by
       Martin Michlmayr. (Closes: #350653)
   * checks/debconf:
     + [RA] Packages that depend on dbconfig-common are allowed to have
       config scripts without templates or an explicit debconf dependency.
       Reported by Marcus Better.  (Closes: #344421)
   * checks/debconf.desc:
     + [RA] Clarify the necessary dependencies for packages using SETTITLE.
       (Closes: #349616)
   * checks/debhelper:
     + [RA] Recognize setting DH_COMPAT with := in addition to = in
       debian/rules.  (Closes: #349272)
     + [RA] CDBS sets DH_COMPAT to 4 but doesn't export it.  It does create
       debian/compat with that value if none was present.  Reflect this
       behavior to avoid spurious compat level warnings when using CDBS.
       Based on a patch by Jay Berkenbilt.  (Closes: #350228)
   * checks/fields:
     + [RA] Allow a quilt build-dependency for arch-independent packages if
       the quilt makefile rules are included.  (Closes: #349273)
     + [RA] If clean depends on a rule that calls dh_clean rather than
       calling it directly, still allow debhelper in Build-Depends for
       arch-independent packages.  Reported by Michael Stilkerich.
     + [JvW] Commented that Uploaders no longer will hit the multiline field
       issue, updated testsuite accordingly
   * checks/manpages:
     + [FL] Ignore more warnings ("cannot adjust line", "can't break
       line") in non-English manpages. (Closes: #349792)
     + [RA] cd into the parent directory before checking man pages with man
       so that .so inclusions are processed correctly.  Based on a patch by
       Nicolas François.  (Closes: #349614)
   * checks/menu-format:
     + [RA] Look for binaries in /usr/X11R6/bin, not /usr/bin/X11, per
       Policy 11.8.7.  Thanks, Matej Vela.  (Closes: #354890)
   * checks/menu-format.desc:
     + [RA] Use "menu manual" rather than "menu" for references to more
       clearly distinguish from the Debian Menu Policy.  (Closes: #347510)
   * checks/po-debconf:
     + [RA] If there are template files in debian, assume the package uses
       debconf; don't require a dependency or config script.  Patch by
       Thomas Huriaux.  (Closes: #353294)
   * checks/scripts:
     + [RA] Allow /tmp in variable settings.  It's likely to be a false
       positive.  Reported by Frank Küster.  (Closes: #344998)
     + [RA] Make the syntax checking of shell scripts more robust against
       filenames containing shell metacharacters.  Reported by Michael
       Stilkerich.
     + [RA] Add fish and expectk to the list of valid interpreters.
       (Closes: #351624, #353770)
     + [RA] /usr/bin/tcl is provided by tclx8.3, not tcl.  Reported by
       James R. Van Zandt.  (Closes: #351324)
     + [RA] Allow more variations on leading magic to invoke some
       interpreter rather than then shell.  Bypass the ELF magic check for
       scripts using magic that relies on having no leading #! line.
       Reported by Frank Küster.  (Closes: #344269)
     + [JvW] Add check against package suffering from debhelper bug #337664,
       per Joey Hess, which had broken error detection (Closes: #358523)
   * checks/shared-libs:
     + [JvW] Fix postinst-must-call-ldconfig to also get emitted when there is
       no postinst at all, instead of just one lacking a ldconfig call
     + [JvW] Implement checks for "udeb:" lines in shlibs files
       (Closes: #357541)
     + [JvW] Consider also the soname version for shlibs checking, preventing
       some bogus 'duplicate' warnings, and actually throw a warning when
       soname version doesn't match
     + [JvW] Added error when udeb postinst calls ldconfig, that must never
       happen (thanks to Frans Pop for noticing, see #203056)
 .
   * debian/{control,copyright}:
     + [RA] Add Russ Allbery to Uploaders and copyright.
     + [JvW] Version dpkg-dev requirement to >= 1.13.17, for
       unpack/unpack-srcpkg-l2
 .
   * frontends/lintian-info:
     + [RA] Avoid Perl uninitialized value warnings when given output that
       looks like lintian messages without tags.  (Closes: #352606)
 .
   * collection/objdump-info:
     + [RA] Pass "Invalid operation" errors from objdump -T on to the check
       scripts instead of failing.  (Closes: #249435)
 .
   * man/lintian.1:
     + [RA] Add references to dh_make, debhelper, dpkg-buildpackage, and
       linda in new reference sections.  (Closes: #322288)
   * man/{lintian.1,lintian-info.1}:
     + [RA] Left-justify and disable hyphenation for readability.
 .
   * unpack/unpack-srcpkg-l2:
     + [JvW] Use -q with dpkg-source to surpress warnings about unsigned source
       packages. Requires dpkg-dev 1.13.17
Files: 
 a8af61cb26ebdf096bf5fb370adf4444 867 devel optional lintian_1.23.16.dsc
 d823231fc846a486ec767203d7305862 273482 devel optional lintian_1.23.16.tar.gz
 c456a02e9c401c59cd4793bdc7b755c2 234118 devel optional lintian_1.23.16_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Signed by Jeroen van Wolffelaar <jeroen@wolffelaar.nl>

iD8DBQFEJqEll2uISwgTVp8RAjENAKCKtXb9zS9UQy/w4iBJHu4f51yMLACgkKZi
m6nRMEQo22hR9t288GmkT+s=
=SpzL
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: