[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

lintian: r525 - in trunk: checks debian testset testset/binary/debian



Author: djpig
Date: 2005-12-18 01:44:07 +0100 (Sun, 18 Dec 2005)
New Revision: 525

Modified:
   trunk/checks/binaries.desc
   trunk/debian/changelog
   trunk/testset/binary/debian/rules
   trunk/testset/tags.binary
Log:
The Debian specific patches from coreutils to call strip with --remove-section
arguments on install -s have been dropped. Adapt description of
binary-has-unneeded-section accordingly and demote it to "info" because
many packages will get this now.


Modified: trunk/checks/binaries.desc
===================================================================
--- trunk/checks/binaries.desc	2005-12-17 23:32:56 UTC (rev 524)
+++ trunk/checks/binaries.desc	2005-12-18 00:44:07 UTC (rev 525)
@@ -61,11 +61,14 @@
  Please contact &debdev; if you have questions about this.
 
 Tag: binary-has-unneeded-section
-Type: warning
+Type: info
 Info: The binary or shared library is stripped, but still contains a
- section that is not useful.  The utilities (<tt>install -s</tt>
- and <tt>dh_strip</tt>) are patched to remove the <tt>.note</tt> and
- <tt>.comment</tt> sections.
+ section that is not useful.  You should call strip with
+ <tt>--remove-section=.comment --remove-section=.note</tt> to remove the
+ <tt>.note</tt> and <tt>.comment</tt> sections.
+ .
+ <tt>dh_strip</tt> will do this automatically for you, but
+ <tt>install -s</tt> not because it calls strip without any arguments.
 
 Tag: missing-depends-line
 Type: warning

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog	2005-12-17 23:32:56 UTC (rev 524)
+++ trunk/debian/changelog	2005-12-18 00:44:07 UTC (rev 525)
@@ -14,6 +14,11 @@
   * checks/binaries{.desc,}:
     + [FL] support c2a suffix in soname check, too (Closes: #340856)
     + [FL] fix typo in description of package-name-doesnt-match-sonames (Closes: #339360)
+    + [FL] The Debian specific patches from coreutils to call strip with --remove-section
+      arguments on install -s have been dropped. Adapt description of binary-has-unneeded-section
+      accordingly and demote it to "info" because many packages will get this now.
+      (Policy only seems to demand stripping the symbols but doesn't talk about removing the
+      sections)
   * checks/debconf{.desc,}:
     + [FL] drop seen-flag-requires-versioned-depends and multiselect-without-dependency and
       drop version requirement from missing-debconf-dependency-for-preinst. All due to the

Modified: trunk/testset/binary/debian/rules
===================================================================
--- trunk/testset/binary/debian/rules	2005-12-17 23:32:56 UTC (rev 524)
+++ trunk/testset/binary/debian/rules	2005-12-18 00:44:07 UTC (rev 525)
@@ -15,10 +15,14 @@
 	install -m 755 hello $(tmp)/usr/bin
 	touch $(tmp)/usr/bin/iminusrbin
 	chmod 755 $(tmp)/usr/bin/iminusrbin
-	install -s -m 755 hello-static $(tmp)/usr/bin
-	install -s -m 755 hello-static $(tmp)/usr/bin/hello.static
-	install -s -m 755 hello-static $(tmp)/usr/bin/static-hello
-	install -s -m 755 hello-static $(tmp)/boot/hello
+	install -m 755 hello-static $(tmp)/usr/bin
+	strip $(tmp)/usr/bin/hello-static
+	install -m 755 hello-static $(tmp)/usr/bin/hello.static
+	strip --remove-section=.comment --remove-section=.note $(tmp)/usr/bin/hello.static
+	install -m 755 hello-static $(tmp)/usr/bin/static-hello
+	strip --remove-section=.comment --remove-section=.note $(tmp)/usr/bin/static-hello
+	install -m 755 hello-static $(tmp)/boot/hello
+	strip --remove-section=.comment --remove-section=.note $(tmp)/boot/hello/hello-static
 	install -d $(tmp)/usr/share/doc/binary
 	install -m 644 INSTALL $(tmp)/usr/share/doc/binary
 	install -d $(tmp)/usr/share/menu

Modified: trunk/testset/tags.binary
===================================================================
--- trunk/testset/tags.binary	2005-12-17 23:32:56 UTC (rev 524)
+++ trunk/testset/tags.binary	2005-12-18 00:44:07 UTC (rev 525)
@@ -18,6 +18,7 @@
 I: binary source: non-standard-architecture kfreebsd-i386
 I: binary source: non-standard-architecture ppc64
 I: binary: arch-dep-package-has-big-usr-share
+I: binary: binary-has-unneeded-section ./usr/bin/hello-static .comment
 W: binary source: ancient-standards-version 3.2.1
 W: binary source: maintainer-upload-has-incorrect-version-number 4-1.1
 W: binary source: native-package-with-dash-version



Reply to: