[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

lintian: r452 - in trunk: checks debian testset testset/diffs/debian



Author: djpig
Date: 2005-07-23 16:35:37 +0200 (Sat, 23 Jul 2005)
New Revision: 452

Modified:
   trunk/checks/changelog-file
   trunk/checks/changelog-file.desc
   trunk/debian/changelog
   trunk/testset/diffs/debian/changelog
   trunk/testset/tags.diffs
Log:
Detect closes: statements with non-valid bugnumbers,
suggested by martin f. krafft (Closes: #294409)


Modified: trunk/checks/changelog-file
===================================================================
--- trunk/checks/changelog-file	2005-07-23 13:43:47 UTC (rev 451)
+++ trunk/checks/changelog-file	2005-07-23 14:35:37 UTC (rev 452)
@@ -257,6 +257,14 @@
 open IN, "changelog" or fail("cannot find changelog for $type package $pkg");
 my ($prefix, $suffix);
 while (<IN>) {
+
+    if (/closes:\s*((?:bug)?\#?\s?\d*[[:alpha:]]\w*)/io
+	|| /closes:\s*(?:bug)?\#?\s?\d+
+	      (?:,\s*(?:bug)?\#?\s?\d+)*
+	      (?:,\s*((?:bug)?\#?\s?\d*[[:alpha:]]\w*))/iox) {
+	tag "wrong-bug-number-in-closes", $1;
+    }
+
     if (/^(.*)Local variables:(.*)$/i) {
 	$prefix = $1;
 	$suffix = $2;

Modified: trunk/checks/changelog-file.desc
===================================================================
--- trunk/checks/changelog-file.desc	2005-07-23 13:43:47 UTC (rev 451)
+++ trunk/checks/changelog-file.desc	2005-07-23 14:35:37 UTC (rev 452)
@@ -127,3 +127,9 @@
 Tag: syntax-error-in-debian-changelog
 Type: warning
 Info: While parsing the Debian changelog, an syntax error was found.
+Ref: policy 4.4
+
+Tag: wrong-bug-number-in-closes
+Type: warning
+Info: Bug numbers can only contain digits.
+Ref: policy 4.4

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog	2005-07-23 13:43:47 UTC (rev 451)
+++ trunk/debian/changelog	2005-07-23 14:35:37 UTC (rev 452)
@@ -14,6 +14,8 @@
       latter file as the Debian changelog and only issuing
       debian-changelog-file-missing would be confusing then
       (Closes: #285152)
+    + [FL] Detect closes: statements with non-valid bugnumbers,
+      suggested by martin f. krafft (Closes: #294409)
   * checks/common_data.pm:
     + [FL] Fix typo (hurd-386 -> hurd-i386) from last release
       that lead to spurious warnings about unknown architectures

Modified: trunk/testset/diffs/debian/changelog
===================================================================
--- trunk/testset/diffs/debian/changelog	2005-07-23 13:43:47 UTC (rev 451)
+++ trunk/testset/diffs/debian/changelog	2005-07-23 14:35:37 UTC (rev 452)
@@ -1,5 +1,10 @@
 diffs (1-1) unstable; urgency=low
 
   * Initial version
+  (Closes: #123456)
+  (Closes: #nnnnnn)
+  (Closes: #123nnn)
+  (Closes: #1, #foo)
+  (Closes: #1, #2, #bar)
 
  -- Lintian Maintainers <lintian-maint@debian.org>  Wed, 27 Nov 2002 14:15:00 +0100

Modified: trunk/testset/tags.diffs
===================================================================
--- trunk/testset/tags.diffs	2005-07-23 13:43:47 UTC (rev 451)
+++ trunk/testset/tags.diffs	2005-07-23 14:35:37 UTC (rev 452)
@@ -13,3 +13,7 @@
 W: diffs source: configure-generated-file-in-source subdir-good/config.status
 W: diffs source: out-of-date-standards-version 3.5.9
 W: diffs: binary-without-manpage diffs
+W: diffs: wrong-bug-number-in-closes #123nnn
+W: diffs: wrong-bug-number-in-closes #bar
+W: diffs: wrong-bug-number-in-closes #foo
+W: diffs: wrong-bug-number-in-closes #nnnnnn



Reply to: