[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

lintian: r439 - in trunk: checks debian man testset



Author: he
Date: 2005-07-10 16:59:08 +0200 (Sun, 10 Jul 2005)
New Revision: 439

Removed:
   trunk/checks/rules
   trunk/checks/rules.desc
Modified:
   trunk/debian/changelog
   trunk/man/lintian.1
   trunk/testset/tags.binary
   trunk/testset/tags.empty
   trunk/testset/tags.etcfiles
   trunk/testset/tags.libbaz
Log:
Remove rules check, as there were some "unexpected" problems. This is done as
a new commit, as the needed changes are mixed up with other changes :-/


Deleted: trunk/checks/rules
===================================================================
--- trunk/checks/rules	2005-07-10 14:15:56 UTC (rev 438)
+++ trunk/checks/rules	2005-07-10 14:59:08 UTC (rev 439)
@@ -1,44 +0,0 @@
-# rules -- lintian check script
-
-# Copyright (C) 2005 René van Bevern <rvb@pro-linux.de>
-#
-# This program is free software; you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation; either version 2 of the License, or
-# (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-
-package Lintian::rules;
-use strict;
-use Tags;
-use Util;
-
-sub run {
-	my $rules = 'debian/rules';
-	my @required_targets = ('build', 'binary', 'binary-arch',
-	                        'binary-indep', 'clean');
-
-	fail 'unpacked source tree is unavailable' unless -d 'unpacked';
-
-	# check for #!/usr/bin/make -f
-	open (RULES, '<', "unpacked/$rules") or fail "Could not open unpacked/$rules";
-	unless (<RULES> =~ /#!\s*\/usr\/bin\/make\s+-f/) {
-		tag 'debian-rules-not-a-makefile';
-	}
-	close RULES;
-
-	# check for missing targets
-	foreach my $target (@required_targets) {
-		if ((system "make -C unpacked -f $rules -n $target > /dev/null 2>&1") != 0) {
-			tag 'debian-rules-lacks-target', $target;
-		}
-	}
-}
-
-1;
-
-# vim: syntax=perl sw=4 ts=4 noet shiftround

Deleted: trunk/checks/rules.desc
===================================================================
--- trunk/checks/rules.desc	2005-07-10 14:15:56 UTC (rev 438)
+++ trunk/checks/rules.desc	2005-07-10 14:59:08 UTC (rev 439)
@@ -1,20 +0,0 @@
-Check-Script: rules
-Author: Rene van Bevern <rvb@pro-linux.de>
-Standards-Version: 3.6.1.1
-Type: source
-Unpack-Level: 2
-Info: checks for common problems in debian/rules
-Abbrev: rls
-
-Tag: debian-rules-lacks-target
-Type: error
-Ref: policy 4.8
-Info: Your debian/rules lacks or contains an errorneous target.
- The Debian policy requires that the debian/rules provides at least the
- clean, binary, binary-arch, binary-indep and build targets.
-
-Tag: debian-rules-not-a-makefile
-Type: error
-Ref: policy 4.8
-Info: Your debian/rules is not a Makefile. Make sure that your script
- starts with something like "#!/usr/bin/make -f" in its first line.

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog	2005-07-10 14:15:56 UTC (rev 438)
+++ trunk/debian/changelog	2005-07-10 14:59:08 UTC (rev 439)
@@ -23,11 +23,6 @@
     + [HE] Allow backupninja configuration files in /etc/backup.d/ to be 
       0600. (Closes: #307639)
 
-  * checks/rules:
-    + [HE] New file with two new tests, checking that debian/rules is a 
-      Makefile and that it contains rules for all mandatory targets.
-      Patch by Ren�an Bevern, thanks for the work. (Closes: #311786)
-
   * checks/scripts:
     + [HE] Allow Scripts in /etc/Xsession.d/ to be not executable, as they're
       not directly called, but only sourced. (Closes: #309203)

Modified: trunk/man/lintian.1
===================================================================
--- trunk/man/lintian.1	2005-07-10 14:15:56 UTC (rev 438)
+++ trunk/man/lintian.1	2005-07-10 14:59:08 UTC (rev 439)
@@ -459,10 +459,6 @@
 Looks for common mistakes in packages using po\-debconf.
 
 .TP
-.B rules (rls)
-Checks for common problems in debian/rules files.
-
-.TP
 .B scripts (scr)
 Check the the \fB#!\fR lines of scripts in a binary package.
 

Modified: trunk/testset/tags.binary
===================================================================
--- trunk/testset/tags.binary	2005-07-10 14:15:56 UTC (rev 438)
+++ trunk/testset/tags.binary	2005-07-10 14:59:08 UTC (rev 439)
@@ -1,4 +1,3 @@
-E: binary source: debian-rules-lacks-target binary-indep
 E: binary: changelog-file-not-compressed changelog
 E: binary: debian-changelog-file-missing
 E: binary: file-directly-in-usr-share usr/share/baz

Modified: trunk/testset/tags.empty
===================================================================
--- trunk/testset/tags.empty	2005-07-10 14:15:56 UTC (rev 438)
+++ trunk/testset/tags.empty	2005-07-10 14:59:08 UTC (rev 439)
@@ -1,4 +1,3 @@
-E: empty source: debian-rules-lacks-target binary-arch
 E: empty source: maintainer-address-missing empty
 E: empty source: no-standards-version-field
 E: empty: maintainer-address-missing empty

Modified: trunk/testset/tags.etcfiles
===================================================================
--- trunk/testset/tags.etcfiles	2005-07-10 14:15:56 UTC (rev 438)
+++ trunk/testset/tags.etcfiles	2005-07-10 14:59:08 UTC (rev 439)
@@ -1,4 +1,3 @@
-E: etcfiles source: debian-rules-lacks-target binary-arch
 E: etcfiles: changelog-file-not-compressed changelog
 E: etcfiles: file-in-etc-not-marked-as-conffile /etc/improper
 E: etcfiles: file-in-etc-not-marked-as-conffile /etc/improper-link

Modified: trunk/testset/tags.libbaz
===================================================================
--- trunk/testset/tags.libbaz	2005-07-10 14:15:56 UTC (rev 438)
+++ trunk/testset/tags.libbaz	2005-07-10 14:59:08 UTC (rev 439)
@@ -1,4 +1,3 @@
-E: libbaz source: debian-rules-lacks-target binary-indep
 E: libbaz1: file-directly-in-usr-share-doc usr/share/doc/README.Debian
 E: libbaz1: ldconfig-symlink-missing-for-shlib usr/lib/libbaz2.so.1.0 usr/lib/libfoo2.so.1.0.3b libbaz2.so.1.0
 E: libbaz1: maintainer-shell-script-fails-syntax-check postinst



Reply to: