[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#323098: marked as done (lintian: while [[ is a bashism, [[:space:]] & co. are POSIX)



Your message dated Sun, 28 Aug 2005 13:47:08 -0700
with message-id <E1E9U3Y-0004bZ-00@spohr.debian.org>
and subject line Bug#323098: fixed in lintian 1.23.12
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 14 Aug 2005 17:45:35 +0000
>From steve@lobefin.net Sun Aug 14 10:45:35 2005
Return-path: <steve@lobefin.net>
Received: from mail.lobefin.net [216.158.52.98] (Debian-exim)
	by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
	id 1E4MYB-0003qQ-00; Sun, 14 Aug 2005 10:45:35 -0700
Received: from pcp0010067675pcs.avalon01.nj.comcast.net ([68.37.128.33] helo=deepblue.lobefin.net)
	by mail.lobefin.net with asmtp (TLS-1.0:RSA_AES_128_CBC_SHA:16)
	(Exim 4.34)
	id 1E4MYA-000813-Pk; Sun, 14 Aug 2005 13:45:34 -0400
Received: from steve by deepblue.lobefin.net with local (Exim 4.52)
	id 1E4MYO-0008IB-3S; Sun, 14 Aug 2005 13:45:48 -0400
Date: Sun, 14 Aug 2005 13:45:48 -0400
From: Stephen Gran <sgran@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: lintian: while [[ is a bashism, [[:space:]] & co. are POSIX
Message-ID: <[🔎] 20050814174548.GA31857@deepblue.lobefin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-Reportbug-Version: 3.15
X-Editor: VIM - Vi IMproved 6.3 
X-OS: Linux deepblue 2.6.11-9-amd64-k8 x86_64
X-Uptime: 5:42
X-Latin: Hodie postridie Idus Augustas MMDCCLVIII ab urbe condita est
X-Date: Today is Sweetmorn, the 7th day of Bureaucracy in the YOLD 3171
X-DDate: Only 2431015 Shopping Days Left Before X-Day. Pzat! 
X-Motto: debian/rules
User-Agent: Mutt/1.5.9i
X-Authenticated-Sender: steve
X-Scanned-By: ClamAV at mail.lobefin.net
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02

Package: lintian
Version: 1.23.11
Severity: normal

The test introduced as a result of 296233 is a little overzealous,
catching valid POSIX regular expressions.  The patch below fixes it,
hopefully correctly.

--- checks/scripts.old  2005-08-14 13:28:30.000000000 -0400
+++ checks/scripts      2005-08-14 13:35:13.000000000 -0400
@@ -461,7 +461,7 @@
                  '(?:^|\s+)(trap\s+["\']?.*["\']?\s+.*[1-9])', # trap with sign
al numbers
                  '(?:^|\s+)(local)\s',        # local scoping of variables
                  '(\&>)',                     # cshism
-                 '(\[\[)',                    # alternative test command
+                 '(\[\[[^:(alnum|alpha|blank|cntrl|digit|graph|lower|print|punc
t|space|upper|xdigit)])', # alternative test command, but not POSIX regex
                );
 
                for my $re (@bashism_regexs) {


I think I've got them all there - check
http://www.opengroup.org/onlinepubs/009695399/toc.htm section 9.3.5.6 to
double check.

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.11-9-amd64-k8
Locale: LANG=C, LC_CTYPE=en_US.ISO-8859-15 (charmap=ISO-8859-15) (ignored: LC_ALL set to en_US.ISO-8859-15)

Versions of packages lintian depends on:
ii  binutils                   2.16.1-2      The GNU assembler, linker and bina
ii  diffstat                   1.39-1        produces graph of changes introduc
ii  file                       4.12-1        Determines file type using "magic"
ii  gettext                    0.14.5-2      GNU Internationalization utilities
ii  intltool-debian            0.30+20040213 Help i18n of RFC822 compliant conf
ii  libparse-debianchangelog-p 0.6-1         parse Debian changelogs and output
ii  man-db                     2.4.3-1       The on-line manual pager
ii  perl [libdigest-md5-perl]  5.8.7-4       Larry Wall's Practical Extraction 

lintian recommends no packages.

-- no debconf information

---------------------------------------
Received: (at 323098-close) by bugs.debian.org; 28 Aug 2005 20:48:50 +0000
>From katie@spohr.debian.org Sun Aug 28 13:48:50 2005
Return-path: <katie@spohr.debian.org>
Received: from katie by spohr.debian.org with local (Exim 3.36 1 (Debian))
	id 1E9U3Y-0004bZ-00; Sun, 28 Aug 2005 13:47:08 -0700
From: Frank Lichtenheld <djpig@debian.org>
To: 323098-close@bugs.debian.org
X-Katie: $Revision: 1.56 $
Subject: Bug#323098: fixed in lintian 1.23.12
Message-Id: <E1E9U3Y-0004bZ-00@spohr.debian.org>
Sender: Archive Administrator <katie@spohr.debian.org>
Date: Sun, 28 Aug 2005 13:47:08 -0700
Delivered-To: 323098-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-CrossAssassin-Score: 7

Source: lintian
Source-Version: 1.23.12

We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive:

lintian_1.23.12.dsc
  to pool/main/l/lintian/lintian_1.23.12.dsc
lintian_1.23.12.tar.gz
  to pool/main/l/lintian/lintian_1.23.12.tar.gz
lintian_1.23.12_all.deb
  to pool/main/l/lintian/lintian_1.23.12_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 323098@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Frank Lichtenheld <djpig@debian.org> (supplier of updated lintian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 28 Aug 2005 22:05:54 +0200
Source: lintian
Binary: lintian
Architecture: source all
Version: 1.23.12
Distribution: unstable
Urgency: low
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Frank Lichtenheld <djpig@debian.org>
Description: 
 lintian    - Debian package checker
Closes: 320382 321206 321564 321650 322241 322291 323098 324121 324255 324673 325225
Changes: 
 lintian (1.23.12) unstable; urgency=low
 .
   * The "bad, bad SONAME check" release
 .
   * all files:
     + [FL] Update FSF address
 .
   * debian/control:
     + [FL] Depend on dpkg-dev since we use dpkg-source. How old exactly is
       this bug? (Closes: #324673)
 .
   * checks/binaries:
     + [FL] Only use sonames from files in common library directories for
       the soname checks. This avoids many false positives. Patch by
       Russ Allbery (Closes: #321564)
     + [FL] Convert the SONAME to lower case before comparing with
       package name. Suggested by Josh Triplett (Closes: #321206, #325225)
     + [FL] Try to remove strings added for transition purposes from
       library package names before comparing package name with SONAME.
       Pointed out by Rene Engelhard (Closes: #322241, #324121)
     + [FL] Also remove -udeb strings and substitute lib64 with lib in
       package name before comparing with SONAME
     + [FL] Replace any occurence of _ in the SONAME with - since the
       former isn't allowed in package names but occasionally used in
       sonames
     + [FL] Remove trailing .so from SONAMEs
     + [FL] Also ignore static binaries in sub directories of /boot,
       not only in /boot itself. Patch by Guillem Jover
       (Closes: #320382)
   * checks/changelog-file:
     + [FL] Detect old FSF address additionally to the even older
       one
   * checks/{cruft,files}{,.desc}:
     + [FL] Also check for .arch-ids/ {arch}/ .arch-inventory and .bzr/
       in packages and sources (Closes: #324255)
   * checks/debhelper{,.desc}:
     + [FL] Warn about using debhelper compat version lower than 3
       like debhelper itself
     + [FL] Drop package-lacks-versioned-build-depends-on-debhelper
       tag for compat versions < 5. With debhelper 4 even in oldstable
       issuing an error here is silly
     + [FL] Fix typo (s,debian/control,debian/compat,) in description of
       declares-possibly-conflicting-debhelper-compat-versions
   * checks/description{,.desc}:
     + [FL] Avoid double warning about description-is-dh_make-template
       in the same way we do it for the corresponding debmake tag
     + [FL] Policy section of Description field has changed
   * checks/fields{,.desc}:
     + [FL] Fix a lot of off-by-one errors in the policy references
       (caused by the addition of the Uploaders field). Unknowningly
       pointed out by Russ Allbery
     + [FL] Also use non_standards_archs when checking source package
       relations. Patch by Russ Allbery (Closes: #322291)
   * checks/manpages:
     + [FL] Don't issue warnings about 8bit characters in translated
       man pages. Patch by Denis Barbier (Closes: #321650)
   * checks/scripts:
     + [FL] Don't issue bashism warning on POSIX character classes ([[:foo:]]).
       Noted by Stephen Gran (Closes: #323098)
     + [FL] Remove some useless groupings in the bashism regexes
Files: 
 326c28428894475e63c9cb7955735ff6 772 devel optional lintian_1.23.12.dsc
 59449ee2d6212df94668ebc6e2ac7b49 265933 devel optional lintian_1.23.12.tar.gz
 3dfc575fd98907065e572bbfdec942d6 230748 devel optional lintian_1.23.12_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFDEh6gQbn06FtxPfARAnKDAJ9ZLKxuW5gKq6RUG/crX5YSU5xLcQCfbjtd
S/u24ehyDtthkSWB5PmbEKo=
=df33
-----END PGP SIGNATURE-----



Reply to: