lintian: r481 - in trunk: checks debian
Author: djpig
Date: 2005-08-27 02:03:28 +0200 (Sat, 27 Aug 2005)
New Revision: 481
Modified:
trunk/checks/binaries
trunk/debian/changelog
Log:
Only use sonames from files in common library directories for
the soname checks. This avoids many false positives. Patch by
Russ Allbery (Closes: #321564)
Modified: trunk/checks/binaries
===================================================================
--- trunk/checks/binaries 2005-08-26 23:26:20 UTC (rev 480)
+++ trunk/checks/binaries 2005-08-27 00:03:28 UTC (rev 481)
@@ -113,7 +113,20 @@
}
close(IN);
-my @sonames = keys %SONAME;
+# For the package naming check, filter out SONAMEs where all the files are
+# at paths other than /lib, /usr/lib, or /usr/X11R6/lib. This avoids false
+# positives with plugins like Apache modules, which may have their own
+# SONAMEs but which don't matter for the purposes of this check.
+sub lib_soname_path {
+ my (@paths) = @_;
+ foreach my $path (@paths) {
+ return 1 if $path =~ m%^(\.?/)?lib/[^/]+$%;
+ return 1 if $path =~ m%^(\.?/)?usr/lib/[^/]+$%;
+ return 1 if $path =~ m%^(\.?/)?usr/X11R6/lib/[^/]+$%;
+ }
+ return 0;
+}
+my @sonames = grep { lib_soname_path (@{$SONAME{$_}}) } keys %SONAME;
tag "several-sonames-in-same-package", "@sonames" if @sonames > 1;
# try to identify transition strings
Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog 2005-08-26 23:26:20 UTC (rev 480)
+++ trunk/debian/changelog 2005-08-27 00:03:28 UTC (rev 481)
@@ -8,6 +8,9 @@
this bug? (Closes: #324673)
* checks/binaries:
+ + [FL] Only use sonames from files in common library directories for
+ the soname checks. This avoids many false positives. Patch by
+ Russ Allbery (Closes: #321564)
+ [FL] Convert the SONAME to lower case before comparing with
package name. Suggested by Josh Triplett (Closes: #321206, #325225)
+ [FL] Try to remove strings added for transition purposes from
Reply to: