Bug#294661: lintian: Please increase limit when searching for shell exec hacks
Package: lintian
Version: 1.23.7
Severity: minor
Tags: patch
While building a new version of the aegis Debian package I got the
"shell-script-fails-syntax-check" error for a couple of tk
scripts. The reason is that the "exec wish $0 ${1+"$@"}" hack is
located after the copyright which is more than 20 lines
long. Therefore I propose to increase the apparently arbitrary limit
of 20 for searching a exec-hack to 40. Patch below:
--- /usr/share/lintian/checks/scripts-orig 2005-02-11 00:07:55.000000000 +0100
+++ /usr/share/lintian/checks/scripts 2005-02-11 00:08:23.000000000 +0100
@@ -522,7 +522,7 @@
open IN, $filename or fail("cannot open $filename: $!");
my $i = 0;
while (<IN>) {
- last if (++$i > 20);
+ last if (++$i > 40);
chomp;
if (/^\s*exec\s*.+\s*.?\$0.?\s*(--\s*)?(\${1\+)?.?\$\@/) {
$ret = 1;
-- System Information:
Debian Release: 3.1
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.10-rc2-mm4
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Versions of packages lintian depends on:
ii binutils 2.15-5 The GNU assembler, linker and bina
ii diffstat 1.35-1 produces graph of changes introduc
ii file 4.12-1 Determines file type using "magic"
ii gettext 0.14.1-7 GNU Internationalization utilities
ii intltool-debian 0.30+20040213 Help i18n of RFC822 compliant conf
ii man-db 2.4.2-21 The on-line manual pager
ii perl [libdigest-md5-perl] 5.8.4-5 Larry Wall's Practical Extraction
-- no debconf information
Reply to: