On Mon, Dec 06, 2004 at 01:43:28AM +0100, djpig@debian.org wrote:
<snip/>
> --- trunk/checks/scripts 2004-12-06 00:05:00 UTC (rev 373)
> +++ trunk/checks/scripts 2004-12-06 00:43:09 UTC (rev 374)
<snip/>
> @@ -229,9 +231,15 @@
> $filename =~ m,etc/menu-methods,);
>
> if (exists $valid_interpreters{$base}) {
> - tag_error("wrong-path-for-$base", $filename, "#!$interpreter")
> - unless ($interpreter eq $valid_interpreters{$base} or
> - defined $calls_env);
> + unless ($interpreter eq $valid_interpreters{$base} or
> + defined $calls_env) {
> + # save us from some copy and paste
> + if ($base =~ /^(ruby|python)(?:\d.\d)?$/) {
^^^^^
> + tag_error("wrong-path-for-$1", $filename, "#!$interpreter");
> + } else {
> + tag_error("wrong-path-for-$base", $filename, "#!$interpreter");
> + }
> + }
>
> # Do not complain about dependencies for non-executable scripts.
> if ($executable{$filename}) {
>
> Modified: trunk/checks/scripts.desc
> ===================================================================
> --- trunk/checks/scripts.desc 2004-12-06 00:05:00 UTC (rev 373)
> +++ trunk/checks/scripts.desc 2004-12-06 00:43:09 UTC (rev 374)
> @@ -329,7 +329,15 @@
> Tag: wrong-path-for-python
> Type: error
> Info: Python is installed as /usr/bin/python on Debian systems.
> + .
> + Specific Python versions are installed as /usr/bin/pythonX.Y
^
> +Tag: wrong-path-for-ruby
> +Type: error
> +Info: Ruby is installed as /usr/bin/ruby on Debian systems.
> + .
> + Specific Ruby versions are installed as /usr/bin/rubyX.Y
^
> Tag: python-script-but-no-python-dep
> Type: error
> Info: Packages with scripts that are executed with python must depend on the
<snip/>
For the regular expression I would expect '\d\.\d' ( digit, literal
point, digit )
HTH
Geert Stappers
Attachment:
signature.asc
Description: Digital signature