[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

lintian: r348 - in trunk: checks debian testset testset/maintainer-scripts/debian



Author: jeroen
Date: 2004-10-13 01:33:57 +0200 (Wed, 13 Oct 2004)
New Revision: 348

Added:
   trunk/testset/maintainer-scripts/debian/config
Modified:
   trunk/checks/scripts
   trunk/checks/scripts.desc
   trunk/debian/changelog
   trunk/testset/maintainer-scripts/debian/rules
   trunk/testset/tags.maintainer-scripts
Log:
checks/scripts:
+ [JvW] Give an error if the 'config' script uses a non-essential
  interpreter (Closes: #274832)


Modified: trunk/checks/scripts
===================================================================
--- trunk/checks/scripts	2004-10-12 22:58:39 UTC (rev 347)
+++ trunk/checks/scripts	2004-10-12 23:33:57 UTC (rev 348)
@@ -331,8 +331,9 @@
     if (exists $valid_interpreters{$base}) {
 	tag_error("wrong-path-for-$base", $filename, "#!$interpreter")
 	    unless ($interpreter eq $valid_interpreters{$base});
-	
-	tag "unusual-control-interpreter", "$filename #!$interpreter"
+	tag $file eq 'config'?
+	    "forbidden-config-interpreter":"unusual-control-interpreter",
+	    "#!$interpreter"
 	    unless ($base eq 'sh'
 		    or $base eq 'bash'
 		    or $base eq 'perl');

Modified: trunk/checks/scripts.desc
===================================================================
--- trunk/checks/scripts.desc	2004-10-12 22:58:39 UTC (rev 347)
+++ trunk/checks/scripts.desc	2004-10-12 23:33:57 UTC (rev 348)
@@ -37,6 +37,12 @@
  interpreter.  If not, please contact the Lintian maintainers so that
  they can add this interpreter to their list.
 
+Tag: forbidden-config-interpreter
+Type: error
+Info: This package contains a 'config' script for pre-configuring the package,
+ however, at that time only essential packages are guaranteed to be installed,
+ so you cannot use a non-essential interpreter
+
 Tag: unusual-control-interpreter
 Type: info
 Info: This package contains a control script for an interpreter that

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog	2004-10-12 22:58:39 UTC (rev 347)
+++ trunk/debian/changelog	2004-10-12 23:33:57 UTC (rev 348)
@@ -27,8 +27,10 @@
   * checks/scripts:
     + [JvW] The php commandline interpreter is now provided by php4-cli, and
       not php4-cgi, update dependency check accordingly (Closes: #268077)
+    + [JvW] Give an error if the 'config' script uses a non-essential
+      interpreter (Closes: #274832)
 
- -- Debian Lintian Maintainers <lintian-maint@debian.org>  Thu, 26 Aug 2004 02:19:20 +0200
+ -- Jeroen van Wolffelaar <jeroen@wolffelaar.nl>  Wed, 13 Oct 2004 01:14:41 +0200
 
 lintian (1.23.2) unstable; urgency=low
 

Added: trunk/testset/maintainer-scripts/debian/config
===================================================================
--- trunk/testset/maintainer-scripts/debian/config	2004-10-12 22:58:39 UTC (rev 347)
+++ trunk/testset/maintainer-scripts/debian/config	2004-10-12 23:33:57 UTC (rev 348)
@@ -0,0 +1,3 @@
+#!/usr/bin/python
+
+# I use python, but that's not what I'm supposed to be allowed to use

Modified: trunk/testset/maintainer-scripts/debian/rules
===================================================================
--- trunk/testset/maintainer-scripts/debian/rules	2004-10-12 22:58:39 UTC (rev 347)
+++ trunk/testset/maintainer-scripts/debian/rules	2004-10-12 23:33:57 UTC (rev 348)
@@ -6,6 +6,7 @@
 
 binary-indep:
 	install -d debian/tmp/DEBIAN
+	cp debian/config debian/tmp/DEBIAN
 	cp debian/postinst debian/tmp/DEBIAN
 	chmod +x debian/tmp/DEBIAN/postinst
 	cp debian/prerm debian/tmp/DEBIAN

Modified: trunk/testset/tags.maintainer-scripts
===================================================================
--- trunk/testset/tags.maintainer-scripts	2004-10-12 22:58:39 UTC (rev 347)
+++ trunk/testset/tags.maintainer-scripts	2004-10-12 23:33:57 UTC (rev 348)
@@ -1,5 +1,9 @@
 E: maintainer-scripts source: orphaned-package-should-not-have-uploaders
 E: maintainer-scripts source: wrong-debian-qa-group-name QA group <packages@qa.debian.org>
+E: maintainer-scripts: control-file-has-bad-permissions config 0644 != 0755
+E: maintainer-scripts: debconf-config-not-executable
+E: maintainer-scripts: forbidden-config-interpreter #!/usr/bin/python
+E: maintainer-scripts: interpreter-without-predep control/config #!/usr/bin/python
 E: maintainer-scripts: maintainer-script-does-not-check-for-existence-of-wm-menu-config postinst:28
 E: maintainer-scripts: maintainer-shell-script-fails-syntax-check prerm
 E: maintainer-scripts: no-copyright-file
@@ -7,7 +11,10 @@
 W: maintainer-scripts source: ancient-standards-version 3.1.1
 W: maintainer-scripts source: changelog-should-mention-qa
 W: maintainer-scripts source: qa-upload-has-incorrect-version-number 7-0.1
+W: maintainer-scripts: config-does-not-load-confmodule
 W: maintainer-scripts: maintainer-script-calls-deprecated-wm-menu-config postinst:28
+W: maintainer-scripts: missing-debconf-dependency
+W: maintainer-scripts: no-debconf-templates
 W: maintainer-scripts: possible-bashism-in-maintainer-script postinst:12 '. /usr/share/lintian/shell foo'
 W: maintainer-scripts: possible-bashism-in-maintainer-script postinst:15 'read'
 W: maintainer-scripts: possible-bashism-in-maintainer-script postinst:17 'H[0]='
@@ -16,6 +23,8 @@
 W: maintainer-scripts: possible-bashism-in-maintainer-script prerm:19 '[ "$2" == '
 W: maintainer-scripts: possible-bashism-in-maintainer-script prerm:23 'function foo( )'
 W: maintainer-scripts: possible-bashism-in-maintainer-script prerm:27 'source $FOO'
+W: maintainer-scripts: postinst-does-not-load-confmodule
 W: maintainer-scripts: postinst-should-not-set-usr-doc-link
+W: maintainer-scripts: postrm-does-not-purge-debconf
 W: maintainer-scripts: postrm-has-useless-call-to-ldconfig
 W: maintainer-scripts: update-alternatives-remove-called-in-postrm



Reply to: