Bug#257650: [collection/debfiles,checks/changelog] should cope with changelog beeing a symlink
Package: lintian
Severity: minor
I forward it to the BTS to not forget it. It's a minor issue since
it only affects one or two packages in the archive.
----- Forwarded message from Jeroen van Wolffelaar <jeroen@wolffelaar.nl> -----
X-Original-To: debian-lint-maint@lists.debian.org
To: debian-lint-maint@lists.debian.org
Subject: Re: Request comments for patch regarding debfiles collection
From: Jeroen van Wolffelaar <jeroen@wolffelaar.nl>
X-Rc-Virus: 2004-06-20_01
X-Rc-Spam: 2004-06-23_01
X-Mailing-List: <debian-lint-maint@lists.debian.org> archive/latest/1555
On Fri, Jul 02, 2004 at 05:04:18PM +0200, Frank Lichtenheld wrote:
> The check of the fireflier source package fails because the debian/changelog
> file is a symlink to ../changelog. I propose to solve this issue by
> dereferencing all symlinks during the collection of the debian/ files.
> Patch:
>
>
> Index: collection/debfiles
> ===================================================================
> --- collection/debfiles (revision 306)
> +++ collection/debfiles (working copy)
> @@ -42,7 +42,7 @@
> or fail("cannot open unpacked/debian/ directory: $!");
> while (my $file=readdir(DEBIAN)) {
> next if -d $file;
> - spawn('cp', '-a', "unpacked/debian/$file", 'debfiles/') == 0
> + spawn('cp', '-Lrp', "unpacked/debian/$file", 'debfiles/') == 0
> or fail("cannot copy unpacked/debian/$file: $!");
> }
> closedir(DEBIAN);
>
> Has this approach any disadvantages or should I commit this patch?
Recursive symlinks?
Anyway, 'debian/changelog' being a symlink is awkward... Policy 4.4:
"Changes in the Debian version of the package should be briefly
explained in the Debian changelog file debian/changelog.", which a
willing mind can read as that debian/changelog must be a file, implying
it cannot be a symlink. What about checking whether debian/changelog is
a symlink, and bail out with a lintian warning if it is?
--Jeroen
----- End forwarded message -----
Gruesse,
--
Frank Lichtenheld <djpig@debian.org>
www: http://www.djpig.de/
Reply to: