[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

lintian: r297 - in trunk: checks debian testset testset/binary/debian



Author: he
Date: 2004-06-27 01:25:35 +0200 (Sun, 27 Jun 2004)
New Revision: 297

Modified:
   trunk/checks/menu-format
   trunk/debian/changelog
   trunk/testset/binary/debian/menu
   trunk/testset/binary/debian/rules
   trunk/testset/tags.binary
Log:
checks/menu-format:
  + [HE] Change menu-command-not-in-package to also look into the standard
    PATH. (Closes: #255155)
		  


Modified: trunk/checks/menu-format
===================================================================
--- trunk/checks/menu-format	2004-06-26 23:07:52 UTC (rev 296)
+++ trunk/checks/menu-format	2004-06-26 23:25:35 UTC (rev 297)
@@ -349,13 +349,16 @@
             unless ($cmd) {
 		tag "su-to-root-without--c", "/usr/lib/menu/$menufile:$linecount";
 	    } else {   
-		tag "menu-command-not-in-package", "/usr/lib/menu/$menufile:$linecount"
-		    if (!$file_index{".$cmd"} && ($tested_packages < 2)
+		tag "menu-command-not-in-package", "/usr/lib/menu/$menufile:$linecount $cmd"
+		    if (!($file_index{".$cmd"} 
+			|| grep {$file_index{".".$_.$cmd}} qw(/usr/local/bin/ /usr/bin/ /bin/ /usr/bin/X11/ /usr/games/)) # Check for binary in PATH
+			&& ($tested_packages < 2)
 			&& ($section !~ m:^WindowManagers/Modules:));
 	    }
 	} else {
 	    tag "menu-command-not-in-package", "/usr/lib/menu/$menufile:$linecount $com[0]"
-	        if ($com[0] && !$file_index{".$com[0]"}
+	        if ($com[0] && ! ($file_index{".$com[0]"}
+		    || grep {$file_index{".".$_.$com[0]}} qw(/usr/local/bin/ /usr/bin/ /bin/ /usr/bin/X11/ /usr/games/)) # Check for binary in PATH
 		    && ($tested_packages < 2)
 		    && ($section !~ m:^WindowManagers/Modules:));
 	}

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog	2004-06-26 23:07:52 UTC (rev 296)
+++ trunk/debian/changelog	2004-06-26 23:25:35 UTC (rev 297)
@@ -65,6 +65,8 @@
       to be available as executables, so don't issue
       menu-command-not-in-package in this case. Thanks to
       Manoj Srivastava for reporting (Closes: #247805)
+    + [HE] Change menu-command-not-in-package to also look into the standard
+      PATH. (Closes: #255155)
   * checks/po-debconf:
     + [JvW] Simply fail if stuff from gettext is missing.
   * checks/scripts:

Modified: trunk/testset/binary/debian/menu
===================================================================
--- trunk/testset/binary/debian/menu	2004-06-26 23:07:52 UTC (rev 296)
+++ trunk/testset/binary/debian/menu	2004-06-26 23:25:35 UTC (rev 297)
@@ -5,4 +5,5 @@
 ?package(binary):needs="wm" section="Apps/System" title="Run fdisk-wm" command="/usr/bin/su-to-root cfdisk"
 ?package(binary):needs="text" section="Apps/System" title="I'm not here!" command="/imnothere"
 ?package(binary,other-binary):needs="text" section="Apps/System" title="more than one required" command="other-bin -s omething"
-?package(binary):needs="wmmodule" section="WindowManagers/Modules" title="somemodule" command="ModuleCmd"
\ No newline at end of file
+?package(binary):needs="wmmodule" section="WindowManagers/Modules" title="somemodule" command="ModuleCmd"
+?package(binary):needs="text" section="Apps/System" title="I'm not in /usr/bin!" command="iminusrbin"

Modified: trunk/testset/binary/debian/rules
===================================================================
--- trunk/testset/binary/debian/rules	2004-06-26 23:07:52 UTC (rev 296)
+++ trunk/testset/binary/debian/rules	2004-06-26 23:25:35 UTC (rev 297)
@@ -12,6 +12,8 @@
 binary-arch: build
 	install -d $(tmp)/usr/bin
 	install -m 755 hello $(tmp)/usr/bin
+	touch $(tmp)/usr/bin/iminusrbin
+	chmod 755 $(tmp)/usr/bin/iminusrbin
 	install -s -m 755 hello-static $(tmp)/usr/bin
 	install -s -m 755 hello-static $(tmp)/usr/bin/hello.static
 	install -s -m 755 hello-static $(tmp)/usr/bin/static-hello

Modified: trunk/testset/tags.binary
===================================================================
--- trunk/testset/tags.binary	2004-06-26 23:07:52 UTC (rev 296)
+++ trunk/testset/tags.binary	2004-06-26 23:25:35 UTC (rev 297)
@@ -15,7 +15,7 @@
 E: binary: su-to-root-without-usr-sbin /usr/lib/menu/binary:4
 E: binary: suidregister-used-in-maintainer-script postinst
 E: binary: unstripped-binary-or-object ./usr/bin/hello
-I: binary: arch-dep-package-has-big-usr-share
+I: binary: arch-dep-package-has-big-usr-share 1540kB 55%
 W: binary source: ancient-standards-version 3.2.1
 W: binary source: maintainer-upload-has-incorrect-version-number 4-1.1
 W: binary source: native-package-with-dash-version
@@ -24,3 +24,5 @@
 W: binary: package-contains-upstream-install-documentation usr/share/doc/binary/INSTALL
 W: binary: unquoted-string-in-menu-item /usr/lib/menu/binary needs:1
 W: binary: unquoted-string-in-menu-item /usr/lib/menu/binary needs:2
+E: binary: binary-without-manpage iminusrbin
+W: binary: executable-not-elf-or-script ./usr/bin/iminusrbin



Reply to: