lintian: r174 - in trunk: checks debian

[jeroen@wolffelaar.nl]

Author: jeroen
Date: 2004-04-18 00:48:08 +0200 (Sun, 18 Apr 2004)
New Revision: 174

Modified:
   trunk/checks/fields
   trunk/checks/fields.desc
   trunk/debian/changelog
Log:
checks/fields:
+ [JvW] Check for welformed Debian-revision

debian/changelog:
+ Added entry for commit 172-173:
    checks/fields:
    + [JvW] Check for correct realname when QA mailadress used
+ Fix sorting



Modified: trunk/checks/fields
===================================================================
--- trunk/checks/fields	2004-04-17 21:32:39 UTC (rev 173)
+++ trunk/checks/fields	2004-04-17 22:48:08 UTC (rev 174)
@@ -66,10 +66,15 @@
 
 	if (my ($epoch, $upstream, $debian) = _valid_version($version)) {
 		if ($upstream !~ /^\d/i) {
-			print "W: $pkg $type: upstream-version-not-numeric\n";
+			print "W: $pkg $type: upstream-version-not-numeric $version\n";
 		}
+		$debian =~ /^-([^.]+)?(?:\.[^.]+)?(?:\.[^.]+)?(\..*)?$/;
+		if (not defined $1 or defined $2) {
+			print "W: $pkg $type: debian-revision-not-welformed $version\n";
+			return;
+		}
 	} else {
-		print "E: $pkg $type: bad-version-number\n";
+		print "E: $pkg $type: bad-version-number $version\n";
 	}
 }
 
@@ -453,9 +458,11 @@
 	print "E: $pkg $type: obsolete-field $field\n"
 	    if $known_obsolete_fields{$field};
 
+# TODO: why N: here? --Jeroen
 	print "N: $pkg $type: unknown-field-in-dsc $field\n"
 	    if ($type eq "source" && ! $known_source_fields{$field} && ! $known_obsolete_fields{$field});
 
+# TODO: why N: here? --Jeroen
 	print "N: $pkg $type: unknown-field-in-changes $field\n"
 	    if ($type eq "binary" && ! $known_binary_fields{$field} && ! $known_obsolete_fields{$field});
 }

Modified: trunk/checks/fields.desc
===================================================================
--- trunk/checks/fields.desc	2004-04-17 21:32:39 UTC (rev 173)
+++ trunk/checks/fields.desc	2004-04-17 22:48:08 UTC (rev 174)
@@ -40,6 +40,12 @@
 Info: The upstream version number should start with a digit. 
 Ref: policy 5.6.11
 
+Tag: debian-revision-not-welformed
+Type: warning
+Info: The debian version part (the part after the -) should consist of one to
+ three dot-seperated parts: one for maintainer release, two for source-NMU,
+ three for binary NMU.
+
 Tag: no-architecture-field
 Type: error
 Info: The package does not have an `Architecture:' field in its control file.

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog	2004-04-17 21:32:39 UTC (rev 173)
+++ trunk/debian/changelog	2004-04-17 22:48:08 UTC (rev 174)
@@ -74,8 +74,6 @@
       support for configurable compression algorithms (bzip2, for example),
       but this shouldn't be allowed before dpkg 1.11 hits stable. 
       (Closes: #159874)
-  * checks/fields.desc:
-    + [FL] Fix some wrong policy references
   * checks/fields:
     + [HE, FL] Nearly complete rewrite for clean up:
       - bad-relation seems to work better now (Closes: #171763)
@@ -84,7 +82,11 @@
     + [HE] Add check for an Origin field with "Debian" as value. 
       (Closes: #119618)
     + [HE] Reintroduce build-depends-without-arch-dep check with the patch
-      i proposed in #214231. (Closes: #242484)
+      I proposed in #214231. (Closes: #242484)
+    + [JvW] Check for welformed Debian-revision
+    + [JvW] Check for correct realname when QA mailadress used
+  * checks/fields.desc:
+    + [FL] Fix some wrong policy references
   * checks/files:
     + [HE] New check for compiled python files (*.pyc). Patch by David
       Kimdon <david@kimdon.org>, thanks. (Closes: #236606)