[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

lintian: r124 - in trunk: checks debian testset testset/scripts/debian



Author: he
Date: 2004-04-08 00:18:57 +0200 (Thu, 08 Apr 2004)
New Revision: 124

Modified:
   trunk/checks/files
   trunk/checks/files.desc
   trunk/debian/changelog
   trunk/testset/info_tags.scripts
   trunk/testset/scripts/debian/rules
   trunk/testset/tags.scripts
Log:
* checks/files:
  + [HE] New check for compiled python files (*.pyc). Patch by David
    Kimdon <david@kimdon.org>, thanks. (Closes: #236606)


Modified: trunk/checks/files
===================================================================
--- trunk/checks/files	2004-04-07 21:50:01 UTC (rev 123)
+++ trunk/checks/files	2004-04-07 22:18:57 UTC (rev 124)
@@ -332,6 +332,11 @@
 	}
     }
 
+    # ---------------- .pyc (compiled python files
+    if ($file =~ m,^usr/lib/python\d\.\d/.*.pyc$,) {
+	print "W: $pkg $type: package-installs-python-pyc $file\n"
+    }
+
     # ---------------- pythonX.Y extensions
     if ($file =~ m,^usr/lib/python\d\.\d/\S,
 	and not $file =~ m,^usr/lib/python\d\.\d/site-packages/,) {

Modified: trunk/checks/files.desc
===================================================================
--- trunk/checks/files.desc	2004-04-07 21:50:01 UTC (rev 123)
+++ trunk/checks/files.desc	2004-04-07 22:18:57 UTC (rev 124)
@@ -459,3 +459,9 @@
  <tt>/usr/share/perl5</tt>, not <tt>/usr/lib/perl5</tt>
  unless there is at least one architecture-dependent file
  in the module.
+
+Tag: package-installs-python-pyc
+Type: warning
+Info: Compiled python source files should not be included in the package.
+ These files should be removed from the package and created at package
+ installation time in the postinst. 

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog	2004-04-07 21:50:01 UTC (rev 123)
+++ trunk/debian/changelog	2004-04-07 22:18:57 UTC (rev 124)
@@ -13,6 +13,9 @@
       (Closes: #236846)
   * checks/fields.desc:
     + [FL] Fix some wrong policy references
+  * checks/files:
+    + [HE] New check for compiled python files (*.pyc). Patch by David
+      Kimdon <david@kimdon.org>, thanks. (Closes: #236606)
   * checks/manpages:
     + [FL] Two new errors: 1) if section number of directory and file
       differ, 2) if section number of file differs from what is expected

Modified: trunk/testset/info_tags.scripts
===================================================================
--- trunk/testset/info_tags.scripts	2004-04-07 21:50:01 UTC (rev 123)
+++ trunk/testset/info_tags.scripts	2004-04-07 22:18:57 UTC (rev 124)
@@ -24,7 +24,23 @@
 N:
 E: scripts: binary-without-manpage py2foo
 E: scripts: binary-without-manpage pyfoo
+E: scripts: binary-without-manpage suidperlfoo
+E: scripts: binary-without-manpage suidperlfoo2
 E: scripts: binary-without-manpage tkfoo
+W: scripts: setuid-binary usr/bin/suidperlfoo2 4755 root/root
+N:
+N:   The file is tagged SETUID. In some cases this is intentional, but in
+N:   other cases this is a bug. If it's intentional, please send a note to
+N:   lintian-maint@debian.org so that this exception would be recognized in
+N:   future versions of Lintian.
+N:
+W: scripts: setuid-binary usr/bin/suidperlfoo 4755 root/root
+W: scripts: package-installs-python-pyc usr/lib/python2.3/site-packages/test.pyc
+N:
+N:   Compiled python source files should not be included in the package.
+N:   These files should be removed from the package and created at package
+N:   installation time in the postinst.
+N:
 E: scripts: python-script-but-no-python-dep ./usr/bin/pyfoo
 N:
 N:   Packages with scripts that are executed with python must depend on the
@@ -40,6 +56,22 @@
 N:   will be more appropriate.
 N:
 E: scripts: python-script-but-no-python-dep ./usr/bin/py2foo
+E: scripts: suid-perl-script-but-no-perl-suid-dep ./usr/bin/suidperlfoo2
+N:
+N:   Packages that use perl scripts that are suid must depend on the
+N:   perl-suid package.
+N:   
+N:   In some cases a weaker relationship, such as Suggests or Recommends,
+N:   will be more appropriate.
+N:
+E: scripts: calls-suidperl-directly ./usr/bin/suidperlfoo
+N:
+N:   Since perl version 5.8.3-3, /usr/bin/suidperl shouldn't be called
+N:   directly anymore (and doing so will lead to errors in most cases) but
+N:   the script should just use /usr/bin/perl as interpreter which will
+N:   call suidperl automatically if the script has the suid permission bit
+N:   set.
+N:
 E: scripts: no-copyright-file
 N:
 N:   Each binary package has to include a plain file

Modified: trunk/testset/scripts/debian/rules
===================================================================
--- trunk/testset/scripts/debian/rules	2004-04-07 21:50:01 UTC (rev 123)
+++ trunk/testset/scripts/debian/rules	2004-04-07 22:18:57 UTC (rev 124)
@@ -9,6 +9,7 @@
 binary-indep:
 	install -d $(tmp)/usr/bin/
 	install -d $(tmp)/usr/share/doc/scripts/
+	install -d $(tmp)/usr/lib/python2.3/site-packages/
 	install -d $(tmp)/DEBIAN
 
 	install -m 755 pyfoo $(tmp)/usr/bin/
@@ -17,6 +18,7 @@
 	install -m 4755 perlfoo $(tmp)/usr/bin/suidperlfoo2
 	install -m 4755 suidperlfoo $(tmp)/usr/bin/
 	install -m 755 tkfoo $(tmp)/usr/bin/
+	touch $(tmp)/usr/lib/python2.3/site-packages/test.pyc
 	cp debian/changelog $(tmp)/usr/share/doc/scripts/changelog
 	gzip -9 $(tmp)/usr/share/doc/scripts/changelog
 

Modified: trunk/testset/tags.scripts
===================================================================
--- trunk/testset/tags.scripts	2004-04-07 21:50:01 UTC (rev 123)
+++ trunk/testset/tags.scripts	2004-04-07 22:18:57 UTC (rev 124)
@@ -7,6 +7,7 @@
 E: scripts: binary-without-manpage tkfoo
 W: scripts: setuid-binary usr/bin/suidperlfoo2 4755 root/root
 W: scripts: setuid-binary usr/bin/suidperlfoo 4755 root/root
+W: scripts: package-installs-python-pyc usr/lib/python2.3/site-packages/test.pyc
 E: scripts: python-script-but-no-python-dep ./usr/bin/pyfoo
 E: scripts: python-script-but-no-python-dep ./usr/bin/py2foo
 E: scripts: suid-perl-script-but-no-perl-suid-dep ./usr/bin/suidperlfoo2



Reply to: